From patchwork Thu Apr 25 11:37:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pankaj Raghav (Samsung)" X-Patchwork-Id: 13643177 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60869C4345F for ; Thu, 25 Apr 2024 11:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB0FC6B0082; Thu, 25 Apr 2024 07:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D60A06B0083; Thu, 25 Apr 2024 07:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28676B0085; Thu, 25 Apr 2024 07:37:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A5C936B0082 for ; Thu, 25 Apr 2024 07:37:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4E1A88052F for ; Thu, 25 Apr 2024 11:37:59 +0000 (UTC) X-FDA: 82047855078.01.F8B53D3 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 4791D4000A for ; Thu, 25 Apr 2024 11:37:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=uwRh5GQN; spf=pass (imf12.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714045077; a=rsa-sha256; cv=none; b=plU860AXnY1cdjxs+9TNIC8rz7RktF24MGFslGD9+tEU2fhyDQVKEIKu5zinn2jvYqcqr7 jbOtaVLua0FtW5MCNonOK7xXUOdzkYIn+ySB41RhMu3GmXWEFckDqB6BpLx0ONBxMa+XEB pipOWzIZeCMl8Ia/BfbIv4Z8usaGP1U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=uwRh5GQN; spf=pass (imf12.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714045077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=U8xxTfMBMOv/DYScjU0FP2xsJBK+AQKv6ki1ccbkX/A=; b=3v7IVaEnAvsKG7eC7gVY/6luga0HZM6iKv2Fozbvnh2obBTjmqEnam3ANywOZJHscYIPC5 fm3mTvRIeYFO+YwoivjdgaHeY7Rm6C4D7gNbj3OOS5qK5hGry1HLyfMbDByTXSVLaoBG2F BdAjHQqrT2swP18yhGmyYumB3z+o7+E= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4VQDPC594lz9sSp; Thu, 25 Apr 2024 13:37:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1714045071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U8xxTfMBMOv/DYScjU0FP2xsJBK+AQKv6ki1ccbkX/A=; b=uwRh5GQN2HBZrj6jGskurZbmTw7TtTazgVlZGxkbKiGdTfjn+DI5opyY916bNllTr/EvFF fHdWqMhE3ooOY4Pmb72Jo8X4Bigl8JFEiby5+/RpyGjz8QCjPATGVOtvJ/h4T8hfxbay8k dAoD2NMEJ77/rQwH/Bt/kzjiX8awcb/16yhhDGlCpjUPtjdQ8hcskT/NKQN8cFjqghPN96 9AY3IzVZc7EGrVIX5o6pP01gMP9c6fB4Q47yqNM12Foryn8SrynTSM7gH3RLnYHECPBIfu AwaDhjBlONBMbg1Ot7k3nLoYvkfIMlM0ZtB/HX4TQdPZypxaIFuSb+4tGNN4yg== From: "Pankaj Raghav (Samsung)" To: willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: [PATCH v4 00/11] enable bs > ps in XFS Date: Thu, 25 Apr 2024 13:37:35 +0200 Message-Id: <20240425113746.335530-1-kernel@pankajraghav.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4791D4000A X-Stat-Signature: q5eqzc7dpqtthjk6stdtuoyimagw9eqp X-Rspam-User: X-HE-Tag: 1714045077-51789 X-HE-Meta: U2FsdGVkX18eJT0/8myWzuVj0GKeQTrL02l9P7m+h13/SI7tFmtVkfxIZ2Fbvk8GLFWQDbyc1hr0N55jmeT0jgwTdaldcEYzKqxs0Wq6Gsa9aEjC5zQFej06tji8IdEpIu6Nm3fg9sJo9CtTcLvW7TcT8SsA0FhG33WSlMDtGXbFD+/5WuiRAkZvxtApHZKB4jUxPDyjgiIpFc8UKJhnvCUEeUmklOgc3Otsa8W8MdOZVh4TZ7glcylhMnChtagghM+OebqasqL9Y9uevLF3bzco+Ybfp4Sf1yfuzsGz2R0xXAvb1TGnKOt4Zu/lFlcRkRQAJuxeqm/Ld046VppEcquY4xBMd9+xRbWvQn2DMeVWXu8lmBYi+MZ0Z/23NAYoAMk8ki1jTB07QBljAkkPPhhKblkAVLTbDn6uJJHedzGrWLDbj+afhzzam50zEedr6KC0KFu1pAp617nDJn1mz4P/APnlLgxYbAdxSxOBWDOq5HmnDGOFo+Su4/ei1eE61t+mC6+QgWCumlbD6pFEB56VsnxJ2uaJ5/+diEfC6YlpO+5X0sSTXivhrS5jIhUwQKCHR8junZi1WRhy3N3tHplPTyIwLlp7vtgnWGdVmVKAbUlSzhHhrtCYH7J0cU1Xx6p3o/ee19JkJ7yAg8SRhIny5rxOuzgYUZ8G/jo2bnLHh1PPxEyTRmYmsWpS11Np5XyZiL46Af5KLgsn07dOYNcQu74mjXKNhfZZg4WWbz8rz5sJ84el/oYnyQt8OCB6a9DmEQ4TsJURpMP91E6QTPTDFvaV/jgr5qINzchOkpwK/OTX9736P5gz6zEp3qlgObumOksMX7kxJlCrCnFUlQmPT1UFcaiNbh6Lqvtpz8QrMZdt0CPwjTp7ASYF4PGUXedYqISwZOu3r+e65kImvE+punVzZuDSUNCRvr6bgdDqmVFLAT1ZFUTPTuG9K6ZYjLqCpTEPnlooNSe8m+w To8YQ7yL eZOnrTS8fQ58RM1OAYduF0og+fm6O1lqZ3g9SUieAbOj0fnfCBfWJszDDZz9kX5Bn/b4Op6rdSz5xERrm8PQeJFcaqRLVoBCY+23tb3HEJtMWiLhLyAnpHkvzBB7fubalaTgCIp9gpWTJkDnv981yDQ3p341WcZkoVg8HAQR6aPt41FWhzLdWbuutfARdrjnKMrwD9LL+g29VvcCZMKSMvZPXg+mtzRjvLjUxe/OtERM0aHo1ynBlKNeY2QTNB2lfJRGMcmfxn94P2DrCKJ6fZGIRPRDMQWNsxMPaErUAVmFlDDPz7C6RBdNT8pB/hRJpTscyFdrUgWJVM/yQy/CxRmagocJ/8SqdT03q4QAZsHmqF3v2U8OwiLanppLHt+t8FleI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pankaj Raghav This is the fourth version of the series that enables block size > page size (Large Block Size) in XFS. The context and motivation can be seen in cover letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], if someone would like more context on this effort. This series does not split a folio during truncation even though we have an API to do so due to some issues with writeback. While it is not a blocker, this feature can be added as a future improvement once we get the base patches upstream (See patch 7). A lot of emphasis has been put on testing using kdevops. The testing has been split into regression and progression. Regression testing: In regression testing, we ran the whole test suite to check for *regression on existing profiles due to the page cache changes. No regression was found with the patches added on top. Progression testing: For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. To compare it with existing support, an ARM VM with 64k base page system (without our patches) was used as a reference to check for actual failures due to LBS support in a 4k base page size system. There are some tests that assumes block size < page size that needs to be fixed. I have a tree with fixes for xfstests here [6], which I will be sending soon to the list. Already a part of this has been upstreamed to fstest. No new failures were found with the LBS support. We've done some preliminary performance tests with fio on XFS on 4k block size against pmem and NVMe with buffered IO and Direct IO on vanilla Vs + these patches applied, and detected no regressions. We also wrote an eBPF tool called blkalgn [7] to see if IO sent to the device is aligned and at least filesystem block size in length. Git tree: https://github.com/linux-kdevops/linux/tree/large-block-minorder-6.9-rc4 [1] https://lore.kernel.org/lkml/20230915183848.1018717-1-kernel@pankajraghav.com/ [2] https://lore.kernel.org/linux-xfs/20240213093713.1753368-1-kernel@pankajraghav.com/ [3] https://www.youtube.com/watch?v=ar72r5Xf7x4 [4] https://github.com/linux-kdevops/kdevops/blob/master/docs/xfs-bugs.md 489 non-critical issues and 55 critical issues. We've determined and reported that the 55 critical issues have all fall into 5 common XFS asserts or hung tasks and 2 memory management asserts. [5] https://lore.kernel.org/linux-xfs/fe7fec1c-3b08-430f-9c95-ea76b237acf4@samsung.com/ [6] https://github.com/linux-kdevops/fstests/tree/lbs-fixes [7] https://github.com/iovisor/bcc/pull/4813 Changes since v3: - Cap the PTE range to i_size for LBS configuration in folio_map_range() - Added Chinners kvmalloc xattr patches - Moved Hannes patches before adding the minorder patches to avoid confusion. - Added mapping_set_folio_order_range(). - Return EINVAL instead EAGAIN in split_huge_page_to_list_to_order() Changes since v2: - Simplified the filemap and readahead changes. (Thanks willy) - Removed DEFINE_READAHEAD_ALIGN. - Added minorder support to readahead_expand(). Changes since v1: - Round up to nearest min nr pages in ra_init - Calculate index in filemap_create instead of doing in filemap_get_pages - Remove unnecessary BUG_ONs in the delete path - Use check_shl_overflow instead of check_mul_overflow - Cast to uint32_t instead of unsigned long in xfs_stat_blksize Changes since RFC v2: - Move order 1 patch above the 1st patch - Remove order == 1 conditional in `fs: Allow fine-grained control of folio sizes`. This fixed generic/630 that was reported in the previous version. - Hide the max order and expose `mapping_set_folio_min_order` instead. - Add new helper mapping_start_index_align and DEFINE_READAHEAD_ALIGN - don't call `page_cache_ra_order` with min order in do_mmap_sync_readahead - simplify ondemand readahead with only aligning the start index at the end - Don't cap ra_pages based on bdi->io_pages - use `checked_mul_overflow` while calculating bytes in validate_fsb - Remove config lbs option - Add a warning while mounting a LBS kernel - Add Acked-by and Reviewed-by from Hannes and Darrick. Changes since RFC v1: - Added willy's patch to enable order-1 folios. - Unified common page cache effort from Hannes LBS work. - Added a new helper min_nrpages and added CONFIG_THP for enabling mapping_large_folio_support - Don't split a folio if it has minorder set. Remove the old code where we set extra pins if it has that requirement. - Split the code in XFS between the validation of mapping count. Put the icache code changes with enabling bs > ps. - Added CONFIG_XFS_LBS option - align the index in do_read_cache_folio() - Removed truncate changes - Fixed generic/091 with iomap changes to iomap_dio_zero function. - Took care of folio truncation scenario in page_cache_ra_unbounded() that happens after read_pages if a folio was found. - Sqaushed and moved commits around - Rebased on top of v6.8-rc4 Dave Chinner (1): xfs: use kvmalloc for xattr buffers Hannes Reinecke (1): readahead: rework loop in page_cache_ra_unbounded() Luis Chamberlain (1): filemap: allocate mapping_min_order folios in the page cache Matthew Wilcox (Oracle) (1): fs: Allow fine-grained control of folio sizes Pankaj Raghav (7): readahead: allocate folios with mapping_min_order in readahead mm: do not split a folio if it has minimum folio order requirement filemap: cap PTE range to be created to i_size in folio_map_range() iomap: fix iomap_dio_zero() for fs bs > system page size xfs: expose block size in stat xfs: make the calculation generic in xfs_sb_validate_fsb_count() xfs: enable block size larger than page size support fs/iomap/direct-io.c | 13 +++- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++--- fs/xfs/libxfs/xfs_ialloc.c | 5 ++ fs/xfs/libxfs/xfs_shared.h | 3 + fs/xfs/xfs_icache.c | 6 +- fs/xfs/xfs_iops.c | 2 +- fs/xfs/xfs_mount.c | 10 ++- fs/xfs/xfs_super.c | 10 +-- include/linux/pagemap.h | 116 ++++++++++++++++++++++++++++------ mm/filemap.c | 29 ++++++--- mm/huge_memory.c | 9 +++ mm/readahead.c | 94 +++++++++++++++++++++------ 12 files changed, 242 insertions(+), 70 deletions(-) base-commit: 0bbac3facb5d6cc0171c45c9873a2dc96bea9680