From patchwork Tue May 28 13:45:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13676756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8A8C27C44 for ; Tue, 28 May 2024 13:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E43A06B0092; Tue, 28 May 2024 09:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF2AB6B0095; Tue, 28 May 2024 09:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6B0E6B0098; Tue, 28 May 2024 09:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A861C6B0092 for ; Tue, 28 May 2024 09:45:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 299C0C0518 for ; Tue, 28 May 2024 13:45:24 +0000 (UTC) X-FDA: 82167926568.03.5EE5294 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf26.hostedemail.com (Postfix) with ESMTP id 2DD8A140015; Tue, 28 May 2024 13:45:19 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716903921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=JnlvitaKCdgqpqa2OeKNmYscz0yEDpfI1bQTqaEDRz4=; b=y/8SR4gtNfpuHiD5FKgHZd64CKr4TddUUBBZZbjuWxa1R/KNWqHU7sYlztdyCfVzq39VMW lcQJJquQXIKiPCMFuLsDMwN7ZIHi5HzuIEmGX76++gi4CqZXFH8j2qbNPlfIU5K1OiPXdo Bumx4KIu/SfimIPmmu4dUhzbieSqrWI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716903921; a=rsa-sha256; cv=none; b=JF+OA+UVC8gN/jms8XVZEByIemi6ScK+QSN0X37LIWzPT3265EW6rk9koMfDiUJRse+3K2 PhPtEDwkdR/9jFItC3xsjWkOcIgPybi89EmnqZiTouL0y/urjQE+6tJvIZ/bMNnrValFVu 6I7Rk44+jBuYMk30nWIcbCukNmEic5o= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VpYZc3B4YzxR3F; Tue, 28 May 2024 21:41:28 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 96D2B18006E; Tue, 28 May 2024 21:45:16 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 28 May 2024 21:45:15 +0800 From: Kefeng Wang To: , CC: Tony Luck , Miaohe Lin , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Jane Chu , Oscar Salvador , Kefeng Wang Subject: [PATCH v3 0/5] mm: migrate: support poison recover from migrate folio Date: Tue, 28 May 2024 21:45:08 +0800 Message-ID: <20240528134513.2283548-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 2DD8A140015 X-Stat-Signature: iid9a9619ara11ycqq9u8grd14kpf9w7 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716903919-338077 X-HE-Meta: U2FsdGVkX1/7H6IZXm+CayPYGCoMNaZxCHFDg7qmolC1e3zsNiQAs8cvpAnrc+idmdbZKAxQiZbvhOEH87G5aYbaDSmw2gaoth23zIFYOpy7dUuQYBbTIo1QwZ/HaKF6Ozx+ww1neCPDX/2s3vIbrYmVPZWxnO2ge8C/cE1Fg4pudmQ2PjSDW2NPTtqUwUdZdSUXlxeYSS4N9t8achKYig17qr4dR9SbySR8QLXVRwzrr9hPzvNaP94KasCAZcaRBFmJP7VZfUqbeH/w7j5yJ/gtHapyqM5+18zV0XT9ubUyNQ7Kr/dpY2vaN1Li30p9zroWHo2FUDHcODgY8u4Oy2TkVdqfepwzXuAl4J8aAINbURaHOdH9Q/gjW0nETc4h1PSDky8SK79yZk+BqgHSZsEfSKRD6jmNcEjR+4p4SMhnA2VcHKgDvcXHODdEffWB7H1Fd7qOxe5Rq1U8WOVhyVVOvGvIbufrpJ0tPiFOYYJBg5qbnDgOegrgCE9rw1rrrSiLkp4YFLbiFBrdY/ovNUh5MPGOE4KsLIC8cy6seKtQrCB8rxqN27ISmqNUSiLc/I/o7LMCSGzVvaWlunS0kbkKugShnQ9qmEELuHv8dWA3krTVjFA38AOlKEVfOFz39l+27l+9M5LWAoDV2hUpFOwE7GpKclcPs+EvCaMtWt+3R7uDjy1FoIhpgCVoN8yU1z04lXilJ3arMb8Y082yLMVRApR482qIUtQBexr7PJvFcUCwrVi3soBmgXnb+p2pgtv1v8kV+5pHkyPGwymFlcG1uykB+/SUx4Lzkp19ag53I/zEidJCS7xWEBIYcTzfHhyjpJm3cx/E0UGR00HGKrHJDz77NLAK6P3vnazt64HXZDidY9lFQFDqf83s4cGxX6MMVTyKbr6wfrrXmQebdRv9hYgvhtRKlCQm3+kVlN32L0Zzt2e3h3+EikkSfbcN7Ra7Jhyl1AGCeqZ3nSU iJ5SpHnJ Vt92PVNyGMPly16GUpWcaA7IRJcA/R2AbGb9zygz7K0Sqf4zPgiqVGsc0hmff+jx4XuAi5kzKXxEoYahx86rcGpiBbtP1FDVYpaGvXzSSY5EpKv4PL0ORnsAZI5Ilyp19c6FiK18fuQItq3T7YenvfUyBxwlIdsOOrJ+RtZmNjts4sjL4J2SjCrGQwo8rHC9Y3wET X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kernel will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC(eg, Machine Check Safe Memory Copy on x86), which is already used in NVDIMM or core-mm paths(eg, CoW, khugepaged, coredump, ksm copy), see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. This series of patches provide the recovery mechanism from folio copy for the widely used folio migration. Please note, because folio migration is no guarantee of success, so we could chose to make folio migration tolerant of memory failures, adding folio_mc_copy() which is a #MC versions of folio_copy(), once accessing a poisoned source folio, we could return error and make the folio migration fail, and this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 v3: - only folio migrate recover support part since the cleanup part has been merged to mm-unstable - don't introduce new folio_refs_check_and_freeze(), just move the check and freeze folio out, also update changelog 'mm: migrate: split folio_migrate_mapping()' - reorder patches and rebased on next-20240528 v2: - remove patch11 since fio don't support large folio - add RB - rebased on next-20240424 v1: - no change, resend and rebased on 6.9-rc1 rfcv2: - Separate __migrate_device_pages() cleanup from patch "remove migrate_folio_extra()", suggested by Matthew - Split folio_migrate_mapping(), move refcount check/freeze out of folio_migrate_mapping(), suggested by Matthew - add RB Kefeng Wang (5): mm: add folio_mc_copy() mm: migrate: split folio_migrate_mapping() mm: migrate: support poisoned recover from migrate folio fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() mm: migrate: remove folio_migrate_copy() fs/aio.c | 3 +- fs/hugetlbfs/inode.c | 2 +- include/linux/migrate.h | 1 - include/linux/mm.h | 1 + mm/migrate.c | 105 ++++++++++++++++++++++------------------ mm/util.c | 20 ++++++++ 6 files changed, 81 insertions(+), 51 deletions(-)