From patchwork Thu Jun 13 02:30:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0228DC27C53 for ; Thu, 13 Jun 2024 02:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69D366B0099; Wed, 12 Jun 2024 22:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64C756B009A; Wed, 12 Jun 2024 22:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 513F16B009B; Wed, 12 Jun 2024 22:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3344F6B0099 for ; Wed, 12 Jun 2024 22:31:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC6EF802C9 for ; Thu, 13 Jun 2024 02:31:05 +0000 (UTC) X-FDA: 82224288090.25.0F7D624 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf24.hostedemail.com (Postfix) with ESMTP id ECAAD18000A for ; Thu, 13 Jun 2024 02:31:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hpa4nKt1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245863; a=rsa-sha256; cv=none; b=Q9QuIqufh5kT98/ug1r5Fn+WAcYyeRNgkbJOKB6cbmh0G6hNreryNK3AgQ6qx+Igy5p1PV HwDusFQqT5RmikOe0Klj6c5+9s+qMMW1OoVgQUDf8W9aSDXpVqkZYu4A7dMcZdgh0r9972 Bryn9pOBawB251LrekWmh9JoPTtsHec= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hpa4nKt1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=3w4iDYMbDQ8VqQWdAkr+pXXK7YGM0mHCHQpTjjn+CA4=; b=6YQApsS3CLFGH3hTO8QeoRBXS91SIPtJZFF8Mm8KJzwUkdvYKGyDe5LGNI8Y73fw4Xhkex 1Fqzc9nBngDQx74bFAJ5haMTvjlIG9v0GNUZxHMAT7yULLWATyDCDqSRIUdiSLZ50VEvA4 3j2pyQOW/6t99EZR+EGM77WckdDHKC4= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f8507aac31so3949485ad.3 for ; Wed, 12 Jun 2024 19:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245863; x=1718850663; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3w4iDYMbDQ8VqQWdAkr+pXXK7YGM0mHCHQpTjjn+CA4=; b=Hpa4nKt11VdomZnr1tAM6UeQlgKUnhciSO7+Q180V2WWTkItCVhNIV+CUtHiwqIkep LMX8gWHNsI4nf4LkNk3ESJC3+0DFGhFEOWZ00QhumEMsNPqmpcqieIpbp9rFjm02QxsI xOi6YYJ5nzCzXAZDUyYFADlhL747i8X9Yn1KtERsoZsZbo3GQAulq2Y5fZvgxFCPJjrx eRiWpQRm/MTtmBApG19Uvf1Wqxkv8uzHGIC9EJcy5jvCg/XWhghAnDblFldEKzPOkOCW TGrIlJKvfmOgyxq7c/Wj+BhdmpM2XMfravwbouvC5dTeYCfbzW9SJiad6hBXy4tgL9xS ykwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245863; x=1718850663; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3w4iDYMbDQ8VqQWdAkr+pXXK7YGM0mHCHQpTjjn+CA4=; b=Tse3o0SmnxNljqmcuhJje7dHlT6CZG/vEcv9Fbh0uBgz3w0/W9fNe9bjIBCEm1Y27Z t/jvAqdzFUf24Je/WNMayezTRLBE3sorr5a7F+PuXZxG7MO0r8AZCHx1pj8v9dbPKXmW Vy+qPSUhHkIsmZQ5/WC7tDJlrmojz+2mNpdulRcalotlpV2w0m1i+/r2K0mnLI6A80My XfKLgOYMxZ/MPRLW2LZBJa8iz9WD4syWUoUiV1nHfZQnPLo0rsud2U6Z3nxxzESUiKQs iwgJ8ozeZ8VnNq3hDKh+GSfIG29SiwvecRUeTxteXayKdZOMh3k1sF79fWwVnIBon2sZ C5wA== X-Forwarded-Encrypted: i=1; AJvYcCUE8UihD7YXFO1swufXlRQG0oX9AMh3ovEoMG1mG93RuLugCxy6GN8xZ7j68rLWLEuiSg4N04krjXNU/QQRTQMKHxY= X-Gm-Message-State: AOJu0YyMuHfy1arSViyrTpZ8Y9uiEmtOhs/fmxp/eJeNUSwqyApPQtL7 HKJiEWoNyUHsmZ0yG44kWOAiKwWFOhGxDGwFSSR2PdX0b98NsyYx X-Google-Smtp-Source: AGHT+IFHNRfsiu51tV3Is/1VFg4pMq/OwH4IEvQ35DxqQ9O+7zGa5prTyMS/UUJ19qnEah41eexFNg== X-Received: by 2002:a17:902:c944:b0:1f6:ecf8:65e4 with SMTP id d9443c01a7336-1f83b5cf98fmr45292425ad.15.1718245862670; Wed, 12 Jun 2024 19:31:02 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.30.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:02 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao Subject: [PATCH v2 00/10] Improve the copy of task comm Date: Thu, 13 Jun 2024 10:30:34 +0800 Message-Id: <20240613023044.45873-1-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ECAAD18000A X-Stat-Signature: wrxwso1t78mjqzsdcebgrkw6jkszehmb X-Rspam-User: X-HE-Tag: 1718245863-213587 X-HE-Meta: U2FsdGVkX1+xPm2xxG+XvMrQwBN4xftRDHqWbJKiBW/fZ/ecaSaCrVhGsEeQsKBMROXbB0bA0vypYfyK8TthENCseyXV/3aQGRhv6gX0QSL42rzN3J2MeVVwd6h7SzXln4wSPR1MRnsyHL7BOZxRvc3jg5NUiodTR5nGjD9XyE8nXP/MyWNI4Reffeg2TPjQ/BJ2hNwrWzX4ckOlDR9vuxPabq/qexMsS6hcf79yDHImDqbtQjrepf+fcUYK9Av+heyI/BjEamHKEe7ad1X7D4rmrf4/KcrssQEmSsTyRDDVAB2MblVcFA1XMHkQNbw8WshxCn6Y1Xd4OU1Eo/+PPR0+FxkJ5OqQNB//NuaPp/THKWXlFf0uFUD4FC2xfR2SHimSQdS8eugHwEPIsQ0Zo+c3bU2YNzSc/SWN44uhBImwxkghGLs+z97inh1IE9hAzW3E/Xide8Y5HCLIAC5iJnqidP9qtPM0xs84eYdL9s+I8yUKAb2WfwXZb76vW44MZg7slqCqyRKC+FNzoPFqksE5OhxZFdUhnv0abv2cpXsSMUxNpf/g/qZ4wNfnr40r+a+WP6XJ5uT+3KVq0LdxcqGbcwe0ehaerQmbKzAqvGUFgxmDZUfRKcYSmO76FIdNFkCf8uvdPrmxceVF0BmnwdXIZnX0gypZTZRb6Qbfdv7xztBTVBKhRbArV3WqibZIw2qwVZEVXHeS4TBBnJK6hpf0nf+pwvakFno1i48x99ucrdbWtipG5fGP8P+/MkEMu3+1e6fGe4KxUjz/PUVjD1hjlBgP2tysBOrV93cnFuJ8bjfYTrMBgImS2bAPfLSCjLCvbOIoivRWa641kEaO2+XQJog22uOvSJrWKZYYkxTwA94/2byyQGZjekRspzB/b9JJBsIJDl2aHdxahR3B8MipLWp7hiuMSKVBEXp9IIrKDoS/ZlF5nc0CTy445xumzdBWscpeRvqhIOo/kia HQiTeKri TzAK4scvVHTffJRZoH1gZHXoT+ESwh/fHHLhwZQUXCXJAPr4EuWkHhGJDrwKx4wbRL2D2kN3hrGKAWFf7Jy1PbbJercJ9LynHpeXOqtoewIMOTxsr9ezp2f71dGNL6KJ4AVK3tXGx77mCze/qIPz3KaGSokie3eCpxDxVOLV/npOcj1WMpUjMSVG7hlEOUQAB4Dy0+9NwcIWNNBw3xihsYQ7IOddSWXrnrO6ixuHzkbCQLWpvyXp7rljlEcg9K3sh0j32+q7WSJHwnTBZ0u/nnngih+wxE8XcV3HGuyeC7T7RxcLiepv8AfStcbfpvsarJq9YtBaOCluJgI08y7pG7d8lVjHeecQR5S08J6tkP/5Ws6pQsyKbq/mf1GGKu7ZxVyFjfqc0HLvInbuQjSNlfWdb7YgoHHdAIfSLve9qC1ea9vl4+iiBiMqkuAzB4SNacCHUPXksTxEGWx2J5kYvCA53oqJYdZzkZPTX7sTVQJOdXigSzP6ifCBNneA0nfRlZcTzM4fjWQggP391xUetnZDlzp7TsFwWlIQNxrxF6JRf6l+WaCObanjWneyu8cPOjCMV0k+BrN19Jfw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the length of task comm. Changes in the task comm could result in a destination string that is overflow. Therefore, we should explicitly ensure the destination string is always NUL-terminated, regardless of the task comm. This approach will facilitate future extensions to the task comm. As suggested by Linus [0], we can identify all relevant code with the following git grep command: git grep 'memcpy.*->comm\>' git grep 'kstrdup.*->comm\>' git grep 'strncpy.*->comm\>' git grep 'strcpy.*->comm\>' PATCH #2~#4: memcpy PATCH #5: kstrdup PATCH #6~#8: strncpy PATCH #9~#10: strcpy Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=wjAmmHUg6vho1KjzQi2=psR30+CogFd4aXrThr2gsiS4g@mail.gmail.com/ [0] Changes: v1->v2: - Add comment for dropping task_lock() in __get_task_comm() (Alexei) - Drop changes in trace event (Steven) - Fix comment on task comm (Matus) v1: https://lore.kernel.org/all/20240602023754.25443-1-laoar.shao@gmail.com/ Yafang Shao (10): fs/exec: Drop task_lock() inside __get_task_comm() auditsc: Replace memcpy() with __get_task_comm() security: Replace memcpy() with __get_task_comm() bpftool: Ensure task comm is always NUL-terminated mm/util: Fix possible race condition in kstrdup() mm/kmemleak: Replace strncpy() with __get_task_comm() tsacct: Replace strncpy() with __get_task_comm() tracing: Replace strncpy() with __get_task_comm() net: Replace strcpy() with __get_task_comm() drm: Replace strcpy() with __get_task_comm() drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- fs/exec.c | 10 ++++++++-- include/linux/sched.h | 4 ++-- kernel/auditsc.c | 6 +++--- kernel/trace/trace.c | 2 +- kernel/trace/trace_events_hist.c | 2 +- kernel/tsacct.c | 2 +- mm/kmemleak.c | 8 +------- mm/util.c | 4 +++- net/ipv6/ndisc.c | 2 +- security/lsm_audit.c | 4 ++-- security/selinux/selinuxfs.c | 2 +- tools/bpf/bpftool/pids.c | 2 ++ 14 files changed, 28 insertions(+), 24 deletions(-)