From patchwork Wed Jun 19 15:43:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13704130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A37C27C53 for ; Wed, 19 Jun 2024 15:46:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CFBE6B02D0; Wed, 19 Jun 2024 11:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57FB26B02CE; Wed, 19 Jun 2024 11:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13B9A6B02CF; Wed, 19 Jun 2024 11:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E4AD76B02CE for ; Wed, 19 Jun 2024 11:45:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9697E41425 for ; Wed, 19 Jun 2024 15:45:57 +0000 (UTC) X-FDA: 82248063954.03.E4F7ED4 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id 4F8B9C001B for ; Wed, 19 Jun 2024 15:45:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=YMobYKzP; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718811949; a=rsa-sha256; cv=none; b=ypD2xyYphiDHThvLPqtsvJAEqg//p6KpDs0W4xfCgMC/zZUp3B++fQaIBoqvTyMB+ETiWl hmQOp4Zdf6GfRZeyswpn+Ngr0QDUtlZwZSkaDugmfbKjzrhSNCgMoz7H1129kBh9OP7O6+ 6WiJuivpghL0ZYkjG1Ffxu6dmTrph58= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=YMobYKzP; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718811949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=VJm6hHtzjQFz8J3NZNwSDelkZcJL0K6VTSMOnj1lXFA=; b=US7tBnQNYFYjteO5GP2mDZNMGl4b8Ud2yAPkfDbsB464YyVbXwBvfKoFfbNxiCAjacywR/ Z9xLSygPlnvGzZ7kUIOGzK/+ZLU7grpx5RM21rHM3vjOp4YiiueF1tk/CqElzJ9RfU3us/ TRwYLxI+68o+kpDAH/zrScFTzNdfmo0= Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JFPmSj005019; Wed, 19 Jun 2024 15:45:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:content-transfer-encoding :mime-version; s=pp1; bh=VJm6hHtzjQFz8J3NZNwSDelkZcJL0K6VTSMOnj1 lXFA=; b=YMobYKzP9yo9L3ZXIOmyknoKtUHXpTVNgYYk+ytmhgv4wnfZob05VsJ 9WvS1fbCLTWrPasHdifjZ528DPv4Skx3fgDkq41PJPWcAl2lprudq0bX7BukHkno 7IRFqzZiwsgkB+Llclp9QPEHZnLV95rl8AGo1tB0rBBTiiKmCegJGwV9/fpX0wl5 6sDJdWlLeCLhRelCU6VLwpj+WzQJmJLU8PnLpHE2o/QbkpOIV1sJm3IvPfQyVfyu Ojthqkq0jJVrpbItzH4ouUcI+5p/WCigA4ac3C5SDToD/aRsczi1WO8Hbklm09Kr yqKH5NYuaDnjXDjadimdmhZzuoW2NEQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yv1jfr5b3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:41 +0000 (GMT) Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45JFjeGk005715; Wed, 19 Jun 2024 15:45:40 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yv1jfr5ax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:40 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JF4DXR006227; Wed, 19 Jun 2024 15:45:39 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ysn9ux8km-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:39 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JFjX5J49086752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 15:45:36 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D17162004B; Wed, 19 Jun 2024 15:45:33 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7303720040; Wed, 19 Jun 2024 15:45:33 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 15:45:33 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v5 00/37] kmsan: Enable on s390 Date: Wed, 19 Jun 2024 17:43:35 +0200 Message-ID: <20240619154530.163232-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nseo2CrAOTqXwQL8a_EKoWmLo2KBtae_ X-Proofpoint-ORIG-GUID: 7JzeidV5Q06ua732x0AojvNF0TR0sYGs X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190115 X-Rspamd-Queue-Id: 4F8B9C001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xucwux6pde9ehzf983yxwe9qigb6wpk8 X-HE-Tag: 1718811955-589652 X-HE-Meta: U2FsdGVkX1/OZb/8sCPx8jOvEXYt40ebVjH2aHy6F6B0s1/M/Ojf7n8/0daGgZ+GKjt9GJyaYe0CNLQpIpd63K2ulVQXFan44HmNTmG+7cXoaiDn+eBCx9O0h9sLKdmqRMoSQI14xvJqNTCFxSj5gwq0eTVYDxOb0u8Qzj+0XeMG8SWNseaQM3L1vPamGVNYXbzJCKQBdBjOOJRJNC4kb/MhHgwyTyoyGSlJlcdZRaioA1loT+nRler7haibjslAOgDCgHWvCLT8GNqB18UWH37mQJ38BdWhyu/WAWmPN8QEuKzKFHUIQRSGWz9zxbHbh+5BCE8m0mE8sRhqmBn5vIwCfcLXpARq8vfgcaz+gfp9gu5WZdCegBun7nr18hx7AZaSoHXBHJI2xI5cVGwv4Sll+ljMvYSuo/swJ6chFzmg+1t+o/2D3n2w4lpWxbr9Wie9kyPljh6rD11llO0awXenG3Fg2oUT39eoAmoew0LOja6HUuVpLlVuRM3LqxJZzSXTlH2l6kDAf2l3eX2/aL2+kpIq1xptrjwAbwI0TOOdWXHYHERI28ZcWNA+C4tcEFrSUgA7QTqdmMS8wJiT+XclOCEezG7/c4JezBTb8bDdJhYK4Q7XqHthvBf3hkaJWEV20iuFWpku/TgoiHddGUtaUmpBHbIf95m9cNNxSlcQb4A6gAj+7yMsjbNLsZ1B+6KUIQfRLlWgV9zSB6jAIdrrkWravkdardl57WDcgdUyHIzFF8gNUDipH1K8Qqi8BKERkMcoBuQYBL7LOHsD8C2oyL3DZWhArT/NauLokbq5QWJuhHtnfoOQ3UYxr9SlGtmoxyFK0R998USlRANE3achmPGL0tbZHZKFw0MWpDIORIoZ29UEsB5nkAtfv3D4CspCJB2U4DsVlPKuR0Yd6H/hCBxZGAE72+VhXeBAb+guPv0JXWWhAGtjtXXz4Vt1XDuB138PjaBOWiSfJ76 TmbQDlcA Z473yPvg+e+GjzZWTc56sUJtqAxcetoMG8/OILIyjm4LqNTpdZo0FlvAkpcLeO3zdvo4bZuGy+7nx4uen0LLFeNGl6iFZlGb3qgO/hI2xHjyR0mOlL7BMyFEdHgHwTBvRsLUuYF4V7hxbMqZbA7t4ZZ2qxrIt8YzYoMuNiyBZd7Zr10LdthZYLh0zU39fnbB89/6IV55l/kbrzxgWRNFafur4vttRrs3lx91jfdnFxJmxBamE3NWF2S6EX+N/OBG0JMDhkr45g7jjiP3YPQf5O5poHelTextmH7QXvfEwMBJLxRF57pf8N3LXwvMCSWu6wz2dhJAqtr/O+PcdbGOMIXs6JJNNTHAk3p9sU8PmOstkrfxKC/6zPgNGLfBRe3QlMT9ED7tgOuWzUc9BFUOnY6gJy484gnE6fNoHPP8IINZ+6cDtMe4Lo6oJ6jZoOMuRugRHpGch11MUP0JndmqksYqR94AcBvbcF5Jepbpd0lVR55s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: v4: https://lore.kernel.org/lkml/20240613153924.961511-1-iii@linux.ibm.com/ v4 -> v5: Fix the __memset() build issue. Change the attribute #defines to lowercase in order to match the existing code style. Fix the kmsan_virt_addr_valid() implementation to avoid recursion in debug builds, like it's done on x86_64 - dropped R-bs, please take another look. Add kmsan_disable_current()/kmsan_enable_current() doc; Fix the poisoned memchr_inv() value in a different way; Add the missing linux/instrumented.h #include; (Alexander P.). Patches that need review: - [PATCH 12/37] kmsan: Introduce memset_no_sanitize_memory() - [PATCH 13/37] kmsan: Support SLAB_POISON - [PATCH 17/37] mm: slub: Disable KMSAN when checking the padding bytes - [PATCH 36/37] s390/kmsan: Implement the architecture-specific functions v3: https://lore.kernel.org/lkml/20231213233605.661251-1-iii@linux.ibm.com/ v3 -> v4: Rebase. Elaborate why ftrace_ops_list_func() change is needed on x64_64 (Steven). Add a comment to the DFLTCC patch (Alexander P.). Simplify diag224(); Improve __arch_local_irq_attributes style; Use IS_ENABLED(CONFIG_KMSAN) for vmalloc area (Heiko). Align vmalloc area on _SEGMENT_SIZE (Alexander G.). v2: https://lore.kernel.org/lkml/20231121220155.1217090-1-iii@linux.ibm.com/ v2 -> v3: Drop kmsan_memmove_metadata() and strlcpy() patches; Remove kmsan_get_metadata() stub; Move kmsan_enable_current() and kmsan_disable_current() to include/linux/kmsan.h, explain why a counter is needed; Drop the memset_no_sanitize_memory() patch; Use __memset() in the SLAB_POISON patch; Add kmsan-checks.h to the DFLTCC patch; Add recursion check to the arch_kmsan_get_meta_or_null() patch (Alexander P.). Fix inline + __no_kmsan_checks issues. New patch for s390/irqflags, that resolves a lockdep warning. New patch for s390/diag, that resolves a false positive when running on an LPAR. New patch for STCCTM, same as above. New patch for check_bytes_and_report() that resolves a false positive that occurs even on Intel. v1: https://lore.kernel.org/lkml/20231115203401.2495875-1-iii@linux.ibm.com/ v1 -> v2: Add comments, sort #includes, introduce memset_no_sanitize_memory() and use it to avoid unpoisoning of redzones, change vmalloc alignment to _REGION3_SIZE, add R-bs (Alexander P.). Fix building [PATCH 28/33] s390/string: Add KMSAN support with FORTIFY_SOURCE. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311170550.bSBo44ix-lkp@intel.com/ Hi, This series provides the minimal support for Kernel Memory Sanitizer on s390. Kernel Memory Sanitizer is clang-only instrumentation for finding accesses to uninitialized memory. The clang support for s390 has already been merged [1]. With this series, I can successfully boot s390 defconfig and debug_defconfig with kmsan.panic=1. The tool found one real s390-specific bug (fixed in master). Best regards, Ilya [1] https://reviews.llvm.org/D148596 Ilya Leoshkevich (37): ftrace: Unpoison ftrace_regs in ftrace_ops_list_func() kmsan: Make the tests compatible with kmsan.panic=1 kmsan: Disable KMSAN when DEFERRED_STRUCT_PAGE_INIT is enabled kmsan: Increase the maximum store size to 4096 kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces kmsan: Fix kmsan_copy_to_user() on arches with overlapping address spaces kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() kmsan: Remove an x86-specific #include from kmsan.h kmsan: Expose kmsan_get_metadata() kmsan: Export panic_on_kmsan kmsan: Allow disabling KMSAN checks for the current task kmsan: Introduce memset_no_sanitize_memory() kmsan: Support SLAB_POISON kmsan: Use ALIGN_DOWN() in kmsan_get_metadata() kmsan: Do not round up pg_data_t size mm: slub: Let KMSAN access metadata mm: slub: Disable KMSAN when checking the padding bytes mm: kfence: Disable KMSAN when checking the canary lib/zlib: Unpoison DFLTCC output buffers kmsan: Accept ranges starting with 0 on s390 s390/boot: Turn off KMSAN s390: Use a larger stack for KMSAN s390/boot: Add the KMSAN runtime stub s390/checksum: Add a KMSAN check s390/cpacf: Unpoison the results of cpacf_trng() s390/cpumf: Unpoison STCCTM output buffer s390/diag: Unpoison diag224() output buffer s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN s390/mm: Define KMSAN metadata for vmalloc and modules s390/string: Add KMSAN support s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs s390/uaccess: Add KMSAN support to put_user() and get_user() s390/uaccess: Add the missing linux/instrumented.h #include s390/unwind: Disable KMSAN checks s390/kmsan: Implement the architecture-specific functions kmsan: Enable on s390 Documentation/dev-tools/kmsan.rst | 11 ++- arch/s390/Kconfig | 1 + arch/s390/Makefile | 2 +- arch/s390/boot/Makefile | 3 + arch/s390/boot/kmsan.c | 6 ++ arch/s390/boot/startup.c | 7 ++ arch/s390/boot/string.c | 16 ++++ arch/s390/include/asm/checksum.h | 2 + arch/s390/include/asm/cpacf.h | 3 + arch/s390/include/asm/cpu_mf.h | 6 ++ arch/s390/include/asm/irqflags.h | 17 ++++- arch/s390/include/asm/kmsan.h | 59 +++++++++++++++ arch/s390/include/asm/pgtable.h | 8 ++ arch/s390/include/asm/string.h | 20 +++-- arch/s390/include/asm/thread_info.h | 2 +- arch/s390/include/asm/uaccess.h | 112 ++++++++++++++++++++-------- arch/s390/kernel/diag.c | 10 ++- arch/s390/kernel/ftrace.c | 2 + arch/s390/kernel/traps.c | 6 ++ arch/s390/kernel/unwind_bc.c | 4 + drivers/s390/char/sclp.c | 2 +- include/linux/kmsan.h | 46 ++++++++++++ include/linux/kmsan_types.h | 2 +- kernel/trace/ftrace.c | 1 + lib/zlib_dfltcc/dfltcc.h | 1 + lib/zlib_dfltcc/dfltcc_util.h | 28 +++++++ mm/Kconfig | 1 + mm/kfence/core.c | 11 ++- mm/kmsan/core.c | 1 - mm/kmsan/hooks.c | 23 ++++-- mm/kmsan/init.c | 7 +- mm/kmsan/instrumentation.c | 11 +-- mm/kmsan/kmsan.h | 9 +-- mm/kmsan/kmsan_test.c | 5 ++ mm/kmsan/report.c | 8 +- mm/kmsan/shadow.c | 9 +-- mm/slub.c | 33 ++++++-- tools/objtool/check.c | 2 + 38 files changed, 410 insertions(+), 87 deletions(-) create mode 100644 arch/s390/boot/kmsan.c create mode 100644 arch/s390/include/asm/kmsan.h Reviewed-by: Alexander Potapenko Reviewed-by: Alexander Potapenko