From patchwork Thu Jun 27 00:39:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 13713564 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA66C27C4F for ; Thu, 27 Jun 2024 00:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F68B6B0088; Wed, 26 Jun 2024 20:40:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6EB6B008A; Wed, 26 Jun 2024 20:40:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 795916B0092; Wed, 26 Jun 2024 20:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5A6D16B0088 for ; Wed, 26 Jun 2024 20:40:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D24DE818C6 for ; Thu, 27 Jun 2024 00:40:31 +0000 (UTC) X-FDA: 82274812662.14.204BBFA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 8834F18000C for ; Thu, 27 Jun 2024 00:40:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PbmngrlL; spf=pass (imf24.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719448813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=+QIhWkrUjl8A1WpLxux9DpQH/gPDsJkcYbA07a9kr98=; b=1QMjMW992bDNetAXDiKjU6Iv5OTvpFdVGARq4CAdSbfmhumSdUJIpkrnwKv0eEguknHKde +KdO/h3OAwTtT40FPRJfOSfGb3QBV2nUOkNEfRr3FItC3EkYV4s44LCcif4MjAApqI9Uft jujUO/4teCku7SB6FVXX+zDv1G4Q7zc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719448813; a=rsa-sha256; cv=none; b=3UxXUuYyjIPv/d0r7OTCQlTlBBgJ3DTUUjr2KWixrrF+ZXMBrS5U8tRdNjltIgxuL6a4BZ z9n0YG+qnZT7s2V3ERjzYgqPj4fuGVymy4VegQ//UjrMZV7r0yzwl6M7omYAez14f5zqbK dmtepjXNQjOmm0OzBJAHOf8UxcKZeis= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PbmngrlL; spf=pass (imf24.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719448827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+QIhWkrUjl8A1WpLxux9DpQH/gPDsJkcYbA07a9kr98=; b=PbmngrlLYXN+4kT8ziikIjTaEvvZOnnqpnPdcBA6sPralCxOSB6HMnfZTguNfE+os1SU2N VoAknJdUrS3WSHS5HOfW+y/xMuYp1Hi+6TFU7G/dEwEaAVzt99akhs1IB04Zlf5RhL+V2l H+F4qqpvqrE1Z228Y4ExrdI25o73sZY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-uJE4GfzaPu-UIWBx4SHGfQ-1; Wed, 26 Jun 2024 20:40:25 -0400 X-MC-Unique: uJE4GfzaPu-UIWBx4SHGfQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D55B19560A2; Thu, 27 Jun 2024 00:40:22 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.remote.csb (unknown [10.64.136.58]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 458851956087; Thu, 27 Jun 2024 00:40:14 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, willy@infradead.org, akpm@linux-foundation.org, ryan.roberts@arm.com, hughd@google.com, william.kucharski@oracle.com, djwong@kernel.org, torvalds@linux-foundation.org, ddutile@redhat.com, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: [PATCH v2 0/4] mm/filemap: Limit page cache size to that supported by xarray Date: Thu, 27 Jun 2024 10:39:48 +1000 Message-ID: <20240627003953.1262512-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8834F18000C X-Stat-Signature: 8o9zkhsg1bdy4msd73g45yxfha4hbwyo X-HE-Tag: 1719448828-929150 X-HE-Meta: U2FsdGVkX1/2PENQbhNXwTtLyRqic4ARI/k0UUWLCpz3MCk9LbzfhcQsTfZJFBo9mC098kalWFRcGAf3rbTfFZZLu8Q/1YjTeNlgQGFgHxMS/Wdj5DjRO0WxWwwp5oaWMJGg8TW+qVeaptB4fnZlC8oBZOQH2jUMu6gCMEoJk0SsIcAGUg+qiJoP/DIb5xohZ9SF0f3wEvhak1kw/woJgnqxx3i9iA+nEU583VdqKPH+pSgPs3Vve9riG9kWqdGbh05IAPjVoDlj8zBMigRWlCcv5Qp0jXV26RWL9MLYhGSuYsm+yaYu+Eo6qzJMFka2Ev9L6qFcDVNnJeb+Qa35oEtiG/3rqDtimfklFpjorRBoM9lsfnkP1owREHCoPOJprFzCz8Kevd3SAkil7tY0HsnMTL8u3sWVVhXVJulAzcht7qk0xre97RgkToIcu1CREaSR/9T8v8SEnZk4Rj/2O5ZVBD1bCHjokP1gapCTMZbCf7ReHAxuVOf2LxgrcUXMQop8rwGKc13jN52KU2USmC1h4170mVP3sD1YR809zm8yx3ONdyj6rJB0BpIVrZPHjBczczfjHAVt5ZqpYr+d4vYhY5TtsK+PfZN6Zp/bDNWSqJFaTJurfofHNaE0b9JVjJI/K+rGV89raBwIna0ZUTnSLU1GJc+Jd3W5Ft2kt38xXqdETfjMPlWevyRANeMbFQvEIUgMH4muIhb2E2e0yt+VfxdaeYyg2QO2dSRzWHhD1ceBt/ewEhjq1FimlACsdxeweVa0Du5GZuwZqIuTPNA+q2QSSZEENZuH94c7n+mCZO+6a7I1maOWw2Jw5JF9DqxZpIJuJME+aFK1TuOeuQgYfrhaeug6UHmXnDzZrNgPkp8gUY4Dg0UHnhDAPZ++/7efxkNoavTjuR8CgG+8+R45GjTuGbhLN2306NDgARSMtQrMElNHNkMl4lT0G57rtIgy8YsZh4/vM0l1KcK ssDxlAvC shDhH7JAv6rTr3bjK1p+lvkBhLkrzNKW5U1AhD55WuC9mPYlkB73kip2LU03/LODGXIYYi9oj7VwPKfJRORNtGlCS1KwfZMqNKIs2H74jpQ2QfpBjWe5VNpeEorrThRMNDMP+QUrspqHpc7kT8/gV7iVOQt0+Vn7LY4p9qvsiDaJIlp9sUnLivLg52P6tmpxgd75/x+MaXQL4dqXekHBs4jtl4j9n1iLTQDm7wb9dIRk71Fudeq0hkmntK9JrOmwnLytgqdw9vqGJiEveSec3llx30w0DLnAbldD8j5QXOsWXKIYW5itWsPqZJK8JDqhz4vRcB/7sH2mV09cz4xpf0g292tesCtGt/HorswZwPliwla6lGi+Cpo0X882lQ1a9IzUcPviBFZYZhALeSSn3jpT/UzlOT5q88yZg3xBlMR0tSop4E3hIt7RjpNQuxESIZTGsshJ88nwoNSrZl62CbsSdJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, xarray can't support arbitrary page cache size. More details can be found from the WARN_ON() statement in xas_split_alloc(). In our test whose code is attached below, we hit the WARN_ON() on ARM64 system where the base page size is 64KB and huge page size is 512MB. The issue was reported long time ago and some discussions on it can be found here [1]. [1] https://www.spinics.net/lists/linux-xfs/msg75404.html In order to fix the issue, we need to adjust MAX_PAGECACHE_ORDER to one supported by xarray and avoid PMD-sized page cache if needed. The code changes are suggested by David Hildenbrand. PATCH[1] adjusts MAX_PAGECACHE_ORDER to that supported by xarray PATCH[2-3] avoids PMD-sized page cache in the synchronous readahead path PATCH[4] avoids PMD-sized page cache for shmem files if needed Test program ============ # cat test.c #define _GNU_SOURCE #include #include #include #include #include #include #include #include #define TEST_XFS_FILENAME "/tmp/data" #define TEST_SHMEM_FILENAME "/dev/shm/data" #define TEST_MEM_SIZE 0x20000000 int main(int argc, char **argv) { const char *filename; int fd = 0; void *buf = (void *)-1, *p; int pgsize = getpagesize(); int ret; if (pgsize != 0x10000) { fprintf(stderr, "64KB base page size is required\n"); return -EPERM; } system("echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled"); system("rm -fr /tmp/data"); system("rm -fr /dev/shm/data"); system("echo 1 > /proc/sys/vm/drop_caches"); /* Open xfs or shmem file */ filename = TEST_XFS_FILENAME; if (argc > 1 && !strcmp(argv[1], "shmem")) filename = TEST_SHMEM_FILENAME; fd = open(filename, O_CREAT | O_RDWR | O_TRUNC); if (fd < 0) { fprintf(stderr, "Unable to open <%s>\n", filename); return -EIO; } /* Extend file size */ ret = ftruncate(fd, TEST_MEM_SIZE); if (ret) { fprintf(stderr, "Error %d to ftruncate()\n", ret); goto cleanup; } /* Create VMA */ buf = mmap(NULL, TEST_MEM_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); if (buf == (void *)-1) { fprintf(stderr, "Unable to mmap <%s>\n", filename); goto cleanup; } fprintf(stdout, "mapped buffer at 0x%p\n", buf); ret = madvise(buf, TEST_MEM_SIZE, MADV_HUGEPAGE); if (ret) { fprintf(stderr, "Unable to madvise(MADV_HUGEPAGE)\n"); goto cleanup; } /* Populate VMA */ ret = madvise(buf, TEST_MEM_SIZE, MADV_POPULATE_WRITE); if (ret) { fprintf(stderr, "Error %d to madvise(MADV_POPULATE_WRITE)\n", ret); goto cleanup; } /* Punch the file to enforce xarray split */ ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, TEST_MEM_SIZE - pgsize, pgsize); if (ret) fprintf(stderr, "Error %d to fallocate()\n", ret); cleanup: if (buf != (void *)-1) munmap(buf, TEST_MEM_SIZE); if (fd > 0) close(fd); return 0; } # gcc test.c -o test # cat /proc/1/smaps | grep KernelPageSize | head -n 1 KernelPageSize: 64 kB # ./test shmem : ------------[ cut here ]------------ WARNING: CPU: 17 PID: 5253 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set nf_tables rfkill nfnetlink vfat fat virtio_balloon \ drm fuse xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 \ virtio_net sha1_ce net_failover failover virtio_console virtio_blk \ dimlib virtio_mmio CPU: 17 PID: 5253 Comm: test Kdump: loaded Tainted: G W 6.10.0-rc5-gavin+ #12 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x720 sp : ffff80008a92f5b0 x29: ffff80008a92f5b0 x28: ffff80008a92f610 x27: ffff80008a92f728 x26: 0000000000000cc0 x25: 000000000000000d x24: ffff0000cf00c858 x23: ffff80008a92f610 x22: ffffffdfc0600000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0600000 x18: 0000000000000000 x17: 0000000000000000 x16: 0000018000000000 x15: 3374004000000000 x14: 0000e00000000000 x13: 0000000000002000 x12: 0000000000000020 x11: 3374000000000000 x10: 3374e1c0ffff6000 x9 : ffffb463a84c681c x8 : 0000000000000003 x7 : 0000000000000000 x6 : ffff00011c976ce0 x5 : ffffb463aa47e378 x4 : 0000000000000000 x3 : 0000000000000cc0 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x720 truncate_inode_partial_folio+0xdc/0x160 shmem_undo_range+0x2bc/0x6a8 shmem_fallocate+0x134/0x430 vfs_fallocate+0x124/0x2e8 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Changelog ========= v2: * Address David's comments and pick up ack tags from him * Swapped PATCH[v1 2/4] and PATCH[v1 3/4] and corrected fix tags based on comments from Andrew, David and Matthew Gavin Shan (4): mm/filemap: Make MAX_PAGECACHE_ORDER acceptable to xarray mm/readahead: Limit page cache size in page_cache_ra_order() mm/filemap: Skip to create PMD-sized page cache if needed mm/shmem: Disable PMD-sized page cache if needed include/linux/pagemap.h | 11 +++++++++-- mm/filemap.c | 2 +- mm/readahead.c | 8 ++++---- mm/shmem.c | 15 +++++++++++++-- 4 files changed, 27 insertions(+), 9 deletions(-)