From patchwork Fri Oct 18 01:17:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 13840951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC07D3C53E for ; Fri, 18 Oct 2024 01:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBFD56B0089; Thu, 17 Oct 2024 21:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C70386B008A; Thu, 17 Oct 2024 21:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9886B008C; Thu, 17 Oct 2024 21:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DBB06B0089 for ; Thu, 17 Oct 2024 21:18:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3437D14044F for ; Fri, 18 Oct 2024 01:18:37 +0000 (UTC) X-FDA: 82684963074.07.323EAD4 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65]) by imf25.hostedemail.com (Postfix) with ESMTP id 14A15A0015 for ; Fri, 18 Oct 2024 01:18:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="SakqC0/J"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.92.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729214180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=cM2DWGmbLBQ34MlomM+F4njIUYWmIq4vToJVdl06T94=; b=u1JxK3u92PpJPRw6Tk8aSnjHyZko9wxj42L4eYKKw4RXBzBqA8CYiVgfOiPPhyy/sLgkZ3 LwOzo2P6N9KUdbBz8xwOvEf0MNB7i0QsJtDCwSy1/jwVs/fsjAAjYnWibaQqVRLrfBbp22 e81YuZSBK6iomyiq6dZlRrJp37nAAKw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729214180; a=rsa-sha256; cv=pass; b=t+mbLLfMDH0wN+LEs0FpaCMRgM76CWISP2b5bq/HaIIGLuVuZAQOhQM9AgWQZ8iLif8DJQ 9ZFxbnQPxyXtaZJgq1vfNSkttvERywVvJCuL7x1+NxfwuY+I9VtAqK8zMt0gmm3rsnZZ9T OCprGaxdRVnOTpWD8aDeWih7wBuzx7Q= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="SakqC0/J"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.92.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YJFgtQPsrAvJwRcCNVW1JyRi4TrchrbH5qE33P469noUWRdVK80YP+D/qd/8roS4y2DshbmP0LekS6cyTNr1XwVGmI+RFzTSWWRDdXroHCiaGbeMcWDUuZHVzFCkybdO6SSIZXLbcbuR5JdLqTOXZkVZii6Mf2fIRQOnXxMiiaE9+JjJyRDyPtz/X4a174vZP4MO5UCmLkHmpS+IOF2/CplI3OZ1sKf4j8p0nyLpSZOUxP7S80sWm21HAynwRRe/jP1TbdEyFDsYGgJ7t8uADKcuAjwLTITaHRH/wj36Bz+8PqzEKNbM/5iCSwmyKNIHIJrZ9Cgic2DhEwvPpTjLUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cM2DWGmbLBQ34MlomM+F4njIUYWmIq4vToJVdl06T94=; b=r+uQbPYpyYUpc6bFPBECBy6xv/DmHZUIZlnWJEeOBtj49eVGAfZYEzIbo/TQNaHfZtajfVOGyUabQhRblDLxVXzdXxOEKOuQbiY66Ouj+L0QWuRJv4XmDqQe9AgVG2e343FBqLw9U+l7uRB3pHBcNwuSHuqX6dOqAAW/cYQx0P7BtCH1ZinUnCNptFf32EXemW3KZzvhPkGgLChdVaqRovi0HEGqMsHYejF5rtP5w4U5VthDZ2qEhFQctNuispnk5566GvL7Pj9ThdQ1xQeoxbw2IxcRZR7LwWLljQKUHrGoT0Ug80Xu+tY41G+XW5/F0Csy0/dGXGbRvwtHR4VTNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cM2DWGmbLBQ34MlomM+F4njIUYWmIq4vToJVdl06T94=; b=SakqC0/JvCV01tS7yZP/CgKsWhxhSnL/o3lGu1b8vP1oN+o8CJpzmzHxLvu2dx/k12UUxFVSve5MlOpGr0iHoOnNRyCJjPN2KWB79sNp8rDhKX31LCiFGCDJ3KEP+joNCsh0Vl3JuppeLONfXiTB2Z5UTrGbV3YJb9L0nVIGALEXnv2rl2liPy3b2rzddSzCDLeRMuYvv2LX1mXx0J9s9DrLYoiONtYbOiEAlv0N5ESpbD0duqSqsTX+F/wvZ//6DlNkxDf0z/F7viJKLnj6iOZhrHt7RW6RZAS1Nk3C2TWkogskPOr7cJk6BFc2yUMbTQ4W0Du/3ULk2QHxviYbZA== Received: from SJ0PR12MB5469.namprd12.prod.outlook.com (2603:10b6:a03:37f::16) by DM4PR12MB5913.namprd12.prod.outlook.com (2603:10b6:8:66::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.19; Fri, 18 Oct 2024 01:17:13 +0000 Received: from SJ0PR12MB5469.namprd12.prod.outlook.com ([fe80::ff21:d180:55f2:d0c0]) by SJ0PR12MB5469.namprd12.prod.outlook.com ([fe80::ff21:d180:55f2:d0c0%6]) with mapi id 15.20.8069.019; Fri, 18 Oct 2024 01:17:12 +0000 From: John Hubbard To: Andrew Morton Cc: LKML , linux-mm@kvack.org, John Hubbard , "Matthew Wilcox (Oracle)" , Alistair Popple , Arnd Bergmann , Christoph Hellwig , Daniel Vetter , Dave Airlie , David Hildenbrand , Dongwon Kim , Gerd Hoffmann , Hugh Dickins , Jason Gunthorpe , Junxiao Chang , Mike Kravetz , Minchan Kim , Oscar Salvador , Pasha Tatashin , Peter Xu , Shigeru Yoshida , Vivek Kasireddy Subject: [PATCH v2 0/2] mm/gup: stop leaking pinned pages in low memory conditions Date: Thu, 17 Oct 2024 18:17:09 -0700 Message-ID: <20241018011711.183642-1-jhubbard@nvidia.com> X-Mailer: git-send-email 2.47.0 X-NVConfidentiality: public X-ClientProxiedBy: SJ0PR03CA0126.namprd03.prod.outlook.com (2603:10b6:a03:33c::11) To SJ0PR12MB5469.namprd12.prod.outlook.com (2603:10b6:a03:37f::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR12MB5469:EE_|DM4PR12MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: 69fcc27e-8559-4b34-235d-08dcef129887 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: WW1683iB5YlSrSX1KrrkRPgRhG7oIJodU6a6QL75sxjR3Opbh6eCXX2ETUuBCJE+swJqjxFr/S4gLxhYN7hnVmqa/poT02V6IQJzN0l8KV+/VNWOCq70x/AGcnOgs4uuserlrja3K9EBhPAtrT51gp+pcyLnFAhukuVjmCFR9vLueVlGWHYXznWcTOD7jEYH0TO5nhBc9oiw4zJ6S0dajkAH2V6cP/wWKv+aksLpT3AqPyRafNdJQwHPP4hgbRMceHBU2mBTBWm7ycr4y03rw7bDiHTfCg/b1DpvP8K12xlYl7dbnHz4yEmZM8QuiihVLpxDqhcwuOlYiy7xBq1RrjgPlROQo9ALnd3vTITUYvdXMD3ft1qBphJAfdu7SzRNo8JyzNOVZjROHs/eEz7uuTWc6c43SUp6tUpTdS6hCBvt86RpvfYH6e79nnXbYs+H5pAndQkwN7NLASFCJ5JAkOisZlMXjYyGilPvkE4XsTnFm8r08adLe1jQ8Yh/Z4BH/SPzjn19IP53ur6+7m9e+VqgN2iOhdjKvZrhLRdh8gQPhYNFUXm14XN9aU/jwf0/aCHwV1Dj8KoM275kqEsiLaISSe8IZnbUyB2zbNfvVo+WlWQ9Hd3ma4HkksFp9KiifhsCMYNdvjfVvR+AOQU++f2ZHxr2OmVAhcMAuUZ6N5UaGB3wgwBVyTu6VPJeFW2K+FgjV4HNaxQd94/ucyblvr1a+yohWvm1y1EicCf5iXXXL8tFqak9H7PwZe+r6KttB82Yv4Rpr1HyKoYNo2IN8N+5IBViCn8FXCAfBADPr4KNY9NXwa8Q240FkoXmY85GnjJ7Dwxbvkbq5ktWR6D8Ugw3Ik2DcgT/8EiX5zI/alP1b+q9FF26KEV5CPW1zlWgRhB7zQNPxmOAu0RfN3yaQgml7W/PzTo6c2ZbeoyRMEZuYoLiVVWLx/na6NBkT2mzygG/P8ZZje4qrcXRREgZULgqQdDP6HTuCP0bu136x0znZ+963dDPT0C9Yd2yO0MMHH6h3ch03/0Xpl5iMlKWvAm2Wy70Lzok2LPuWJol00FYmHtScff4E7688dHiqNaCQzXpYLr8vaWxZSXPDtB1oowrG4Itur6dZ/YOuMmPdKCSRzNeMECandvFyXBY89sUvulFn3PRpKL/ds3QLRdNcpuU6bDxhxdNfvN2OIa62UZCYsRya6BOhUo/KIrfCrqoy5/scco9h7ZYD2z0oRr6ZHksBQA6ZKtq8s7han8xbC81BUtYISteMUWH4qBPEZ+sGTtbDQKw2q+fEr0vfP2ko7l4ovENH52HQZ/6WYD8/8aZKlaillvsiaEuZ7puhbEi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB5469.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IO4shCffa4xmcJ/nhV1tcBYoe37fzeRRzazuoGn6uc7nSre6esNB+eq01onNiTjD82w0QTJil3oaogFoZD/bIG61OfL5nMUGHcwm0i4muX75EM9Dk+AZIKUrSuN4AEokODVPahLaj4vucRoAt7F9hvHYzrzUn+JMGVPZVU4PVrJga7XTbNGGZPZhfxmePSqbFdBWXZWg3vgYxdoGcMW4pKmok1qgsv/bgcSj9g5HVsmcOBlTO3refDHnYG9UXdnMMXCG31ET41llB38nhEpg8I2WohYn3g5a/93Hdg5VnFV2wiHEPy2u6XK81BK7Ew+AxqILcao91M/980Yg+PFspVfg2tGL58TJibHJrWYt4zq91OZR7vRbtVn7iWw/2rqUgFcjUsVZTdXM90CZlrs1uZ+oQPY5JLuRTmJjcNF2EpjCzJ01qf42imh5hS7HMx9asvI74dFc9MbObCNN8diWvZ9NbYM/BxlDqA7Om6VuPE6KKQCAtUIEoL0A1cKE9olvQfzfJxmvssZD0yFBN8aEGBNpqoLWITQq1pWC/6o8axzaecKNcAJH/rAdMFpFf0LGbDuCH8jHikpI08xXl45YBQkY4rLfL72l8JYmGhZkDhjhoP5f2j3rI2UnEzEsdbFl+BuvAULeFCJabOK4xcMsQJE8ucBm0AUAc2baR0DPInqyRZ686j+igZ43kVuKNaGM1NTC60ZV9Ml7WV0ED87aei1m0ubkXorPzklcCXGKZEbti3c8TNDnBqn2WLCUhCrlY+rJZXvwjinMuuJcu5kTu8MTeyPgH5oFpqxp3XNLqik0bFzJ+LIwpOwpWEmvyW690/CJvQDt/DD5ldcUVRbwNr513xE3gSS0ByqtYExjdCuevDQSI+wrSlxJ/MM1nEJW4U5iYRhbPGKfP265amaUDxnBTey+KzEoKa3Y/PNRHp3uM9RjpJlOunkOo2ENVtMci3xKsOcewh854sjzjvNTpRFEzxIY1UzNv9JpDiMhxnO5AcuxR63vDzbfk0Gc0r5/y4ss+cb1K4EQCjsXrCRUFWpxJNBkmlhPV/XAudjFG8dUVIw7QjBBDtci3U6b1t5pQ/G3ZFp1sBTX/RYq9i141nbgjNcbi1IBziWsXEgxNPWOQT01eyt9II8gpQl0F0cugNQ2P8q1yLvySQyOywDM0r4e6GmEf4dtIhzLxQ1dMGQSlhW4j8gW9icPvqkv7ubhKwS0/NUtw/dytdYprHVxThhhdeXMhBYIZlJ7FllRCmJDWPZgndjd60v4uJd6Udcjp72Xm8AAKh3w+wQ3wqFUue30GC4xpsFKNupm+5h62IHJgks1uKnB5DvDJ8hoZ4tm9FqDMvbfa/RZyhDLjivl5Xv/6S1rodyFfzxCz3Fc6WsxKJgUmoobCcUMx5JCM5kTgzWwd+L3LZy5Crg1SuZgXMOLG7vvBd3ndUmuag5O/F5OifwQPfqfTbqC4goeHbNXt4TGv7Qi+p516znZ6I/Rl1HOiQRfmbfG90xME5p3m6s1jwGA554t6rwRqQnfdg0UQ8KIU0bL/j9KndyYVFfOw1ZDOonbntTseYR8IwXZyNVXIb4iZjS/8BI/8X8Dm5Yk X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69fcc27e-8559-4b34-235d-08dcef129887 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5469.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 01:17:12.8307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lLPxt2prw79+1YAlclghn/0NSLnZfeQdpXsNhsVT/BeWF1gopxTu9Omv3uyGXi+h/9C89r0Ms0v9FIsLL4+fiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5913 X-Stat-Signature: 9gdycmh84f9h8gmns7e53fm8hgk75shj X-Rspamd-Queue-Id: 14A15A0015 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729214318-600062 X-HE-Meta: U2FsdGVkX1/nJ3E3EkzlFlF0RhceTHl4xDaRWM6Oebuq0Aez4FmMQTTJlsjXnkAsbbOaT+Na0JyfzGgm2tHxs7H72RiFNcX8EGOryfcayOvfr4ajr9E+fTmJC9YBH8eZkp/DpfQye5n4O2o3s8y4VHOsKQJLGzznqmI4QoZgGt8zJUOFUwMxBevIPEvtDdKbp2lW6xMzj+HyJxHK7AG+UTHx0xCiaDxy7xmD5tZ1xb6OoesKAZR7dQer1zLTV+8AFEwDoRg0fmCw222rvHtCnFW4h57Phve2nRuNRdeMGSw0Zd64R2JKbhZ5ZMbZp0wVosMKJhYX9FPYlkApDZQQ56Amo2iACDhWrQh4OuqKqf3PUmSRhkWp0vNcrRPYTujXTpDH35DR7AIVXXmdZRpG5S4jRLaucuNG8Fym2ZicrUxuNNqACqqcKoRVPQO4JH2VviiKLX2sC2/unrf9j9bZ3/rcoofw5P24JRV6ms+SB9IucnyiDFu/R2G3DCuuy4j9ZqVZhkUJorN5OwM/lvL3vggfjeL21r/xZzA0Qt620f8I9xcGJG5NbTb6sti95tXwjMtTNSv1L+OSAhRVkmeAB72qkzrYO4GhmW2vl6gA2P5gfXChCyacCOehR227UuuK2ss+bB66+mPBH6KcinkkrurPDlU2eVhRraYPY8GhPQK9i3E16wxqJkW9CZTZwmx41cO2qs2fEi86bHxhBvf/BiqOsvPJ5vN1N/mCKkdRh8ez/hMZxKmPI9V0bNmVY6zV8m4QxmpixF7Zw59sWaWGlkjB4tymevGUErQDwZHEEESUjOnr1jELLIEib5zz5x63d0C/Nqm8OFBpzVJQ+vQ1feZpKIO4lFMZ/hGMvBGZDu7Vas8WnEBeA9d7GwAs9+1VYaLiZcWJ8WgO4wKTn1a6TVg4qY9JP+LLpb9RgbRKOP9rn51bzghsK2EHD2OpBvbBtDjQsghPLuN3FOcaKXd NiimopwS XpV6nwqR9SK66RZfesGLRmPQHNH58Yqv8VRRgSwbvV/aQmY83klORj0pJsvVwdSEQEm6S8+HomL9bGdT+ANtKvUnF4lPHiJR9XAEJc0HMoAAryJro40z6T3zc6EhWZll7QkHToEqa9GcYUToU9HF+rpYnsp164oc8Pl388+eSdpQv1Aa18QJO78eNCd6YvfIhLcWAYCLRXYQ9B5JuEZia39Iieznq5cHYQtOXlJ0ed7q3TNmybirrLFKX3767IwLcsaPyNCVGr9Dkl89612dhyipvy1AIapi4oCZeWiGZaLWTT3BOGTA2C4cKLe78jjbwfA+7kpCryUBRUrEHQue3mLdENnZY2eA+I1XSZ/WhoerwKsZonQ2VHArCqmEl/yjx2JbdMBpdFeWokQioiLj064cxmwWBY+uRoQ+9i79narVSJ3YMAqTx7NwhqMw7Oe2UCjK0UJ/abRihFSa0/TX7OZSTNpjGGlYIJmNymqEtbxCn6UZ+JlofiWB81j1oaVewwqXL6O7IPRxJPFUyttke4c3A5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Changes since v1 [1]: 1) Thanks to David Hildenbrand for this part: added a second patch to fix the same issue (incomplete error handling for the return value from check_and_migrate_movable_folios()), but this time in memfd_pin_folios(). Please note that I am not set up to test memfd things, so at this point all I can claim is that patch #2 doesn't prevent my test machine from booting. :) 2) Fixed a typo in the comment, in the first patch. 3) Added review and ack tags. [1] https://lore.kernel.org/20241016202242.456953-1-jhubbard@nvidia.com Cc: "Matthew Wilcox (Oracle)" Cc: Alistair Popple Cc: Arnd Bergmann Cc: Christoph Hellwig Cc: Daniel Vetter Cc: Dave Airlie Cc: David Hildenbrand Cc: Dongwon Kim Cc: Gerd Hoffmann Cc: Hugh Dickins Cc: Jason Gunthorpe Cc: Junxiao Chang Cc: Mike Kravetz Cc: Minchan Kim Cc: Oscar Salvador Cc: Pasha Tatashin Cc: Peter Xu Cc: Shigeru Yoshida Cc: Vivek Kasireddy John Hubbard (2): mm/gup: stop leaking pinned pages in low memory conditions mm/gup: memfd: stop leaking pinned pages in low memory conditions mm/gup.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) base-commit: 274995ffe748bbee39f1ca65c6a31a1800140b27