| Message ID | 20241018023943.13860-1-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | refine storing NULL | expand |
* Wei Yang <richard.weiyang@gmail.com> [241017 22:40]: > The original thread[1] thoughts it is a problem in mas_new_root(). But after > discussion, this should be an improvement on storing NULL. > > Patch 1/2 preparation for refine. > > Patch 3 remove redundant check in mas_new_root(). > > Patch 4 refine mas_store_root() to improve memory efficiency and remove > possible consecutive NULL slot. > > Patch 5 adds a test for storing NULL. This series fails to apply to akpm/mm-unstable today. What are you based off? > > [1]: https://lkml.kernel.org/r/20241015233909.23592-1-richard.weiyang@gmail.com > > v3: > patch 4 move the change into mas_store_root() > patch 5 move test into lib/test_maple_tree.c > > Wei Yang (5): > maple_tree: print empty for an empty tree on mt_dump() > maple_tree: the return value of mas_root_expand() is not used > maple_tree: not necessary to check index/last again > maple_tree: refine mas_store_root() on storing NULL > maple_tree: add a test checking storing null > > lib/maple_tree.c | 20 ++++++---- > lib/test_maple_tree.c | 90 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 103 insertions(+), 7 deletions(-) > > -- > 2.34.1 >
On Fri, Oct 18, 2024 at 02:03:55PM -0400, Liam R. Howlett wrote: >* Wei Yang <richard.weiyang@gmail.com> [241017 22:40]: >> The original thread[1] thoughts it is a problem in mas_new_root(). But after >> discussion, this should be an improvement on storing NULL. >> >> Patch 1/2 preparation for refine. >> >> Patch 3 remove redundant check in mas_new_root(). >> >> Patch 4 refine mas_store_root() to improve memory efficiency and remove >> possible consecutive NULL slot. >> >> Patch 5 adds a test for storing NULL. > >This series fails to apply to akpm/mm-unstable today. > >What are you based off? > I based on yesterday's master 4d939780b705 2024-10-17 Merge tag 'mm-hotfixes-stable-2024-10-17-16-08' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Do you prefer to based on latest akpm/mm-unstable in the following spin? >> >> [1]: https://lkml.kernel.org/r/20241015233909.23592-1-richard.weiyang@gmail.com >> >> v3: >> patch 4 move the change into mas_store_root() >> patch 5 move test into lib/test_maple_tree.c >> >> Wei Yang (5): >> maple_tree: print empty for an empty tree on mt_dump() >> maple_tree: the return value of mas_root_expand() is not used >> maple_tree: not necessary to check index/last again >> maple_tree: refine mas_store_root() on storing NULL >> maple_tree: add a test checking storing null >> >> lib/maple_tree.c | 20 ++++++---- >> lib/test_maple_tree.c | 90 +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 103 insertions(+), 7 deletions(-) >> >> -- >> 2.34.1 >>
The original thread[1] thoughts it is a problem in mas_new_root(). But after discussion, this should be an improvement on storing NULL. Patch 1/2 preparation for refine. Patch 3 remove redundant check in mas_new_root(). Patch 4 refine mas_store_root() to improve memory efficiency and remove possible consecutive NULL slot. Patch 5 adds a test for storing NULL. [1]: https://lkml.kernel.org/r/20241015233909.23592-1-richard.weiyang@gmail.com v3: patch 4 move the change into mas_store_root() patch 5 move test into lib/test_maple_tree.c Wei Yang (5): maple_tree: print empty for an empty tree on mt_dump() maple_tree: the return value of mas_root_expand() is not used maple_tree: not necessary to check index/last again maple_tree: refine mas_store_root() on storing NULL maple_tree: add a test checking storing null lib/maple_tree.c | 20 ++++++---- lib/test_maple_tree.c | 90 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+), 7 deletions(-)