[0/4] mm: fix checkpatch.pl warnings in memcg v1 code

Message

Keren Sun Nov. 4, 2024, 10:27 p.m. UTC

The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the
memcg1 code.

Keren Sun (4):
  mm: fix quoted strings spliting across lines
  mm: Fix minor formatting issues for mm control
  mm: Prefer 'unsigned int' to bare use of 'unsigned'
  mm: Replace simple_strtoul() with kstrtoul()

 mm/memcontrol-v1.c | 63 +++++++++++++++++-----------------------------
 1 file changed, 23 insertions(+), 40 deletions(-)

Comments

Matthew Wilcox Nov. 5, 2024, 12:31 a.m. UTC | #1

On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote:
> The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the
> memcg1 code.

Please do not do this.  Fixing checkpatch messages in existing code
is counterproductive.  Only run checkpatch on new code, and even then
take its suggestions with a grain of salt.

Roman Gushchin Nov. 5, 2024, 12:44 a.m. UTC | #2

On Tue, Nov 05, 2024 at 12:31:36AM +0000, Matthew Wilcox wrote:
> On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote:
> > The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the
> > memcg1 code.
> 
> Please do not do this.  Fixing checkpatch messages in existing code
> is counterproductive.  Only run checkpatch on new code, and even then
> take its suggestions with a grain of salt.

I do agree in general, but not in this case. These are nice cleanups
no matter what checkpatch.pl thinks of it :)

Thanks!