mbox series

[v2,0/2] mm/page_alloc: Some clarifications for migratetype fallback

Message ID 20250224-clarify-steal-v2-0-be24da656764@google.com (mailing list archive)
Headers show
Series mm/page_alloc: Some clarifications for migratetype fallback | expand

Message

Brendan Jackman Feb. 24, 2025, 12:37 p.m. UTC 
A couple of patches to try and make the code easier to follow.

As discussed on the v1 thread [0] there are additional cleanups that can
be done here, but Johannes is already working on those. These ones are
just fiddling with the code to make it more readable, with no
behavioural change.

Note there's also a proposal from Vlastimil[1] to rework the interface
which is renamed here to should_claim_block(), I have not adopted that
suggestion yet but I could still be persuaded to do so.

[0] https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com

[1] https://lore.kernel.org/all/764394d9-592c-4d68-8910-67362dd8810a@suse.cz/#t

Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
Changes in v2:
- Tweaked some naming
- Added clarifications of should_claim_block()
- Link to v1: https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com

---
Brendan Jackman (2):
      mm/page_alloc: Clarify terminology in migratetype fallback code
      mm/page_alloc: Clarify should_claim_block() commentary

 mm/compaction.c |  4 +--
 mm/internal.h   |  2 +-
 mm/page_alloc.c | 88 ++++++++++++++++++++++++++++++---------------------------
 3 files changed, 50 insertions(+), 44 deletions(-)
---
base-commit: 8df57ad4ed6209600ccd54db2357f75eb46408b6
change-id: 20250214-clarify-steal-f244880441c1

Best regards,