From patchwork Tue Feb 25 15:29:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13990121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC79C021B2 for ; Tue, 25 Feb 2025 15:29:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CBA280004; Tue, 25 Feb 2025 10:29:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FC86280003; Tue, 25 Feb 2025 10:29:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C463280004; Tue, 25 Feb 2025 10:29:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5085F280003 for ; Tue, 25 Feb 2025 10:29:59 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 084DD81927 for ; Tue, 25 Feb 2025 15:29:59 +0000 (UTC) X-FDA: 83158852518.07.DE24550 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf05.hostedemail.com (Postfix) with ESMTP id ECB58100013 for ; Tue, 25 Feb 2025 15:29:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ltZc9vUf; spf=pass (imf05.hostedemail.com: domain of 38-G9ZwgKCPIdUWegUhVaiiafY.Wigfchor-ggepUWe.ila@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=38-G9ZwgKCPIdUWegUhVaiiafY.Wigfchor-ggepUWe.ila@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740497397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=J8OYSBSiWmuORPMaPvvvkcx69CZNTKOmuoq2J/BinMQ=; b=eM+1KdG1q4XnauFBWpBAqIuP0K3paErmljQeg4bOcvC5UwJmwQvPR7ljLAmfJRSYvYrQK1 MGanwIL/TbHH1BMFm2JC4Gu3rsWqnD95yEVTS52Zckls+rjnr9dgekgYY6HPnpnOx7HUzJ qEINWRvH9S9yWiRAz4tVXvJMk/9s0ik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ltZc9vUf; spf=pass (imf05.hostedemail.com: domain of 38-G9ZwgKCPIdUWegUhVaiiafY.Wigfchor-ggepUWe.ila@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=38-G9ZwgKCPIdUWegUhVaiiafY.Wigfchor-ggepUWe.ila@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740497397; a=rsa-sha256; cv=none; b=yQr6/J73Du725BaaVh0tqb/InNcSvwwJusYeJGxMxAil6nHJWpnk7Svy/S9TcE/ELEtrAo W7R+QyTp3gwslNi31qdUmLxpxmt2d3YMKjqM/OiPoEbYj7i1RlxZuW2XlNfeX1B1oq0hIR Ybe+wTGmsa3EZnFIdN/tz6qF/o9RLEU= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43941ad86d4so29525855e9.2 for ; Tue, 25 Feb 2025 07:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740497395; x=1741102195; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=J8OYSBSiWmuORPMaPvvvkcx69CZNTKOmuoq2J/BinMQ=; b=ltZc9vUfrhKHkirDcSZ63i1Fhesqly28JmwF+w1MpuXOve9AzV+r9x0c0tIH6JnUe2 jtAXGH4IBFyprThKY7XTFtbEk7EuZ7aTmsZVB7eRoYjbLB73t5/wVBgC3HAfCHU1bYTQ M2D4bSZvbvqY4hdC+c+BxO1yMLHXO+VhOvYOv+HuzELEB/h81jYLX7uWsmCPOkO+gxa0 dO4j04lPO0nVW4U5zV6rKtQ49pxkw6WQKaKChO1l90YMwQcWuJC4jI6sgi5+XyHd5YZo kMu9eAH85d2E8vbAgaUA+F997K83d7dO23CCA1shE+b7iUuW4K1wJGrpl3dIuTDrcKcP O+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740497395; x=1741102195; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=J8OYSBSiWmuORPMaPvvvkcx69CZNTKOmuoq2J/BinMQ=; b=nmsBq0gnLxKKQdJu57Tjjg7ZHBpesgWmppYW1nDpdeg9bu799vWOIoXKl4PQCXPSEa FD5UiLG88tWc0sartGiLZNrlkhpO5O2mhMW7PxmzIiArKPTTYY5qvbZWQMlkVjBh+ktS kQUAQ2CDnBGWSvB2LhSOUqT3oxN5yFlJPUIZL5bgabr6p4ZTiuObIjzsAzVxVcwcX88K cv7reD0Dpwhz5OsUJ5lAc7I7djbQv13fmJkwQDQBCJjOrFTGf3RaLwsXFF3g28TomRlk LyLbYzRDakrVHaEz27+y5xxGCwKQkZ+pbroSHMyA9xoMHN2Tc/sVskebfmVC6OhC8oD7 6fEg== X-Forwarded-Encrypted: i=1; AJvYcCWmyDd4eUun1pLTQoQnF7AeBbWko/vdABG+bfAiXGoTcJVnox4Ktv51TK5APVt4WaIE2cKXVa1Mbg==@kvack.org X-Gm-Message-State: AOJu0YxLa2qti3XzooswxSAiaBAqu06NVBwNOzn38xhlqXTIV5LYVxPI rITiUsOuC8NH07GlroN/hNybcvt5PJuHJk8i8XwlLI0Sdq4QIZY2toRUFZicD9FX8U5WmDGuH3V AYh+p4VE/jw== X-Google-Smtp-Source: AGHT+IHaOjWXrfAn70S+bygs3HR7doHIL+V0Tpo6ZxQyuZusTOvcqMi9FI6lDjFvFVsyrT5UFP4/n/DOg4EzzQ== X-Received: from wmbfp16.prod.google.com ([2002:a05:600c:6990:b0:439:9379:38c7]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:350a:b0:439:8e3e:b0d6 with SMTP id 5b1f17b1804b1-439aeb2ab04mr138373815e9.13.1740497395390; Tue, 25 Feb 2025 07:29:55 -0800 (PST) Date: Tue, 25 Feb 2025 15:29:47 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAOvhvWcC/3WMSwrCMBQAryJZ+yR5pj9X3kNcpMlLG6iNJCVYS u9u2pUiLmdgZmGRgqPILoeFBUouOj9mOB8PTPdq7AicycyQY8FRSNCDCs7OECdSA1iUsq65lEI LlptnIOte++92z9y7OPkw7/skNvvvlAQIqBqjC2WsaKvm2nnfDXTS/sG2VcKPHH9yBA4toTSqL MqqlF/5uq5vgEPR8+oAAAA= X-Change-Id: 20250214-clarify-steal-f244880441c1 X-Mailer: b4 0.15-dev Message-ID: <20250225-clarify-steal-v3-0-f2550ead0139@google.com> Subject: [PATCH v3 0/2] mm/page_alloc: Some clarifications for migratetype fallback From: Brendan Jackman To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman , Yosry Ahmed X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ECB58100013 X-Stat-Signature: oztrqwt39fzbndswqyjyaou6qb94tu6w X-HE-Tag: 1740497396-283811 X-HE-Meta: U2FsdGVkX1/KUn3H2S2MzdqkoJbcG1XEj3VByktML8ukvZAmMYxMXBpnihciBXc8umz6iRoZGKom4f9s6Ox/r/pt/BXWJQBQ1PBVn2YJhO1i/0o5MQfQ1p2S27IM5C87/EgFbOayCuphsslvmqrWxP2nFwU5QcLGlVexB1UBWbNdxtCDsz0o4JYCG5d5PTuSGPn7GhP9eFevpb53jrKzoHPdptK2rjfTnp4oSbwAQhdF2BdqwaGrFAHsdyBqpTUvtj9hb/GHdeF2mx/kWeVUca5HoMLLOD3B4BE1L+pYCskeOkx7/USCJ5mX78O1KyhsHwBOqy3hBUd9HL8q4M+9OW2LbKuR0jE9k4dy/T74Nq+hTpxP/lN44LVp4u0uDWco6vEbOvzuKi9XHF92AGB6ftHZg78EgDUxlcymLYXtXNXCKwiidn2CpKhuTIhe9SOKlfe7ZIUdMzRtdM4PwQKmTViWFrt3f83yP3BD8vO0mCmEca5/B1liSRUHMxnVlU4p/q6kCcDBzp/g8EkwCLK+HTf9PcTUoLICmv0FATBjLzXMpLEpWJMXtHvPePWjHsJomXBAMF2FkeGih6YP66JNe5t3BC/ID/iJ4Jh69jg7DKzoN2gAMSV8gjn327UtqdN54bWRNNmjtjIS0BWZsvFGSjHopKKS5ouhsH++srNJLdAlPtrUzrnowJS8GqBz+HbESmTQqDeCiWx20crLcS60g59ALqvyJMA9ytOjUHF7pRLL5kAvyHAOPg7xCb3T2YhWWxtHvkOv2/8Xgzs3OdgqIlS5mYTz8PbvChNS77d3F+g+yzRVl+st8EWsk1VBJ+cJL4W1dX154bqazPkMinwaykJT/ZZ8ABEPOEzxC6uqSbXZVdUNDVc6MMYNxhch4oja1FDrqCCdOX5dhb54q5H2dsXvsNz7mHe7uoT7UXuB+7M8cUa2+j1dqu51vv/VNjQU5YpKlWYBxoqxlXV9XiC kp7bT/1/ A4qdRua6KJUsYhIG6MQnq27RtvgLY2nM9G42a8izbt2YMuJaftA9wEGN4swj0TrI8mU6gjOv61N4CyNz3x7ZxvbnKfSk0x1nVqcARUjF1neN/FkawUHO2WWN3S0j9/oB21rnt/saka5Cmy/cKjZtDP7XN8KWsiSllvqEaVd8T4FOnbT3Mfk6SA9NtUXsVnHBL9xBtArzCnR/MMQSkWETowMy0Diqs4xQ0teNf5mUMOXHH03TuJe0cYHGrfknceu/Q9pxaoGhPwgUlgpmGWDgC9YrU+fgiP+x+ebGBTotc0x43/GOaosIZu9kR8OB2h4hlg42RkEjFXU1PUw6qsD2y9F4pNVMNuWINZr3xehPWxpIUuFU375A4X3LlDtCfv50Zj6Vzftx6r3zSICiic9k5vsySIZM8jsQLy3IEwELcbLyyZqUa5t3MazpTEIfP5Qg78b9wIth+0R5op8HAmlBDycMCys+HlX6JYfDqI3UEQbFKgLr41exb5RrTuvirViL+rekI2klI92RWE+4svKiNtfB0GJdF7djP+h0qJVx+C83jOYJZ3KYse86UIJXy/vj6YpWEVx1d7zOZZ/xRnO2cjSZaOH3Rk/aRqwm3PxhiES3KYvLokOYXY7F61k1arFg+Ogid+joQ3InIc8riZtm3pie5k5GG9oHr1MYklH+mrZDp6bgSeGCbn7ueNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A couple of patches to try and make the code easier to follow. Signed-off-by: Brendan Jackman --- Changes in v3: - Rebased onto mm-unstable to get on top of Johannes' cleanups: https://lore.kernel.org/linux-mm/20250225001023.1494422-1-hannes@cmpxchg.org/ - Fixed missing renames - Link to v2: https://lore.kernel.org/r/20250224-clarify-steal-v2-0-be24da656764@google.com Changes in v2: - Tweaked some naming - Added clarifications of should_claim_block() - Link to v1: https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com --- Brendan Jackman (2): mm/page_alloc: Clarify terminology in migratetype fallback code mm/page_alloc: Clarify should_claim_block() commentary mm/compaction.c | 4 +-- mm/internal.h | 2 +- mm/page_alloc.c | 95 +++++++++++++++++++++++++++++++-------------------------- 3 files changed, 54 insertions(+), 47 deletions(-) --- base-commit: 801d47bd96ce22acd43809bc09e004679f707c39 change-id: 20250214-clarify-steal-f244880441c1 Best regards,