From patchwork Fri Feb 28 09:52:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 617BAC282C5 for ; Fri, 28 Feb 2025 09:52:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D617E6B0088; Fri, 28 Feb 2025 04:52:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEAB86B008A; Fri, 28 Feb 2025 04:52:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8BDE6B008C; Fri, 28 Feb 2025 04:52:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 95ECD6B0088 for ; Fri, 28 Feb 2025 04:52:24 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 20F5D14068F for ; Fri, 28 Feb 2025 09:52:24 +0000 (UTC) X-FDA: 83168888208.19.59F0619 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf04.hostedemail.com (Postfix) with ESMTP id 4F53540007 for ; Fri, 28 Feb 2025 09:52:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MEENoeYv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3VIfBZwgKCK0WNPXZNaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3VIfBZwgKCK0WNPXZNaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740736342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=d5mt9J8i4m5w2763+5K6yjHQ01GU+xDy5TZM3dXejFg=; b=K+DVetHhswum7Rc9caTVWoALwMNGkoNU30wRVpVah7Jx0jYnkIbeU/Ky899sRyCZWI/18S y1u9ntbMe1Dag13tUbPLv/nUHTFbYEIKfJENea4TAiJg7+MMpVZCQUvvD8bSbDEH3mxSU4 k5J9zYFT/P20+ugZ4SLTHhykgBKtOSg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MEENoeYv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3VIfBZwgKCK0WNPXZNaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3VIfBZwgKCK0WNPXZNaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740736342; a=rsa-sha256; cv=none; b=l81Vs0VJrqZi5K3NUu57OBCNrFN18xkBz/NtWXWBdVPr4fLaYVanlwc10CXRQ8xazGOVQi 2Ek0pEOO9aJaRdw1bCC9T01jT8X4Kgz0uKi4yVRcEmFz9iCwmdQ5drzG8ODy3g4CFw1eYx RasDNuBdJTu1M/TUQ7fJ8BVOSIxqyEg= Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-38f4cce15c8so912454f8f.2 for ; Fri, 28 Feb 2025 01:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740736340; x=1741341140; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=d5mt9J8i4m5w2763+5K6yjHQ01GU+xDy5TZM3dXejFg=; b=MEENoeYv4ZKj/jJZYXwkM8mqMkLlwcHjC1Er8Mfr88LrOgI2XikKmsLnD3xMp+jdag vR/rktx5mzLLX4yS/3smJLbGzrFrVrtcB2yMfCBa4BwPn8vG/NlLR40Im6lD1xVm0qKY 7cUTHbYLw8AgMzUo77BJmebZ/pywkMraZtA1D0mV2CuQUXxKtSEE85QfclmD9m/lIspM c6AWNCtzIRV/4aYNgKE7prTi+o23CIM+00vp1FWxMxXSDxthB3y2kl/iApz9+R2qYHs3 5HGdzi4ubxNn9EZMCunDOepVCyp9HPdtTiSQ2tfuqqYqzwoasi1V4Et4Yf9vm9kWPEhn Xdgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740736340; x=1741341140; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d5mt9J8i4m5w2763+5K6yjHQ01GU+xDy5TZM3dXejFg=; b=lSlcBPD4RFp4uLcwrvUCl1yspbzZL8y8BthITIAeht/NkeUuQIuG4So2fp/V8lwS/D YzMhU5yZS92D2yFL5kxgBBFyIu+Rey6NHG+GmXqIW2yZq6UShvwnEuvaxetv3mcxLufL kZV++4zjW+XBW/3tNsqQGQ83LVWKm7qwbSsvIk6yXG1QrqGzqEU/HMz8qYOfGM4LeJsy 8U1MuE5/+Gyhv/Xx3RouKFxtV+iu5lW2tPirO3lE0LTA2iM3buF97Ko/t8bOHDEqnrkq nu8iangqSsMt3JoM8vucuYGaYLH1FSzd9L207n+szt0reTlH+yiZsqrmX4cKDWvaAEPL x7xQ== X-Forwarded-Encrypted: i=1; AJvYcCXgjfRtWk3L/VnS7WEg2JEqjteDe4aA3a4IDtPe/3TdbOIazcjzk44jBxw34qCI22AsX1SdjQu3bA==@kvack.org X-Gm-Message-State: AOJu0YxvQdEIS0/CPRaLWk7U2RxInf0GVyyzXj9Mf/aHilnt3vXYLqgr mfr1Z4zPJ8U4s6B7v2n2GXjajgZN/e9m4Cq85l+SOTgVps902ngjPfi6MdWjCBv0t27eVPog0/x NHqwFeBsm3A== X-Google-Smtp-Source: AGHT+IFhvyhBMDqiCFk0cQyiG9hDs00X+P9w8OzFkmfuBdj2kS5HdpmNO0Wf1SLwxTzA3xHz763DJVjmvMCnwQ== X-Received: from wrfu11.prod.google.com ([2002:a05:6000:38b:b0:390:e2a5:14b1]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:1447:b0:38f:6697:af9c with SMTP id ffacd0b85a97d-390ec7cac67mr2126793f8f.6.1740736340671; Fri, 28 Feb 2025 01:52:20 -0800 (PST) Date: Fri, 28 Feb 2025 09:52:16 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFGHwWcC/3XNTQ6DIBCG4as0rEsDI/jTVe/RdIEwKImVBoypM d696MrWdPlN8rwzk4jBYSTX00wCji4636chzieiW9U3SJ1JmwADyYALqjsVnJ1oHFB11IIQZcm E4JqTZF4BrXtvvfsj7dbFwYdpy498vf4rjZxyWlRGS2Usr4vq1njfdHjR/knW1Ag7DgcOlNEaQ RiVy7zIxYFney5/eZa4BSkZKsN49v19WZYPIe5XAykBAAA= X-Change-Id: 20250214-clarify-steal-f244880441c1 X-Mailer: b4 0.15-dev Message-ID: <20250228-clarify-steal-v4-0-cb2ef1a4e610@google.com> Subject: [PATCH v4 0/2] mm/page_alloc: Some clarifications for migratetype fallback From: Brendan Jackman To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman , Yosry Ahmed X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4F53540007 X-Rspam-User: X-Stat-Signature: 3d63dmq5tduqg8i9ixxp78xwwso3pb97 X-HE-Tag: 1740736342-544425 X-HE-Meta: U2FsdGVkX1+W5ZYyLa3hNF6RopxtKuV6xuWZuD9frkt0MnOCVAFzKJ+XIyCobH+gJxyzkyUdQUreCiGzTwAERQVZKHlkwUD6VbiUGWubvEhzLlfX2DOuuKnhmfed6QDJjDn+lW2o60U2pLsxZDaJEvxENXQwVhgqXSFKTGrBPH4l4lNv90gaWWOLbwhEOveyaHmzmhF4IMsIUk/4Z0nQ5mfARYnMhrACRex79nkexVL1H4cmgbUaggYeh5zz1Ciix6TQGaO/Nj5e/zbSJPXhucmxzoVzQFk4yEHIkE3S51WuTRNcda1/qNWJCjpCjqjTgS8aCKIGdzv+4ImQC6pwxYp0ekIkDbsq8Sy0ekBJ9rjfu8D1JGBk1aFQGlnP5qyVtXjXEI+AhDcon/U8VWtSlYRbqzWBupqBZa/q+mt1ycN2Yx+UrCYjLRjQKlMb+9fjAsA8Omft7c3KldbsebYi3qYlJngFEHkG720SunzaC4rzZohIPsk6Mh5CA9cqsbG6PVJNwlrbmZ5rMVLJkCi2PXe2EX4m4Oa3mtgVdp7CmdxQhCNN8mAtY8zpLxaCKHnMOs6DlZGyHYVT74wj/fnydJ6byDTPdRxb3SZ5JuzLS0kQfpbIAl7o3lUitwov9gsxseEeRSkBM5poAPMnIOWs0tSeVhcjQzS6bPPo/d5HseMlrukQ8WwpCNmnIE7CWiunf5FJLPEHihc9lTp7FZF8Lr4OSUSab5IonfCRpltJR+fuRMkHyI67ZsHPiJdeszsMy22H8rIdqE/9gvu3sbsiBi9pXJ2N35Fg9jBIOwHvCdJNOwC7uhtHamACfunpHhQPlexYh7qtoDYuiQfpVXobGCWbuonh5qD01RgbGWWNOcNeBT5O4YHJ2QSGZp4GA4EZxF2Itr33+21xIPIR1wNZP0Z58LaWWqNutWSR+lIwCx4bpaFgKbocB88uFs+FPK7S4ooDqGl3CkuDwltDWpO d/L/AQ+6 oQDfNNknj2TVotblS6iOnoCjm/561zmZvzbCfyRCH+gVqi/zyDKJdsXRR+xTwE+N51vbhOQLQbJXAWziYHQT/dpa/vgFXvfz9jithExYKfhIhLQaX5e8DdbgFWpW0S1T4NlFJkEkbAfzC+LQGOUD27/aD/rsVLyQlZgUa7hAcplO9PlCSKZV/HwZQU4NX6+cTaC2y1pATYI4LoxRLw9SqMNV0gtbi1TNhcsLCWRz6n3Jyj0PHtnpyyFxgthTH6t818nOMq47ZOzZTaHxZsMiuNy+Kh9yOXFt4mvJOyJxiFmf0UzFN58kDifYK7OOR7dISLOaYjMUuC1yv2yBnJ/DgxN8oQdEfS+wFuI0WxgNFhtg7jExh+GM8uBeKsx/coE4hFBA/ouHT7sKkWLWgo5sV8zTxlG8kGxbICoObuqBD1njYQ1xm4QwiGROg+uyKzGOH4BaEymEW1KkCFoCYuMLDXqJnwPQ8lorUJUM9fVgMJKlAMw5J6bA9MsRIJc5I9R5/U5axmnVMkbhPc+LmoEeLoGovOqPTd2e1MJvwzEeM0rz2X7YMWQ51lmOQERynHGWgt4BEFeBvpXBD01xlyT4R0SMPjwsh4CLQJaKTD4g8CatzCGBG4RYAQGGAGqMnwgIFEyEPtPAs+p1Ok25zgspltdOnu2jNso6/M/oWz7A5C8PmXlJqC5NCwJBYBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A couple of patches to try and make the code easier to follow. This is based on an old mm-unstable as v3 is already merged there. Base commit info is attached below. Signed-off-by: Brendan Jackman --- Changes in v4: - Some more precision about "try to claim" vs "claim" - More improvements to the commentary text. - Link to v3: https://lore.kernel.org/r/20250225-clarify-steal-v3-0-f2550ead0139@google.com Changes in v3: - Rebased onto mm-unstable to get on top of Johannes' cleanups: https://lore.kernel.org/linux-mm/20250225001023.1494422-1-hannes@cmpxchg.org/ - Fixed missing renames - Link to v2: https://lore.kernel.org/r/20250224-clarify-steal-v2-0-be24da656764@google.com Changes in v2: - Tweaked some naming - Added clarifications of should_claim_block() - Link to v1: https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com --- Brendan Jackman (2): mm/page_alloc: Clarify terminology in migratetype fallback code mm/page_alloc: Clarify should_claim_block() commentary mm/compaction.c | 4 +-- mm/internal.h | 2 +- mm/page_alloc.c | 100 ++++++++++++++++++++++++++++++-------------------------- 3 files changed, 56 insertions(+), 50 deletions(-) --- base-commit: 801d47bd96ce22acd43809bc09e004679f707c39 change-id: 20250214-clarify-steal-f244880441c1 Best regards,