From patchwork Fri Feb 28 16:54:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EFAC282D0 for ; Fri, 28 Feb 2025 16:55:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBC2A6B0082; Fri, 28 Feb 2025 11:54:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6BFC6B0083; Fri, 28 Feb 2025 11:54:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A34756B0085; Fri, 28 Feb 2025 11:54:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 882AA6B0082 for ; Fri, 28 Feb 2025 11:54:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3723F80F00 for ; Fri, 28 Feb 2025 16:54:59 +0000 (UTC) X-FDA: 83169953118.06.F9F131D Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf01.hostedemail.com (Postfix) with ESMTP id 1AF6940016 for ; Fri, 28 Feb 2025 16:54:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rCJsDLm4; spf=pass (imf01.hostedemail.com: domain of 3X-rBZwgKCIAnegoqerfksskpi.gsqpmry1-qqozego.svk@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3X-rBZwgKCIAnegoqerfksskpi.gsqpmry1-qqozego.svk@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=N60kH1GUzJjh3qweY5Wozn6tvXiwFNn/mmR1dP9CBxU=; b=JbCxiUqFszY2WqmzVW4M8b9OkZqfODAZMvBBY2Y91GqShd81BQnCKaOQKHOU3LUmkrdDLT oNefrMUxy21pBrolJTygRNG++XsMKolrc7g0ChmpdpmTgNxZQtnxtZHAtR9RSWA+hrrOq5 5LpMNiALlXgwTZTZFOa9AjVKKmIeX8M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rCJsDLm4; spf=pass (imf01.hostedemail.com: domain of 3X-rBZwgKCIAnegoqerfksskpi.gsqpmry1-qqozego.svk@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3X-rBZwgKCIAnegoqerfksskpi.gsqpmry1-qqozego.svk@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761697; a=rsa-sha256; cv=none; b=PZDhpjYoDgA2cL5w9QnvRFwjKR6Cn7VTyuKdWWwV0K7yoXdnXF90I7zARvKXiktD8Qg8VN BrdMgs0iIXI6veYgk98xVd3OMPHwmEtxA1sshJDIQ+iCird/rG2Umy0jlLNMnAxBQmuBAm km5p4/NubnW8lPbXlDQWkNwkKAo9FWk= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ab5baf62cso17119685e9.0 for ; Fri, 28 Feb 2025 08:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761695; x=1741366495; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=N60kH1GUzJjh3qweY5Wozn6tvXiwFNn/mmR1dP9CBxU=; b=rCJsDLm4owEXI6KWZmanLpiYdPqCEbw6+NjE8GTx6UJu4C0YxklgrEai+xYI0era8n p77miuOVZUMk+4gb+1Bmcd0/UpRQ//QsnhQXFGm1nGtOh5659qgCr86jaF3aI3IZqOjW LVPyDEkSW9LrCcA6TQxucp49CbfRdluMZ7mYfQP7frOuJ4klIB0gTGwBjmXo2fdkeVWp WBknAJXrb+6pYv+Gt07vm5+dB1mv38D9SM1Nh7aW7aMW3VJxWnB0x6HvjmCQpyGNuYEt H9I/LWXUsdoBBhTmjb/zzrHuh+XnyvJlYyeM4sNL/H8OuxwFm0gYTQUGbOS3LwPD2BSF NMsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761695; x=1741366495; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N60kH1GUzJjh3qweY5Wozn6tvXiwFNn/mmR1dP9CBxU=; b=QxKsnDpN6w+xX5VLjp3yCxqJak+W3GyWQbANsOt8smF01wrt6w+nymp9TqQyrH1Uoe gxb9+bxqUz3cfGQGMwfNOiesMamMwlWGR9WstdEQFLNWT9nIkoOf1PwZxMXUudZAe9tE RfyvkpJ6OhfhENT3O4ASMPvqIVzmdSBGMYsRAfm3EpOpOVIJWYifCQXCoIMxH33Q7DWD oqAeH0hnSvIOXg8+u0fsDMmqJ2NQBhf1hb6MRzAPoU7goNZK4FEExNtuIouulih4Pkz7 VQ/fyVt2RndspPoyVhEK7fmrXeDHfJU6ZEmJeFrWuJCStKddxsobvLRIqlWaK243R8Cb LdPg== X-Forwarded-Encrypted: i=1; AJvYcCU2TvpZKnCJkuPnjSI2F2Tyqd7QqKKp1hloJOBCZroOG7q+qLFnLHG407d/Hix2gTlkvpLPhWTKPA==@kvack.org X-Gm-Message-State: AOJu0YyuISkOrpDiCKjaKLOMadn4xOEOScDCAF1KGPZuPWpKqH9/17dQ GVZdQ7Fk3ms2/Sm0UFef3BQjJlmuZ3oafRbqIr0yQLDJckkcSPNKgcjj00mqZ+YkFcVmIMG5GNa KiPuYJlLwGg== X-Google-Smtp-Source: AGHT+IE8RFBDoXnybZcLhnR95WmNyhuhSBpy8g+82jmGo3gir1AQ+P7E3C3dzckGzTkA372AoyCvaXEdGAGchg== X-Received: from wrbfu11.prod.google.com ([2002:a05:6000:25eb:b0:390:d964:d327]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:64cf:0:b0:390:e63d:30d9 with SMTP id ffacd0b85a97d-390eca5b159mr3212116f8f.36.1740761695598; Fri, 28 Feb 2025 08:54:55 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:48 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFjqwWcC/3XMSwqDMBSF4a1Ixk2JNw9tR91H6UCTGw2okURCi 7j3RkdtocNz4PtXEjE4jORarCRgctH5KQ9+Kojum6lD6kzeBBhIBsDoONKIg10wLpGCqQyTAmy jkWQyB7TueeTuj7x7FxcfXkc9lfv7J5RKyuilba2sjBJC8VvnfTfgWfuR7KUEn7r80ZA11FoYp XjNtfzS27a9AVrPEZXnAAAA X-Change-Id: 20250220-mm-selftests-2d7d0542face X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Subject: [PATCH v3 00/10] selftests/mm: Some cleanups from trying to run them From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman , Mateusz Guzik X-Rspam-User: X-Rspamd-Queue-Id: 1AF6940016 X-Rspamd-Server: rspam09 X-Stat-Signature: 4pog1c67h4cnubc1a15ctij8cks7emyr X-HE-Tag: 1740761696-611193 X-HE-Meta: U2FsdGVkX1/qAObcZQxKdo5eZHdDlCy4a2fHL4NiRcotN5Syv8yuP00e0XqbD7UM229fkpDZbi/raNkJMdckuywEhuJgY9xYM1ZfQ0XNmWiure1zpIcFd+gczzDSDvHuh1XL1Lq7/A4i6oNAELIJS7tnZwTWEhQjxOozu9Kwy+OhfrGcWx7A2xJAmWOHyXZWWVRo7oczk8jV1CxtyqfBpiWigkZPccYO8p6qUVgqiAkNOOXN3IQ+2gfERzmpt+GaMRHzPKjiTarYk1xhXRIhHDnOJG4g8crbWfrHf7cszU065SSUGnUvX8rroJMkp2v2VaU5GTN9Y8f8sLxUq/AcBd3fFQMeDmSFB9GOxMt9vWao/Bvuw1TDAf2ci/fBuVYF/oWmJ6VweTUvxaoQXIVox/ENH5pApugR6XziE6OQe9xC2E2JpcsdA7T78yaMlFhVtMarZDrksDv5Yg6lclzzKtoh0jsYatPqddL9hFMktMOoV6HS/7s0mNDtdVOL8oV8Xn/BpVZf79loThoOk4KJVXstFE0yz/guKQhRfzigoPthUpo+w07iPE/MYZ0zocQq0OJWfEw1iTEzPRg7UldiA8O0s42unH4MmfjHyvkVgne8Ts+fuEcML9DmOFyb83HmAby+UToy41oqF3PxWs8TdSErVsV8L63miNOhfXzeiMfCECPibYT/14qt9Omb8iyJDpE6GwD/rP673dJx6FDwkF+Fd0pby3YahP425dPleuFoJq+n8+LESSZxFYCJxpzyhWwx5sDedw5pFuP9BIZKGGUkHcWRfSnC6iMayLouyjxlt1T33pP+7s9ttI1BVQfPmBSCHKlxgNVhZ8D8HWn8TpdOyFalewczLZNKgsQRZz5qE4rCDbxh6atp/7xeHpcrE6geGNb5c45qDNGhN5O4kxFUsF6us2PGhBZzIVsXLZJB23GOUgf5OWMfrbfLtoj3I6fvAYadwVQyl+ORmm9 jsf6Knoo m3ULS8VEESB9THugDgtnGAGS8b3exyR86jZEA5/TvmvXZG5pxBXq1hqpXxLnDSwfRLBzM4+cqfmLkR5lkIOcROZ/1D7EQJMJ648SZspR3+dnyeWG3nXF6pVoSO3RCaUq4Tdcr3Vitx3qdHg2QKVyHIStfA6psyJaIsopGk33MMGq3W2rHXitKsLhNkQ5TogDZCsBfjNE0Dhk9F+lnwlRotWaUgH3tfYbqI36ZfhDI5T64qTVA8phUWzBcjq18yw8VzXjD0v1Nq1OTEg4/IRp1lBsTlzw5NaHnJCQUWjlb/6F6Mr6xnbir6317zRuynMq2RCLtqLfoopXDUrAmEMqb1YcX4qrH4AjYGweiyTXCOfTykPoH2ogv+ICeYyZm7Cu43r/1Zl/lnOCSbda8L8ZPdG+hxPkZXppfdTtrfCCHN6LjC3V/8VO3kC5467gcjSYLwWbmjrG5h32y6L+lM3GzlTBW+qoPmxcdQOOcPeqcenDN/bWHUBdN6dOSuPASzG9UoykQ7c0KLyLg6/1uFZn+Yps9Pacep6lmY/aiUk1ZuXu8GCEqVSUz1UmnMWOhOQ00Kn7c5Z3njWWeqyA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.092803, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I never had much luck running mm selftests so I spent a few hours digging into why. Looks like most of the reason is missing SKIP checks, so this series is just adding a bunch of those that I found. I did not do anything like all of them, just the ones I spotted in gup_longterm, gup_test, mmap, userfaultfd and memfd_secret. It's a bit unfortunate to have to skip those tests when ftruncate() fails, but I don't have time to dig deep enough into it to actually make them pass. I have observed the issue on 9pfs and heard rumours that NFS has a similar problem. I'm now able to run these test groups successfully: - mmap - gup_test - compaction - migration - page_frag - userfaultfd Signed-off-by: Brendan Jackman --- Changes in v3: - Added fix for userfaultfd tests. - Dropped attempts to use sudo. - Fixed garbage printf in uffd-stress. (Added EXTRA_CFLAGS=-Werror FORCE_TARGETS=1 to my scripts to prevent such errors happening again). - Fixed missing newlines in ksft_test_result_skip() calls. - Link to v2: https://lore.kernel.org/r/20250221-mm-selftests-v2-0-28c4d66383c5@google.com Changes in v2 (Thanks to Dev for the reviews): - Improve and cleanup some error messages - Add some extra SKIPs - Fix misnaming of nr_cpus variable in uffd tests - Link to v1: https://lore.kernel.org/r/20250220-mm-selftests-v1-0-9bbf57d64463@google.com --- Brendan Jackman (10): selftests/mm: Report errno when things fail in gup_longterm selftests/mm: Skip uffd-stress if userfaultfd not available selftests/mm: Skip uffd-wp-mremap if userfaultfd not available selftests/mm/uffd: Rename nr_cpus -> nr_threads selftests/mm: Print some details when uffd-stress gets bad params selftests/mm: Don't fail uffd-stress if too many CPUs selftests/mm: Skip map_populate on weird filesystems selftests/mm: Skip gup_longerm tests on weird filesystems selftests/mm: Drop unnecessary sudo usage selftests/mm: Ensure uffd-wp-mremap gets pages of each size tools/testing/selftests/mm/gup_longterm.c | 45 ++++++++++++++++++---------- tools/testing/selftests/mm/map_populate.c | 7 +++++ tools/testing/selftests/mm/run_vmtests.sh | 25 ++++++++++++++-- tools/testing/selftests/mm/uffd-common.c | 8 ++--- tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm/uffd-stress.c | 42 ++++++++++++++++---------- tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 +++- 8 files changed, 95 insertions(+), 41 deletions(-) --- base-commit: 76544811c850a1f4c055aa182b513b7a843868ea change-id: 20250220-mm-selftests-2d7d0542face Best regards,