Message ID | 20250303100617.223677-1-yizhou.tang@shopee.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FEDC282C5 for <linux-mm@archiver.kernel.org>; Mon, 3 Mar 2025 10:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BBDC6B0089; Mon, 3 Mar 2025 05:06:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A426B0092; Mon, 3 Mar 2025 05:06:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60AE16B0093; Mon, 3 Mar 2025 05:06:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3EA216B0089 for <linux-mm@kvack.org>; Mon, 3 Mar 2025 05:06:27 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E16CA140618 for <linux-mm@kvack.org>; Mon, 3 Mar 2025 10:06:26 +0000 (UTC) X-FDA: 83179809972.01.07F74EC Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf04.hostedemail.com (Postfix) with ESMTP id 00B6A4000B for <linux-mm@kvack.org>; Mon, 3 Mar 2025 10:06:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=aLoNv65t; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf04.hostedemail.com: domain of yizhou.tang@shopee.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=yizhou.tang@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740996385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=c2xvnbw0JuGYZ3kMUPAj9qebO9ot86k6LgdKqU+QHZM=; b=dpn9oYoFvVqMFJQ9E5rrdghIujrzEYutGAzs2GYkpRUj0TMcuQ09Gnhpdygx7IMFb+KUCY pOVTxX/VdZGamm7HIWJqM1poMplGmZJqqg9+g16igiSu76MGurzifuV9oU9j3TyGp5T3bj ZPBfOnPALwTzgN7Yp75yHcg1gctKz5A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740996385; a=rsa-sha256; cv=none; b=lLiowVNsau3t3f8OrmUdzAkXPdtkuXUzKO7fC9sjdRm28G/+951Ab0q6EAoDJllNZq9Amy iQTC+Ndj1cjSt/P6yL7RD/JwZD1pZKGu1GAAtkPFQUtv/VpRMP9nknNRNfAuAMTPVc/DR/ aLFWENEfMcW5Oqsp84z35PWM1hk3U2c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=aLoNv65t; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf04.hostedemail.com: domain of yizhou.tang@shopee.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=yizhou.tang@shopee.com Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2234bec7192so55985855ad.2 for <linux-mm@kvack.org>; Mon, 03 Mar 2025 02:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1740996384; x=1741601184; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=c2xvnbw0JuGYZ3kMUPAj9qebO9ot86k6LgdKqU+QHZM=; b=aLoNv65tXaK7vEsrdNBGYvolmcAp8Cz82cbzfG4YYlliryYDbYjX9AbAwoH/WSBtEO xvP7VOkW0GMWhWKUJvA4a+5ti/X0qbRLH7VR2Y1XLpzjewUDlrl2pZ8X/4t3pmZoFuTl XCZaw6QlV1nivmRsVcvBzoRppnitE9G2kVFd5qAwCAuGSMQtWzKWU2TM/Tvpm2Msm2ze FGBCx9qjgTBuDmushiPZ6dc77DnofxbPAu2y3GLMJXzCkspzOHBprIQNUX0D4n2WCaTT 6t189H19LC21zM+lo+BBIGbQDCOK4xpIRD6AkDWrzdRZ5qcLfrLqsNKecr2osM3G/4XU 5tPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740996384; x=1741601184; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c2xvnbw0JuGYZ3kMUPAj9qebO9ot86k6LgdKqU+QHZM=; b=XgNlLGzxrbsaTHEPOx1H0Nzw+h1ZKX7CvdTUQj6jFbR0irw2oMzneKbSDYwEW54TzZ AIEd7fOcoL1b2UYiEKoofg/W9N51/3aIIYQ0BsshKpoWgplil0YM5vyJkLPhX297K/W2 RTFwBM01Wypi/r7y4EAybOlYS1QOqSwlfYv+RzW9/SRbiJCPd5TjSvxwBUXGbJ+lwHy4 UMmhGwXeYII9J6hddX6Bzxy5QdL6xPn5tXqjkCVm4alNmtjz5eDApEY7eh3mm9/+Prj2 /QH/3wdh7aooQ8u/8HwDDf3yrjMfeWCEU88Tmw4nAM2UuJWDqWZemkvGQX2nBt/D5AQN UKbA== X-Forwarded-Encrypted: i=1; AJvYcCW8LLP9dc7QWViKuaCU8OYABT6OLNfYa/qsnXab0nfLWU+yee46dhNp0UFKQlAsiMLqiUjhU7uuow==@kvack.org X-Gm-Message-State: AOJu0YyVAKQGx566qJ5u7PtTkc7dyCXbaWRHeGQCmD+9T1XEnEpUCJn2 03dUHrAnmtwzfSwxmGYgiTbNe8D7+q+xzWxwQVonN9hf2oje2Rprd0o9HTchLWE= X-Gm-Gg: ASbGncuelNT+V+7ahnzQRc8LwgsHI04cVQN93RfYKefK79PM8lJEVv/w78EuEjWypBx Q3EwZhkuhUg7rr7WGqhxBsrSur1oXomOKtuLosdaVwqtzIThzf840SDh4ELDN5ktlcpbJZz3/Aq gHlItlyvo1rAes3CW4pAfrfMW/yTuW3RcvZynEd/P1MJgD7uGfrwix9TMSFM5Lc4gryTvuI4WTR q0dT9xAMQoSP1eOhkXve+YRsAyUyMRzUj9fz47YIIZRkvxu/8dH8LgZvF4TGUP3x7w5TnuNqmpO gDNTD6dUM/pVQXAOKaBCqLec2UNzlQ== X-Google-Smtp-Source: AGHT+IHEynmWuf/VC/tNMisellPQ0994Vlxa4c8xxDyclOEyECs3a2rUWIXx0layqxHXPQw7tF9mhw== X-Received: by 2002:a17:903:2ca:b0:216:725c:a12c with SMTP id d9443c01a7336-22368f612dbmr196639065ad.9.1740996383883; Mon, 03 Mar 2025 02:06:23 -0800 (PST) Received: from localhost.localdomain ([143.92.64.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22350537b47sm74397275ad.251.2025.03.03.02.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 02:06:22 -0800 (PST) From: Tang Yizhou <yizhou.tang@shopee.com> X-Google-Original-From: Tang Yizhou To: tj@kernel.org, jack@suse.cz, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org Cc: rostedt@goodmis.org, mhiramat@kernel.org, ast@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Yizhou <yizhou.tang@shopee.com> Subject: [PATCH RESEND 0/2] Fix calculations in trace_balance_dirty_pages() for cgwb Date: Mon, 3 Mar 2025 18:06:15 +0800 Message-Id: <20250303100617.223677-1-yizhou.tang@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 00B6A4000B X-Stat-Signature: n5kyi6ryambjeet11ie439ksm8k6g8ca X-HE-Tag: 1740996384-234826 X-HE-Meta: U2FsdGVkX1+7w2bYSgidx3wrtZWjAx6nrMFhG7KyDlw9fdbt/1PMISDU8J0nEfLKdgKDcYXLJsIdFZG+hkWJmW7dVRRrQls9UOEKI7XKvy0jQbuVxIFGEYmEi1o4nVPaDjpSEp1J+Q4hNjmQYza6fYlBoCVarx+S674tLTZCXFLczqPYa4faYeZpApIsjfeGco0MY3LPxNPGOEt7p2s0whB8ZiYNTV7KqWB4Gwh9Y7qt8oD6McfBjNKdqekd9UwhPGKGqih1qHl58YX9jmrkRr1Kzl52x8pSZlx5EJKLzxVMgwn+XVx/A6ZuLeLD1tgWsAwW5X5upIuuZ62W7jlVeFWPjvMh5E4Jbmxxs5iiWMNRN7Q1x5i1hZaYfPn9kVdgcsQBSQ8AOcwqhCzfzraQQ7//ml0DBeHTIfxBsORkI0kK+Mj3xEQpO52S9tYIhYfoG82+o/faJW8oqcRxukRSiz2Sy1hfzYv/dFLF4ja56H7zwFWpg8+W/wAZwUZ38S15DObR23j8e2PDUj1vnwtYy9RdihcPMkWCQRWpnYwv1G7ybOPKeh1/zopg13x6ISmY+9EkTcMtWePosCMr5gURECesT1WPqBoZYDh5LL1hPtBqwfeM2CPklBgs/hPB6NE2onqmcgZKbqBJ1E4hQFCnOSh8tX7mhA58dXgt37uS5nvAbmkaWJ4ojP7Aa31rhjvNLdOilOGwjLTh56pIGhtpZhrmAJKCN9gcBnsOC6yz29wuSvkjKs+Ew+6aTZdgr3QRFdMmIP+zPeMZZ6Ikz1r9ymhqSfGdxmXqBlGoLGubzHKSzAlchhGBn61k02nemQXw9ynPEO6jQ3YYbeQYxsasUe9mAQ+/u4SyHLXUfzbqjJHlNbvcgASwFJfflCSb0hv/KUcvOCPGkZQWSTD7gBllYq9XgTxmLnJvfKOfgLrXfFp7KiX6NP2/cCwlOXZYIh5pK8B4fR38+FuOL7SYCTb eVeqzF05 sJ8F/1WTQ3wSIPBsDvn6adLKZ6R7SjNjx2ne3rAQ2p/2L13R6hwSLg2jYRWGqJo/40Bjcva3N+3ogxJEawdTbIM+ZwoC/8JHbWTKQZD0x0tvvefbVjMa6NgK9E1MV8vLOQW8HpQLWwUPlvnp67AvSmo7JLp4A0hk2TuEY+w7DviJsk2BQtIre5xOqmuJXJHy3XtW0wKk+ax+n6oDgkMdkZdk0zuNUIJp9gMAGGZmXcWr0TjyvH09QaAjMNiS+rcUmFIJTDd7bag5Q3inEOmfD2FS5EOdoitc9elBf7cTzwL+9RXGu7IibI66+B5vSD2OXNffQMipSYJ5DnUKbSjrB25juTgBm/9N8KAZYH1RXATAOC7CqINeYvZtSlgAn6i5741K/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.013530, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Fix calculations in trace_balance_dirty_pages() for cgwb
|
expand
|
From: Tang Yizhou <yizhou.tang@shopee.com> In my experiment, I found that the output of trace_balance_dirty_pages() in the cgroup writeback scenario was strange because trace_balance_dirty_pages() always uses global_wb_domain.dirty_limit for related calculations instead of the dirty_limit of the corresponding memcg's wb_domain. The basic idea of the fix is to store the hard dirty limit value computed in wb_position_ratio() into struct dirty_throttle_control and use it for calculations in trace_balance_dirty_pages(). Tang Yizhou (2): writeback: Let trace_balance_dirty_pages() take struct dtc as parameter writeback: Fix calculations in trace_balance_dirty_pages() for cgwb include/linux/writeback.h | 24 +++++++++++++++++++++ include/trace/events/writeback.h | 33 ++++++++++++---------------- mm/page-writeback.c | 37 +++----------------------------- 3 files changed, 41 insertions(+), 53 deletions(-)