From patchwork Mon Mar 17 06:18:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 14018685 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73331C282EC for ; Mon, 17 Mar 2025 06:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 954B4280003; Mon, 17 Mar 2025 02:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 905A5280001; Mon, 17 Mar 2025 02:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CBFC280003; Mon, 17 Mar 2025 02:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E470280001 for ; Mon, 17 Mar 2025 02:18:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 34186161993 for ; Mon, 17 Mar 2025 06:18:33 +0000 (UTC) X-FDA: 83230038906.25.F4A6936 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 34C5640002 for ; Mon, 17 Mar 2025 06:18:31 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742192311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=V/eQJqVgbd3UXy9T88/l4rv0D+h5MVbR2tramUFNA08=; b=GUI39FXizYBpwxmbPjKSYzFrVdKY83h2WLvg0W9zIF/2feKzhW/52vhzlcEGAt8wnkTYai u5bdmF4ojBvB6AQQJr+f9MzNHhF7WdXJBtfRnz0WeqZy01hsF0rrX3FNEv/WL/UgMqO81v w+Xp0e4gc78Gd6sGHvEaVA07KXsW0Bo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742192311; a=rsa-sha256; cv=none; b=QtqpfeTP79vT4uKLENk8GjQmACmbUmxQKPwv/rgxMjkk6ISwNGtziADapT83QMBIJWng+Y 5ESPBK5HsQLaed/Nuo4VZxzKSx32kcDwOCLe9gotvtVTTpxJPz5Mh2a8+6dhNaBolAgOpO WGkGuxqJSlC5NkxG15cSQNYKu4krcxU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2595E13D5; Sun, 16 Mar 2025 23:18:39 -0700 (PDT) Received: from a077893.blr.arm.com (a077893.blr.arm.com [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6A6203F673; Sun, 16 Mar 2025 23:18:23 -0700 (PDT) From: Anshuman Khandual To: linux-mm@kvack.org Cc: Anshuman Khandual , Catalin Marinas , Will Deacon , Steven Price , Ryan Roberts , Madhavan Srinivasan , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Gerald Schaefer , Heiko Carstens , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [PATCH 0/2] mm/ptdump: Drop assumption that pxd_val() is u64 Date: Mon, 17 Mar 2025 11:48:16 +0530 Message-Id: <20250317061818.16244-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 34C5640002 X-Stat-Signature: jah16om1q3jofbg3jwiguxyetdy73phb X-HE-Tag: 1742192311-970185 X-HE-Meta: U2FsdGVkX1/cDcFFxqJ7/i7mwtLH0+RYCUNocoMpVqWSPPHeI0tlX0pKZOtOgUEtm7mczb07lgxYT1gH7vu1pVwZWKnod0YuaBZbIsbTQTEKATb3jTZiJea9Iemc6fBzoomshZpx5EuskP9exe+/byMMfL++BjcMnkNn5RlBpIcqO0ZTyxbSEZndWGaJ++XysTmOLmEed/x7JDoN/11BCQTOqn1R3+qYGJzFFMjkzDOuwi8/kgrdeYKx2TPmtCQrsVRV8QC7ctSt+g/FpeVTiFn9Pf9jA31LXYNY+KgIf9UCxQ1Ppe9lISGAMmOAX60AQjUMIk5Kwu1YxYg418vpd74sQY4HrOuLP+gpcj/XOO5BwoERRMyJdtB3xiHdbhnm2TjiDiHmrfZHguk589imhMjXwoCuNmYZZYxw3QLTrwFA88/B+JKt5pgVVQ/vMHIzSH8cKi+A9l9hp/xVmjLPsyUIs7S2sz3ig5YRZofryQmKUBDlm1P+vgj3Bad9/0/OZ1LQDhRaC9FsaOdxNrfamu2tRcCHl8+eD08U0eEs0KFqIgIrVayROAXiu+yt+J9nT0tyibBSWE0sGnBkU+d5UIjCpkW//eP0OoQi3CbyuogEVMRvANxrVmnYNkCYVW4FZps6oAYUGEUsP0//K99bTGhyh1BdTtZNG5wNbD9WkHD+UZthzfq95UxGHRzWwztft2NIWELxCJO81HwsvGnCfEnyLncWjqz0Ty2oiBqiV5qGJqJdXSzn9a5KFI73CpM8GXsv0vtQICVvJAzvdnnVbRxK57loKSe0KwwcvmhzdBggUsxOPpaxtIcaDb7kh3cogkhGBWjpZVUKRhNP58ZlsAdQyt003uUKHJvPiOMKT+SFWXr4VR0F21Qz/QI8id7MK6wuKYLWL4fCxTFgaFpa5ywycTvdbG6tJufsVyHCUMadpwOOKuHlKA+NyFXOBc7/bm1Fvw0PFTMYy5sPETa 6CGq2QaW /Bb1rXSQMxkIHDmRpLe+AErKkUVMGPujNxdH+OFpdcYu2A5WdRAFALXpzxxa1mca9K3DlGS++8ytYa2Xf5Qm5EHiS3ah3dKyUU8+2XlRoWW5fJKVCyPqsULCoWY/+ExPpvS/NWmLYm2llap3l1mDYemuOtbS8dTxhMdNzpvzxBf7uCeNJURt9ZVoEiNP4+Qg/uoF0ERhQ7q/paRQJjQn1Pt+oRAAgJ397fQfkbB9VJiQUSUSeWJXwy9ymdcsNcCDyvMoYxl5ouAfHKxztBgZWm4Jukndxb/v1sd/7B7tHiq10f6theyLFeHtnw3fAC9vf4jXwv4UXYvsg2J+9ipgqzPKY/kaBv2fId82ovnlFdy85y2TB5EA6X7anWziGCC9o20gOcZ2AZFwM1JGnwO/lFc4Xh00v9EjqMfSVVS0ZuZwUDc4mNQH3QiSVbCepqpdtuXbu3fkfYuxPmye2UF2qg2J5Ell52q4026u28kAgjgb3Es5v65oBbASICVYvR6fz2YEXY8VGGnvD4zyXdQIB62w2P4k62iuHpJLlz75jf7T4avtWbTkgjnmuwEkmHXydymENQZeCE9k7LLzI9YuZb+uv+r7fGObyAOP0NeLtcVeYikHTbba+4vecmxnZGXb//ogcBVxm3uCHS7hEl0QHC0ntrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Last argument passed down in note_page() is u64 assuming pxd_val() returned value (all page table levels) is 64 bit - which might not be the case going ahead when D128 page tables is enabled on arm64 platform. Besides pxd_val() is very platform specific and its type should not be assumed in generic MM. This series splits note_page() into individual page table level specific callbacks which accepts corresponding pxd_t page table entry as an argument instead and later all subscribing platforms could derive pxd_val() from the entries as required and proceed as before. Page table entry's value, mask and protection are represented with pteval_t not u64 that has been assumed while dumping the page table entries on arm64 platform. Replace such u64 instances with pteval_t instead as expected. This series has been tested on arm64 platform but it does build on other relevant platforms (v6.14-rc7). Changes in V1: - Added note_page_flush() callback and implemented the same on all subscribing platforms - Moved note_page() argument change from u64 to pteval_t on arm64 platform from second patch to the first patch instead Changes in RFC: https://lore.kernel.org/all/20250310095902.390664-1-anshuman.khandual@arm.com/ Cc: Catalin Marinas Cc: Will Deacon Cc: Steven Price Cc: Ryan Roberts Cc: Madhavan Srinivasan Cc: Nicholas Piggin Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Gerald Schaefer Cc: Heiko Carstens Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Andrew Morton Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-mm@kvack.org Anshuman Khandual (2): mm/ptdump: Split note_page() into level specific callbacks arm64/ptdump: Replace u64 with pteval_t arch/arm64/include/asm/ptdump.h | 24 ++++++++++++---- arch/arm64/mm/ptdump.c | 50 ++++++++++++++++++++++++++++++--- arch/powerpc/mm/ptdump/ptdump.c | 46 ++++++++++++++++++++++++++++-- arch/riscv/mm/ptdump.c | 46 ++++++++++++++++++++++++++++-- arch/s390/mm/dump_pagetables.c | 46 ++++++++++++++++++++++++++++-- arch/x86/mm/dump_pagetables.c | 39 ++++++++++++++++++++++++- include/linux/ptdump.h | 9 ++++-- mm/ptdump.c | 42 ++++++++++++++++++++------- 8 files changed, 272 insertions(+), 30 deletions(-)