From patchwork Mon Jul 13 17:28:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Down X-Patchwork-Id: 11660803 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D04DF13B6 for ; Mon, 13 Jul 2020 17:28:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93012206F5 for ; Mon, 13 Jul 2020 17:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="NRegjh3L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93012206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90B1D8D0002; Mon, 13 Jul 2020 13:28:11 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8BADA8D0001; Mon, 13 Jul 2020 13:28:11 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9B78D0002; Mon, 13 Jul 2020 13:28:11 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 6507C8D0001 for ; Mon, 13 Jul 2020 13:28:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EF1D28245571 for ; Mon, 13 Jul 2020 17:28:10 +0000 (UTC) X-FDA: 77033735940.02.sleep85_62182fd26eea Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id B9D3660001F41383 for ; Mon, 13 Jul 2020 17:28:10 +0000 (UTC) X-Spam-Summary: 1,0,0,473f2c900d889f33,d41d8cd98f00b204,chris@chrisdown.name,,RULES_HIT:41:355:379:967:973:988:989:1260:1277:1312:1313:1314:1345:1437:1516:1518:1519:1535:1542:1593:1594:1595:1596:1711:1730:1747:1777:1792:1801:2198:2199:2393:2525:2553:2559:2564:2682:2685:2689:2731:2859:2898:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:6119:6261:6653:6742:7875:9025:10004:10400:11026:11232:11473:11658:11914:12043:12291:12297:12438:12517:12519:12555:12679:12895:12986:13053:13439:13895:14096:14097:14181:14394:14721:21080:21444:21451:21627:21740:21990:22013:30034:30054:30066:30070:30090,0,RBL:209.85.218.68:@chrisdown.name:.lbl8.mailshell.net-66.100.201.201 62.2.0.100;04yrtqigm5n37a1b5s7b5ubetbbu6op68zfkkz3i7p5aj95pb8araq75ce98gpt.wrjua59w9579whhi7upm6fctkumoqh53riz95oxbydfnh6py7r1tq9c8hazcwbr.6-lbl8.mailshell.net-223.238.255.100,CacheIP:non e,Bayesi X-HE-Tag: sleep85_62182fd26eea X-Filterd-Recvd-Size: 5266 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 17:28:10 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id n26so18197957ejx.0 for ; Mon, 13 Jul 2020 10:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=pH1K2vUzPfJhwEBVdOMPKdK/A94n7hLqQfvszT16hv4=; b=NRegjh3LBWDlrzUeOyPaQJxImhcWMjvignzs5E6UY4PzLSDkmPbyXeWAHNwJECOTmS cwenOTW+EsLhulDrayiQ/2zwo5NgqG4xyARuMoN+FCHCM4FS8fduE6c0yLQ92Dik+fN9 qPQsCSXMlAdYzgiDDf30IbAHXQyAltxf+sHHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=pH1K2vUzPfJhwEBVdOMPKdK/A94n7hLqQfvszT16hv4=; b=lRDMQ/1Wu1hFCBr8z5m75z8OeW6duNn87dzo4r2NJDu1a1OPun59OAKMtu6/ZKTNUR oAgH81Cxo0a4xHeiL2yu2bnvwpfQyPCYVoNLQrtkqoVZg9eacr4O3A/5KgLTis3e5+gP v7W/FMzfO4ElsL8fQ4DIe26rzcPfK9HpsHu7u1cTwRrt3wylo4Qw5RgMs3J18Y5RapZs wKG/cRzZ4zXGvljs/YeFzj7Por19eNM+IdcZYavJ3JNLMp1toHeiLWJQyXEeAw8+UVqL yViq2ENaEiTEfuhR2p8y1lXiGf8W+1p8tmPs2Y7x/K6lLZ7zsGUZ95TbOSk7U6yGtvTl qjpA== X-Gm-Message-State: AOAM531nn07aL0k650UZ9F/khYyB22waJ5r5sdj4u2LEIBerp6e8AOkQ JXCzLx8k7zfWq4SGXxcvPVwAsw== X-Google-Smtp-Source: ABdhPJxBuP+bUAv3rzAwsjjREEpJYKQWi2Eub0eeBpMQBkIX2vw77IaPWiNeyjfA4TaX3+SHhnNC/g== X-Received: by 2002:a17:906:9244:: with SMTP id c4mr796991ejx.60.1594661288807; Mon, 13 Jul 2020 10:28:08 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:ef88]) by smtp.gmail.com with ESMTPSA id b14sm10150344ejg.18.2020.07.13.10.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 10:28:08 -0700 (PDT) Date: Mon, 13 Jul 2020 18:28:08 +0100 From: Chris Down To: Andrew Morton Cc: Hugh Dickins , Al Viro , Matthew Wilcox , Amir Goldstein , Jeff Layton , Johannes Weiner , Tejun Heo , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v7 0/2] tmpfs: inode: Reduce risk of inum overflow Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.14.5 (2020-06-23) X-Rspamd-Queue-Id: B9D3660001F41383 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In Facebook production we are seeing heavy i_ino wraparounds on tmpfs. On affected tiers, in excess of 10% of hosts show multiple files with different content and the same inode number, with some servers even having as many as 150 duplicated inode numbers with differing file content. This causes actual, tangible problems in production. For example, we have complaints from those working on remote caches that their application is reporting cache corruptions because it uses (device, inodenum) to establish the identity of a particular cache object, but because it's not unique any more, the application refuses to continue and reports cache corruption. Even worse, sometimes applications may not even detect the corruption but may continue anyway, causing phantom and hard to debug behaviour. In general, userspace applications expect that (device, inodenum) should be enough to be uniquely point to one inode, which seems fair enough. One might also need to check the generation, but in this case: 1. That's not currently exposed to userspace (ioctl(...FS_IOC_GETVERSION...) returns ENOTTY on tmpfs); 2. Even with generation, there shouldn't be two live inodes with the same inode number on one device. In order to mitigate this, we take a two-pronged approach: 1. Moving inum generation from being global to per-sb for tmpfs. This itself allows some reduction in i_ino churn. This works on both 64- and 32- bit machines. 2. Adding inode{64,32} for tmpfs. This fix is supported on machines with 64-bit ino_t only: we allow users to mount tmpfs with a new inode64 option that uses the full width of ino_t, or CONFIG_TMPFS_INODE64. You can see how this compares to previous related patches which didn't implement this per-superblock: - https://patchwork.kernel.org/patch/11254001/ - https://patchwork.kernel.org/patch/11023915/ Changes since v6: - Fix misalignment in percpu batching, thanks Matthew. Chris Down (2): tmpfs: Per-superblock i_ino support tmpfs: Support 64-bit inums per-sb Documentation/filesystems/tmpfs.rst | 11 +++ fs/Kconfig | 15 ++++ include/linux/fs.h | 15 ++++ include/linux/shmem_fs.h | 3 + mm/shmem.c | 127 ++++++++++++++++++++++++++-- 5 files changed, 166 insertions(+), 5 deletions(-)