From patchwork Wed Oct 30 15:12:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13856674 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3BBD5CCB8 for ; Wed, 30 Oct 2024 15:13:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E8358D0005; Wed, 30 Oct 2024 11:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 797618D0001; Wed, 30 Oct 2024 11:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 637C38D0005; Wed, 30 Oct 2024 11:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 42F6E8D0001 for ; Wed, 30 Oct 2024 11:13:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EEEB48035B for ; Wed, 30 Oct 2024 15:13:23 +0000 (UTC) X-FDA: 82730611572.22.3FFBFA4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 66D81120023 for ; Wed, 30 Oct 2024 15:12:47 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gCP46uYg; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730301121; a=rsa-sha256; cv=none; b=R9K3LVMTftxZ0d9f6tkKiVEc91MteOD9lfir21IhmNC4My4OeEjEurouXeQqT4jHcP9T3n yJqCOHwIx/SGebDOhfvakgCaHe9EQlU4Ya14lsePxokty1wgSIVGvNiqLIVsH+hpqdkLnd C541Nr+kO4BnG+LmWXVPNB9Yxny/+rc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gCP46uYg; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730301121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=oJghx1eV4PhdP9X0UIBXFkwX0UCVclfaa5qaRC6bos4=; b=7kp/UhOb8p9Kf7pXNAZijwMM9Le9W0IyWJNEKzJ85nI1Citm6nuDT1n7prvV9wX3dVdUtW W/7ZVzUTdZPE/sq9fGM1F6CzrUT7mEbWC/eWqQ6E/RBl9mMnbqy9HbiH69QkWM4kHFM93q tHDfhuo/6xmEValYpybG5r1GnAsg548= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1CEE35C5E8C; Wed, 30 Oct 2024 15:12:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12AF6C4CED0; Wed, 30 Oct 2024 15:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730301200; bh=BPbjQPb6vGxydr+aOv/vfeRL/hbb2O9lYDlE3QJn810=; h=From:To:Cc:Subject:Date:From; b=gCP46uYgAbBaI3H7fz/S8et11Yja3YaPso3wiIP1VABNA/Cw7GX7ylsdhwfYayuLN tvqEai8WwN5iYR5Fhi//NTee44xw07H0gUQ9GqWAIjaeptBjzdT5GrGfQ/TGUYfAKO 7aDmA75HZ9TBEa0PI5aYKbQEau7P7laA9c+jxlBKHqxlEc3bj5Y0FSmX/h4YZTfcI2 knjpXENs520PV7RRQEEr0W82jk+5mf7brt08Ba5elyHnS9fSx+le8ADdVhAE1Qju61 JxO6MZ5Ey8fhyWUsyAm5P+5M1vp0qBfzfnYftLY6UQeDGK5n/E9Pyvw3w6TZBBaPxu cb1zWIi5tJ4sg== From: Leon Romanovsky To: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v1 00/17] Provide a new two step DMA mapping API Date: Wed, 30 Oct 2024 17:12:46 +0200 Message-ID: X-Mailer: git-send-email 2.46.2 MIME-Version: 1.0 X-Stat-Signature: o6waoce4zwk4hifs9uo3gjbn1txeyf3o X-Rspamd-Queue-Id: 66D81120023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730301167-377764 X-HE-Meta: U2FsdGVkX1/8xboHR0AI4xz3dHAiXnP8Ey0OIpoWCxT//ebdEq268Dcf7ztmZMg68XRp2Viive6GU7Msw6XZIQu2toP8OqFwWFzitcO8oXjP/CQ54FlXDE4o2GFmNKLOutsBJChOixymEiIZvWJOKEoHig/+xUx+Gk0YAYh0ie4ACyJFYw8c44xaSWiLZA4HewiMaS0ydppY/GO07GoSDa6bw2bdj5bv/1xTF0FoaEc40HICLExVkpDg41aed2RYlbNcxKvcFRpYst5DxGrWNPMSbZisf6h663RguVjRHBGTcSi+Xfn8PpKTb1+86BlRIOEv/Uq8vDON3DlnRM39HKdAd85ZyDS4uDO/9Phm8tyB2eAnKqtlUqnfaIJpJPmu11y02T/25dF/PU8JrVNaQ2RFbHblysIV1Md6iai75j0wzLPSEOF2g5HnIfkK1T1fsxGcZGfJmehmCCnRtsC5li54IT1pzG0V8URYC6Jx7JhD0Gw8e+2TZphN8lBwU6BHQrKJ6Le58zuU08tuxS8+b5c4iIG+5Q+tlc4ojyIAz9VyTwTAuQUZvOTm+0SLN6mHBNI4ZY9nNj3MMIp/hcghSKG8viNceCa5F4LaG7/9Sil06yAaOACuIE/oMpx+gK6OvVoH+4R3KEA+47cavdRsgaQZWTsMd84yJkYtfMZ0I6R+DFUM+Juloiv1NllcF8UWYWfS9oTcSx12/P+Xc1mSGN4PSYxtNHRsL+REcvHBw3KMXHHnuN8k0iBhBOMvypI+wZwrexkjnCJNsrUV5XQ8p4HwHGkIMbA+/X2SV94Y25axPKADHkwCriIxo1Hol/VAjoYI43cP9NzvlGWT4haKteqCe2UrFN8UYJBMgTXQhH25bCECKrnfT59COYNIMnLcSoJz1QQBdSHyboYlZb6l1mkuG6CnZpY8EYGP+U5eJG9gDuG9SKMvnFr3TmEry72H1PHRlFJOiQIqhiAfyPP 326cC0Rz p5K+RlGj1jcSafT0QgTTDpwaMwjtbxJe4kZtWDpKgcjZnPFg9fe4s0EYe9yz58l4g9JRWWzPQ1qo0gGSGiuNs1yg4X5zDQmu9/3y3GKHN9slnkv6mVGXnpkvyKMDkaXt684pg7g64qgs8jVfCE1JQWstr7295jUWW2elYNGoc1D8NodG905HVRBPddO8tJ2g8w05OVZ/eRx6E7BtYsQ0ZZNhHJnaCiNakJuFEqrISE8Ncl1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Changelog: v1: * Squashed two VFIO patches into one * Added Acked-by/Reviewed-by tags * Fix docs spelling errors * Simplified dma_iova_sync() API * Added extra check in dma_iova_destroy() if mapped size to make code more clear * Fixed checkpatch warnings in p2p patch * Changed implementation of VFIO mlx5 mlx5vf_add_migration_pages() to be more general * Reduced the number of changes in VFIO patch v0: https://lore.kernel.org/all/cover.1730037276.git.leon@kernel.org ---------------------------------------------------------------------------- The code can be downloaded from: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git tag:dma-split-oct-30 ---------------------------------------------------------------------------- Currently the only efficient way to map a complex memory description through the DMA API is by using the scatterlist APIs. The SG APIs are unique in that they efficiently combine the two fundamental operations of sizing and allocating a large IOVA window from the IOMMU and processing all the per-address swiotlb/flushing/p2p/map details. This uniqueness has been a long standing pain point as the scatterlist API is mandatory, but expensive to use. It prevents any kind of optimization or feature improvement (such as avoiding struct page for P2P) due to the impossibility of improving the scatterlist. Several approaches have been explored to expand the DMA API with additional scatterlist-like structures (BIO, rlist), instead split up the DMA API to allow callers to bring their own data structure. The API is split up into parts: - Allocate IOVA space: To do any pre-allocation required. This is done based on the caller supplying some details about how much IOMMU address space it would need in worst case. - Map and unmap relevant structures to pre-allocated IOVA space: Perform the actual mapping into the pre-allocated IOVA. This is very similar to dma_map_page(). In this and the next series [1], examples of three different users are converted to the new API to show the benefits and its versatility. Each user has a unique flow: 1. RDMA ODP is an example of "SVA mirroring" using HMM that needs to dynamically map/unmap large numbers of single pages. This becomes significantly faster in the IOMMU case as the map/unmap is now just a page table walk, the IOVA allocation is pre-computed once. Significant amounts of memory are saved as there is no longer a need to store the dma_addr_t of each page. 2. VFIO PCI live migration code is building a very large "page list" for the device. Instead of allocating a scatter list entry per allocated page it can just allocate an array of 'struct page *', saving a large amount of memory. 3. NVMe PCI demonstrates how a BIO can be converted to a HW scatter list without having to allocate then populate an intermediate SG table. To make the use of the new API easier, HMM and block subsystems are extended to hide the optimization details from the caller. Among these optimizations: * Memory reduction as in most real use cases there is no need to store mapped DMA addresses and unmap them. * Reducing the function call overhead by removing the need to call function pointers and use direct calls instead. This step is first along a path to provide alternatives to scatterlist and solve some of the abuses and design mistakes, for instance in DMABUF's P2P support. Thanks [1] This still points to v0, as the change is just around handling dma_iova_sync(): https://lore.kernel.org/all/cover.1730037261.git.leon@kernel.org Christoph Hellwig (6): PCI/P2PDMA: Refactor the p2pdma mapping helpers dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h iommu: generalize the batched sync after map interface iommu/dma: Factor out a iommu_dma_map_swiotlb helper dma-mapping: add a dma_need_unmap helper docs: core-api: document the IOVA-based API Leon Romanovsky (11): dma-mapping: Add check if IOVA can be used dma: Provide an interface to allow allocate IOVA dma-mapping: Implement link/unlink ranges API mm/hmm: let users to tag specific PFN with DMA mapped bit mm/hmm: provide generic DMA managing logic RDMA/umem: Store ODP access mask information in PFN RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkage RDMA/umem: Separate implicit ODP initialization from explicit ODP vfio/mlx5: Explicitly use number of pages instead of allocated length vfio/mlx5: Rewrite create mkey flow to allow better code reuse vfio/mlx5: Convert vfio to use DMA link API Documentation/core-api/dma-api.rst | 70 ++++ drivers/infiniband/core/umem_odp.c | 250 +++++---------- drivers/infiniband/hw/mlx5/mlx5_ib.h | 12 +- drivers/infiniband/hw/mlx5/odp.c | 65 ++-- drivers/infiniband/hw/mlx5/umr.c | 12 +- drivers/iommu/dma-iommu.c | 459 +++++++++++++++++++++++---- drivers/iommu/iommu.c | 65 ++-- drivers/pci/p2pdma.c | 38 +-- drivers/vfio/pci/mlx5/cmd.c | 373 +++++++++++----------- drivers/vfio/pci/mlx5/cmd.h | 35 +- drivers/vfio/pci/mlx5/main.c | 87 +++-- include/linux/dma-map-ops.h | 54 ---- include/linux/dma-mapping.h | 85 +++++ include/linux/hmm-dma.h | 32 ++ include/linux/hmm.h | 16 + include/linux/iommu.h | 4 + include/linux/pci-p2pdma.h | 84 +++++ include/rdma/ib_umem_odp.h | 25 +- kernel/dma/direct.c | 44 +-- kernel/dma/mapping.c | 20 ++ mm/hmm.c | 231 +++++++++++++- 21 files changed, 1377 insertions(+), 684 deletions(-) create mode 100644 include/linux/hmm-dma.h