mbox series

[v2,0/2] Fix mm/rodata_test

Message ID cover.1732016064.git.ptesarik@suse.com (mailing list archive)
Headers show
Series Fix mm/rodata_test | expand

Message

Petr Tesarik Nov. 19, 2024, 11:37 a.m. UTC 
Make sure that the test actually reads the read-only memory location.
Verify that the variable contains the expected value rather than any
non-zero value.

Petr Tesarik (2):
  mm/rodata_test: use READ_ONCE() to read const variable
  mm/rodata_test: verify test data is unchanged, rather than non-zero

 mm/rodata_test.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Kees Cook Nov. 19, 2024, 5:41 p.m. UTC | #1 
On Tue, Nov 19, 2024 at 12:37:37PM +0100, Petr Tesarik wrote:
> Make sure that the test actually reads the read-only memory location.
> Verify that the variable contains the expected value rather than any
> non-zero value.
> 
> Petr Tesarik (2):
>   mm/rodata_test: use READ_ONCE() to read const variable
>   mm/rodata_test: verify test data is unchanged, rather than non-zero
> 
>  mm/rodata_test.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Nice fixes! Thanks for catching these.

Reviewed-by: Kees Cook <kees@kernel.org>