From patchwork Mon Apr 7 15:11:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Gordeev X-Patchwork-Id: 14041043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3CEC36010 for ; Mon, 7 Apr 2025 15:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79D1D280001; Mon, 7 Apr 2025 11:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72754280003; Mon, 7 Apr 2025 11:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418DE280001; Mon, 7 Apr 2025 11:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 105E8280002 for ; Mon, 7 Apr 2025 11:11:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C8FDE586E0 for ; Mon, 7 Apr 2025 15:11:39 +0000 (UTC) X-FDA: 83307587118.23.1BEE435 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id 7EFF0C0014 for ; Mon, 7 Apr 2025 15:11:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="iGIlK/ui"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744038697; a=rsa-sha256; cv=none; b=tU7G8xbcDkbTQBU0IUDqCrF5PYLdKSsYWzFHVpg8d2Dn+kBf78EHDnCwg3jK39+cN2JUUq yvJ4secL0ovr/PnHUJuq/pWZy2PozpScUNuWDeOeXqgppqT06cOLQiYe93ODsh9kainGp5 tqsJDkwplC/wUCu5gwf7dRwvFjqAYwk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="iGIlK/ui"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744038697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=57tQfDvPr0M3Zui29k18xkGtBTpws7x4blA2kXuxzE8=; b=6Tco+7bllLFi/pb1C731qadhVjnwICqZHJ42kpq2ycxiIvYeyXaN/ZDcFNATIUSM3VWSgx FQ7umSO42wMzMobx07uMUi2RSJPWD1321erQaQnmVkXlV/Q9OUZDiL3yDa/WXhXc0eju6+ 7vx20xjqi7GQc5sEQSTeXTaRU0o2Y+M= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 537A4FUU022813; Mon, 7 Apr 2025 15:11:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=57tQfDvPr0M3Zui29k18xkGtBTpws7x4blA2kXuxz E8=; b=iGIlK/uiqdwuuf9zAUYWVbUStdknMBEmUkgThwL21bB/Sd94w2sdtqjJ6 dJe+6DW30QoIDJsNbKc/dZcuKhjcDWF6ylYzDQJGNnUk0+Ygr+50BWT4LDTxGWqY 8padbZLV871KozFzwN9bOqXMlqjJ7RbObNcLqR3NAQYePc0p6mCr5tM1Z5Odo619 BGJg7HjYIXonr8831xQs777AncSUFfbhV2RPC8LzfnFZQoyNqzoMPy4Ja4Jd8NPr Rxf1l6vOppm1MTueitrL0VGC56TA8UD47RsK6/d0JYqhbNuE0NIwbVM5FbiEmYju AvVYm2qccIa5K0tX1PNa5CBQs1tFw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45v0spm8qr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Apr 2025 15:11:34 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 537EmSRd022056; Mon, 7 Apr 2025 15:11:33 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45v0spm8qm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Apr 2025 15:11:33 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 537BsEeX018863; Mon, 7 Apr 2025 15:11:32 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 45uhj26182-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Apr 2025 15:11:32 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 537FBVvI21823898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Apr 2025 15:11:31 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F08A920043; Mon, 7 Apr 2025 15:11:30 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB1AD20040; Mon, 7 Apr 2025 15:11:30 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 7 Apr 2025 15:11:30 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 7C925E0EFF; Mon, 07 Apr 2025 17:11:30 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton , Andrey Ryabinin Cc: Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: [PATCH v1 0/4] mm: Fix apply_to_pte_range() vs lazy MMU mode Date: Mon, 7 Apr 2025 17:11:26 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: K4njNltb3a39PrtZv2_ODEkMFtlx96GJ X-Proofpoint-ORIG-GUID: HmhRseE7QFEwjmUit74LYcV6TtFzZkug X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-07_04,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 adultscore=0 phishscore=0 priorityscore=1501 spamscore=0 mlxlogscore=625 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504070104 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7EFF0C0014 X-Stat-Signature: pm8rm45unb15pzz44nk7n191n6bhhz83 X-HE-Tag: 1744038697-346425 X-HE-Meta: U2FsdGVkX1+EI+HgVHfL7UMpv1/g4oBFAsTe7oCslEfAyaQlgbiSwXjjmc28+vCgP8rWMo3jQzJLv208zUXX/cP6McMLLxglrihQXxcPSJ5evfzBwYXttFBt1FyaaB6Cd2HpThKAU7L+2xSyWQJZgvub1r+eqFJ9Gen22i7pmmus9IR/H3xB8gsDF6u2fCPLcFpfPrhr/CFgJ1nGtz9HQ4fbmX4ZHcyLJluG7Fyf0JtLhrpbYRJsJ+yrlPk0ZQa8kbvMQI0VZgJv9tyYG5+UcGGVS9URGhsf6P8s0V5qQHLGeTMyqJ1rdbn72Ar7o79qBCuaTuVDVj3aSkN3jVP73hVBGqKHSLD18m3HfVzoPLWdBNwNZ9+tN8lG4CqkLdNztvVM22LTA0bge/c/fBQk8xP5RcUmeEUF5icQ0u1f9SvOa9DoWKBroYrbA9LlFUPhzAmTXgZ5knHNwZeecq6BdkrniFwnmp1bRImhIap2I9jYhNupQJ+lgghuzKUopZsDFD0o9MuyqGFvZgEDqHxMqqs/7tXa/Kxr1kfqUmKRQxGvg/FNIolq/aCkk8aGtnOT5lOSKCyCfk/YwLqhq5qyzLxug6XVUn4gcUsdrR117DiKK4dKIEkhElosJmeJul8TdUMiCMswahpDchhEP9fH7fXpTZS3uVv9hODYU06yaQOqcvJG53SReTGYXv1iPBo6JepgP/vEsTOuchog3KkWUSHORdxIiJ5wvB0x7zJ/68l3FxrnjODAz/M2lxgLSULzIKV4MLtm0UrECnO/jLCVC3INF1fmKaSPO1lz01dPEprIvYe8CAZotcgDUEA/srn6KlGIN+obFLtaEUFkrepGCLnV7p7CqW5wbDjOCxLot4eVHtnSLkqdxECA/N3mngwhivDduf5vULmTo+5CD7fPLD3fBVEh3rORSnYsAtCqBx6RcTlnE4micu9xBAoqWE2/DqGM7DvgHY6fnSIyhml tmkVbgCN mZjhl3FvqQbw9QFG9alofbKOWCbI3HybgLpK966409xn2Pg1M6QziMhhMKo2XdslHQQ6z/LSXYe1dPJ+IVH2JVIZwuVzlyEnjsTKERn+XL/qiw3XyMsHnf8WhFZNx9Pr7UTsEsw5Sj/ivelCONuDvpcXnXHybQoAYIw2HXoalsOgPfWPER4EVwTNVnH/43hH6oh37eIVN4BIl43jvAAob/QwSW4HdBNejC8W/EaBJAMi2z+Tv6kMKBwBCma3lxJDs5GdQCslecWfX3G0KsWiMqUwB08dy5rlaHEeuDmJafNwBt/QMMYxtLHHCC+h7KNn3RpykpNfp3HExgFkjRTp+8bPoLZIzy+Q4NBG+v4B9bgYUGrEupEqpjwHnilxaKZVZGe7Fgbl1xs6ojK1L9s3AlZctY2yWUv+G0HuvxW6yi+/bfAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi All, This series is an attempt to fix the violation of lazy MMU mode context requirement as described for arch_enter_lazy_mmu_mode(): This mode can only be entered and left under the protection of the page table locks for all page tables which may be modified. On s390 if I make arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable() I am getting this: [ 553.332108] preempt_count: 1, expected: 0 [ 553.332117] no locks held by multipathd/2116. [ 553.332128] CPU: 24 PID: 2116 Comm: multipathd Kdump: loaded Tainted: [ 553.332139] Hardware name: IBM 3931 A01 701 (LPAR) [ 553.332146] Call Trace: [ 553.332152] [<00000000158de23a>] dump_stack_lvl+0xfa/0x150 [ 553.332167] [<0000000013e10d12>] __might_resched+0x57a/0x5e8 [ 553.332178] [<00000000144eb6c2>] __alloc_pages+0x2ba/0x7c0 [ 553.332189] [<00000000144d5cdc>] __get_free_pages+0x2c/0x88 [ 553.332198] [<00000000145663f6>] kasan_populate_vmalloc_pte+0x4e/0x110 [ 553.332207] [<000000001447625c>] apply_to_pte_range+0x164/0x3c8 [ 553.332218] [<000000001448125a>] apply_to_pmd_range+0xda/0x318 [ 553.332226] [<000000001448181c>] __apply_to_page_range+0x384/0x768 [ 553.332233] [<0000000014481c28>] apply_to_page_range+0x28/0x38 [ 553.332241] [<00000000145665da>] kasan_populate_vmalloc+0x82/0x98 [ 553.332249] [<00000000144c88d0>] alloc_vmap_area+0x590/0x1c90 [ 553.332257] [<00000000144ca108>] __get_vm_area_node.constprop.0+0x138/0x260 [ 553.332265] [<00000000144d17fc>] __vmalloc_node_range+0x134/0x360 [ 553.332274] [<0000000013d5dbf2>] alloc_thread_stack_node+0x112/0x378 [ 553.332284] [<0000000013d62726>] dup_task_struct+0x66/0x430 [ 553.332293] [<0000000013d63962>] copy_process+0x432/0x4b80 [ 553.332302] [<0000000013d68300>] kernel_clone+0xf0/0x7d0 [ 553.332311] [<0000000013d68bd6>] __do_sys_clone+0xae/0xc8 [ 553.332400] [<0000000013d68dee>] __s390x_sys_clone+0xd6/0x118 [ 553.332410] [<0000000013c9d34c>] do_syscall+0x22c/0x328 [ 553.332419] [<00000000158e7366>] __do_syscall+0xce/0xf0 [ 553.332428] [<0000000015913260>] system_call+0x70/0x98 This exposes a KASAN issue fixed with patch 1 and apply_to_pte_range() issue fixed with patches 2-3. Patch 4 is a debug improvement on top, that could have helped to notice the issue. Commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash lazy mmu mode") looks like powerpc-only fix, yet not entirely conforming to the above provided requirement (page tables itself are still not protected). If I am not mistaken, xen and sparc are alike. Thanks! Alexander Gordeev (4): kasan: Avoid sleepable page allocation from atomic context mm: Cleanup apply_to_pte_range() routine mm: Protect kernel pgtables in apply_to_pte_range() mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context include/linux/pgtable.h | 15 ++++++++++++--- mm/kasan/shadow.c | 9 +++------ mm/memory.c | 33 +++++++++++++++++++++------------ 3 files changed, 36 insertions(+), 21 deletions(-)