From patchwork Mon Feb 6 14:21:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charan Teja Kalla X-Patchwork-Id: 13130020 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A295AC63797 for ; Mon, 6 Feb 2023 14:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 209E66B007B; Mon, 6 Feb 2023 09:22:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 193046B007D; Mon, 6 Feb 2023 09:22:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9586B007E; Mon, 6 Feb 2023 09:22:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D4A076B007B for ; Mon, 6 Feb 2023 09:22:28 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9452BAAA90 for ; Mon, 6 Feb 2023 14:22:28 +0000 (UTC) X-FDA: 80437082376.26.9977146 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf14.hostedemail.com (Postfix) with ESMTP id CB820100002 for ; Mon, 6 Feb 2023 14:22:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=BSXLzf2M; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675693344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8pVCKR95UYar7CDkFZyHmi085Ldot0hMkd4M0rzUh9s=; b=xiWC83Ia9daE8L/7t2TGMOdhMwV5jC2JjhLzOrhctJq3dfpXk62FM8NDnKSiwNLeRyhKB/ QX9H2iXNhFQQWux3viGHJuSfeCsQe9xh6K1/vkJLYUpzMbvXlX3241dq4FmIQsMMYxG+aM PiTF24zbiltwORjrax9Up0ZIouTzwXQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=BSXLzf2M; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675693344; a=rsa-sha256; cv=none; b=283bmdjF32Ldh5PvuNN8VStCcXoKv2Yikjf5A1v7gSVL6x9deKMdZsraTG5CofM/RqR/T5 5J4FkmhvxQ+Lj0uHieN01XJd0MNw/Y8n4+FAziypo/LuWHC1mz3FcEqPUFkazqsPKPg7MS epGgFPxgdt2bftjOQI0eglhqhXgZg7M= Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316BvBrB017808; Mon, 6 Feb 2023 14:22:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=8pVCKR95UYar7CDkFZyHmi085Ldot0hMkd4M0rzUh9s=; b=BSXLzf2MJEhfFTBwlglhkN+7KgrBd8M1M71tZGfTtx+tk0bIyi/34J6TiTA+Yn889+uX XU50OaLB4pTnsedeAEoatuTmEOty/7QRML/jNz1h0ZC5vw7nEzh+ZLZdsXP27Ym1Ytbx Cq3uk4/LYwkxZIEmMTXR0B4G9Ffg24Rg//a8OOv7OuKhfQ4uA4rl9TW/RGYDjvEARqA+ suChMF8yi0P3WJwqjNwUDygH7BvZ60PnxvbErnaAV6gtW71W4GpIjUH/oz52bdHmhNun mgOTHY5dUOgsE2c1GuBLuIg3QRVza7UbHRU00NKyn2rbIjrrmrmDMffsDOGts5GzObCU Hg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nhechbx9m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 14:22:19 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 316EMIw5024912 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 6 Feb 2023 14:22:18 GMT Received: from hu-charante-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 6 Feb 2023 06:22:13 -0800 From: Charan Teja Kalla To: , , , , , , , , , CC: , , Charan Teja Kalla Subject: [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Date: Mon, 6 Feb 2023 19:51:33 +0530 Message-ID: <08e04b5d2fc7a2300a52fb7fff1bc6316a53927c.1675690847.git.quic_charante@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Ig4qu_18s9s2hQE3FBtLNc-Gh_Ighomr X-Proofpoint-ORIG-GUID: Ig4qu_18s9s2hQE3FBtLNc-Gh_Ighomr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060123 X-Rspamd-Queue-Id: CB820100002 X-Stat-Signature: wiap65pa1egr8qucgdw4a4qajmew535i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675693344-964781 X-HE-Meta: U2FsdGVkX18ohYBpO0PedrmMVzr4EBoCFIE1e1n4P8XD2EpKqv8VA2SOrk8JQeQ3G6kxkwLhYJ5JYzN2LP4WLNS1VoxZvcwC9tCeprlNSDDwAlTKYDIfEdvMrOqgEMV7weyZexY9IhXluTuLSA1oVnRwKIUR71umWGwEFj2//mFm3BdfVklyvsfsgs0bO2D6U3W2pZyqVhBQhd34rBf5i/+z0VOE/u1LQjAQr1zREKYFC8LU4KabBED4cWqVwbtnQFN+x72OSbG5wnLfQUF90D1JeZB+GQatWTEhdhHcaBxP16ozehfnAcu8nLY0dmdxIpIQdMrUEU7rs/aXgySTAWazYam5LqYniNzx/DgovwQ+bCIRywHE5gIIbSFwvsCmcYzFRO7XUDGMLkVFLpGHSsnksett24b+gM9c3apfO1whiP5wN9bGwIzAjhnEH73F4aYoGAK5p8U9gnl3M2gi53i3TD760v+qHbMlEJ1Lid2+MHxMU4zQ/wfuEL3B45Qzc1mycyO1X8PCqzsECBzg8llFng7htbXIfu1c2d1g3kM3cj4Wc4/R/qDkB8UoC5qpLCcaBXZDM1PKupkg8wKf40P9WNbSOSzarBzbtfSm76554NsZ9Gm2SSkqsHtqbYi0vJLlPRaqSSkIaaiEGWH3nYpUY2rTH9yrO0hNqQUi4iWZ6tdIaY6nKy6Bk19ZQJn2aAqps29xzQuxGQPDcpfgcc00SsH9O7YFcqVn+qHpduHID02DsNwH9/gDDTEH7a9I6Po+wn7UfYg1Khb6OW6t5EsJVtig1Y3Zh0T6euMDfDhK1aO+gG2XCJ0uyKKDYTSH3UeUHFXmAeZM4KHhxUJzOTRl+Z5xQP9Q+hG0bOHcat3doI+iyHwsf/HnhW7uxPGb+bf518EI8Ks9hv6WzLWUBnGX/81h/cOp1gfZ/Ct58AjMQokbh3h28EctJRUSwrUWc4+tPA8AUCz3siih1Da ZxXae2fs e7ce2iYw0rGo1JaRtZ/qEqk/DNjCKv7AXObDenoQu1vpI5A4UuliAcdaAQfXNOXcn6QhZwKxs9olhPlL2qSVjsFGycMuCM6DKH5NbVcHmK2FDDdD69aOD2WG6241JaMzLQaKz4N2/dE10LdVTjbnqSO7r46AeWn4PfPIK/LRaQeckg08Wdf9l5zQmJOfnCQgNludLdiB6h+HEdb50zh663xmC5OKgTE5gXnGaSzY2Co3dGtogFVRecqg3D0hnFZ8ShoSKMErLacTQ9Uvd/2H6tMhymG3UAiQ15XDf/w4KcUuu6K+mBWnn3PCpffdB+SskMpDC312ceZI72imxPVXkaQ22AWpQvcNNu1xO84wVxMS1J1Bg9hmwMk1fIbzgpwTUSdki33UR0tmlrSjr40Rfedwf6Wg0q+wMcPqTHLtTrPKTCv+rkjC1A73Yhp6y9ENJNQXTqiTMgfmt7nB8i5quPiwKVcZ4r/9IwnBpLFl37JaWqGwnMP8CTjjP+MvF4tc+Vt8rAHpG7+eK201zWoWVk/TCupoM4oFvflR5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently fadvise(2) is supported only for the files that doesn't associated with noop_backing_dev_info thus for the files, like shmem, fadvise results into NOP. But then there is file_operations->fadvise() that lets the file systems to implement their own fadvise implementation. Use this support to implement some of the POSIX_FADV_XXX functionality for shmem files. This patch aims to implement POSIX_FADV_WILLNEED and POSIX_FADV_DONTNEED advices to shmem files which can be helpful for the clients who may want to manage the shmem pages of the files that are created through shmem_file_setup[_with_mnt](). One usecase is implemented on the Snapdragon SoC's running Android where the graphics client is allocating lot of shmem pages per process and pinning them. When this process is put to background, the instantaneous reclaim is performed on those shmem pages using the logic implemented downstream[3][4]. With this patch, the client can now issue the fadvise calls on the shmem files that does the instantaneous reclaim which can aid the use cases like mentioned above. This usecase lead to ~2% reduction in average launch latencies of the apps and 10% in total number of kills by the low memory killer running on Android. Some questions asked while reviewing this patch: Q) Can the same thing be achieved with FD mapped to user and use madvise? A) All drivers are not mapping all the shmem fd's to user space and want to manage them with in the kernel. Ex: shmem memory can be mapped to the other subsystems and they fill in the data and then give it to other subsystem for further processing, where, the user mapping is not at all required. A simple example, memory that is given for gpu subsystem which can be filled directly and give to display subsystem. And the respective drivers know well about when to keep that memory in ram or swap based on may be a user activity. Q) Should we add the documentation section in Manual pages? A) The man[1] pages for the fadvise() whatever says is also applicable for shmem files. so couldn't feel it correct to add specific to shmem files separately. Q) The proposed semantics of POSIX_FADV_DONTNEED is actually similar to MADV_PAGEOUT and different from MADV_DONTNEED. This is a user facing API and this difference will cause confusion? A) man pages [2] says that "POSIX_FADV_DONTNEED attempts to free cached pages associated with the specified region." This means on issuing this FADV, it is expected to free the file cache pages. And it is implementation defined If the dirty pages may be attempted to writeback. And the unwritten dirty pages will not be freed. So, FADV_DONTNEED also covers the semantics of MADV_PAGEOUT for file pages and there is no purpose of PAGEOUT for file pages. [1] https://linux.die.net/man/2/fadvise [2] https://man7.org/linux/man-pages/man2/posix_fadvise.2.html [3] https://git.codelinaro.org/clo/la/platform/vendor/qcom/opensource/graphics-kernel/-/blob/gfx-kernel.lnx.1.0.r3-rel/kgsl_reclaim.c#L289 [4] https://android.googlesource.com/kernel/common/+/refs/heads/android12-5.10/mm/shmem.c#4310 Signed-off-by: Charan Teja Kalla --- mm/shmem.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 0005ab2..58aa3d7 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -39,6 +39,9 @@ #include #include #include +#include +#include +#include #include "swap.h" static struct vfsmount *shm_mnt; @@ -2327,6 +2330,117 @@ static void shmem_set_inode_flags(struct inode *inode, unsigned int fsflags) #define shmem_initxattrs NULL #endif +static void shmem_isolate_pages_range(struct address_space *mapping, loff_t start, + loff_t end, struct list_head *list) +{ + XA_STATE(xas, &mapping->i_pages, start); + struct folio *folio; + + rcu_read_lock(); + xas_for_each(&xas, folio, end) { + if (xas_retry(&xas, folio)) + continue; + if (xa_is_value(folio)) + continue; + + if (!folio_try_get(folio)) + continue; + if (folio_test_unevictable(folio) || folio_mapped(folio) || + folio_isolate_lru(folio)) { + folio_put(folio); + continue; + } + folio_put(folio); + + /* + * Prepare the page to be passed to the reclaim_pages(). + * VM couldn't reclaim the page unless we clear PG_young. + */ + folio_clear_referenced(folio); + folio_test_clear_young(folio); + list_add(&folio->lru, list); + if (need_resched()) { + xas_pause(&xas); + cond_resched_rcu(); + } + } + rcu_read_unlock(); +} + +static int shmem_fadvise_dontneed(struct address_space *mapping, loff_t start, + loff_t end) +{ + LIST_HEAD(folio_list); + + if (!total_swap_pages) + return 0; + + lru_add_drain(); + shmem_isolate_pages_range(mapping, start, end, &folio_list); + reclaim_pages(&folio_list); + + return 0; +} + +static int shmem_fadvise_willneed(struct address_space *mapping, + pgoff_t start, pgoff_t long end) +{ + struct page *page; + pgoff_t index; + + xa_for_each_range(&mapping->i_pages, index, page, start, end) { + if (!xa_is_value(page)) + continue; + page = shmem_read_mapping_page(mapping, index); + if (!IS_ERR(page)) + put_page(page); + } + + return 0; +} + +static int shmem_fadvise(struct file *file, loff_t offset, loff_t len, int advice) +{ + loff_t endbyte; + pgoff_t start_index; + pgoff_t end_index; + struct address_space *mapping; + struct inode *inode = file_inode(file); + int ret = 0; + + if (S_ISFIFO(inode->i_mode)) + return -ESPIPE; + + mapping = file->f_mapping; + if (!mapping || len < 0 || !shmem_mapping(mapping)) + return -EINVAL; + + endbyte = fadvise_calc_endbyte(offset, len); + + start_index = offset >> PAGE_SHIFT; + end_index = endbyte >> PAGE_SHIFT; + switch (advice) { + case POSIX_FADV_DONTNEED: + ret = shmem_fadvise_dontneed(mapping, start_index, end_index); + break; + case POSIX_FADV_WILLNEED: + ret = shmem_fadvise_willneed(mapping, start_index, end_index); + break; + case POSIX_FADV_NORMAL: + case POSIX_FADV_RANDOM: + case POSIX_FADV_SEQUENTIAL: + case POSIX_FADV_NOREUSE: + /* + * No bad return value, but ignore advice. + */ + break; + default: + return -EINVAL; + } + + return ret; +} + static struct inode *shmem_get_inode(struct super_block *sb, struct inode *dir, umode_t mode, dev_t dev, unsigned long flags) { @@ -3933,6 +4047,7 @@ static const struct file_operations shmem_file_operations = { .splice_write = iter_file_splice_write, .fallocate = shmem_fallocate, #endif + .fadvise = shmem_fadvise, }; static const struct inode_operations shmem_inode_operations = {