From patchwork Tue Jun 26 13:15:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 10488907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 734CA60386 for ; Tue, 26 Jun 2018 13:16:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 613EA2893B for ; Tue, 26 Jun 2018 13:16:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 548E32893F; Tue, 26 Jun 2018 13:16:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5D4C2893B for ; Tue, 26 Jun 2018 13:16:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646336B026F; Tue, 26 Jun 2018 09:15:48 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 57A926B0270; Tue, 26 Jun 2018 09:15:48 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444126B0271; Tue, 26 Jun 2018 09:15:48 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id DC2A36B026F for ; Tue, 26 Jun 2018 09:15:47 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id l17-v6so11374889wrm.3 for ; Tue, 26 Jun 2018 06:15:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=fesVdV6LHBRKNYXBdcmV3hEtSKqlEwR3jkeYNaPRqlo=; b=hGj42pDdX35XXgKnT2dA7KX+Q9MlhAxBLtrSk2PlCUxAbI1TEaLZOF8AWVadxkTpYI /bZqoT5sDAPb6hQR270RkpOOiiwikGKHQuPeWBXtzoMmZL676/ziB8J1YFwhx6WutcMq gUTDkK891GJZOMPkO7+CoUgZBTMYs06+H0llmgqljYSrVRTolLJQy2+DQYwm3O0YBS5W fL1c2YzaLVq3Y3sNhDdNGqutLo/JFJHf15MOra2GbR9ir89ySfpTnn5RXB6VMlmGyP/o g+C4D7T+N4VHmw7BCYrKmmTE5A0uiFvQ/XtM8pKSlDq2Ww07sB6Rq7C7S9DwqDNGBXgv BUSQ== X-Gm-Message-State: APt69E1CQFfIap38sYOWOkdcUIWagaxB8IAHQ6zFvNoqZBVf8cIRrj3w sIrpsJPbsqISPr/7SZllFUp/BarPPLr3YmRzONi5QKVT/SZgFIcHs3Tg/Wm3A8vE+TJIy1uvSW+ ZOAl41UktwDVAqeyA5ev7znVqenftXAUmZq49znH6RfXyZ0ltWpmGkbnq+RkDjYJEy0aPDbEzhz VYH2sE5AdXOSSl/v3RjfbdQkHNwpLM09UrkCzNpE0qrN89dGKbIUioZ6D0eLvNnI7EodK/Pelb2 z8OSaZS6gBnForuwabWbrIQZwQeODaiw8IL2l4Wukwb60YOXz2/YTgEKT1Jx5dlf4qyOzdq6qaP oWpN03gdpJ3Oak+wnPURJObdHmMBf93UxxVEy7U34hFCQZ590G/esfiTmwrl7CFIm0qQHYIKq2U i X-Received: by 2002:a1c:9d49:: with SMTP id g70-v6mr1674520wme.134.1530018947427; Tue, 26 Jun 2018 06:15:47 -0700 (PDT) X-Received: by 2002:a1c:9d49:: with SMTP id g70-v6mr1674472wme.134.1530018946522; Tue, 26 Jun 2018 06:15:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530018946; cv=none; d=google.com; s=arc-20160816; b=t9b5tRxAIlwqQtw1hhoV5sHhX+9SnGQJHITOuPqO2LLoCSr5mxMD90Z5w4XzbumSsI iJ0E+a367Rm0UC20gnWuCdwYCnF8gGXAquW39liZWnTVkRRx64YHZfltF7IUpkiYqmOi zKT4i56QM/460iqOvBWkTzU+ht2bX/gERfuafPNzNH9QwpXNxCyCKJqZxY5YhXkqrPVC crsYG2zPJ+NhGB5u/9Hu1e73CjT40js5r82g74KUSmCwee62Z60e7bpOrIq5yJxBTeED I6K/hKHRzHmtgI0+JaoqcuHoAH7dciBEXStmczcUzyoDnlo/b2cSH/EgB74Gce+m32xQ 4Drg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=fesVdV6LHBRKNYXBdcmV3hEtSKqlEwR3jkeYNaPRqlo=; b=TSoEKYWc5g5q5M9f/DoC+SMcqys5dGi7X2h8eXZzn8uN96A/8dpVB5buJ2p+sDYSe5 D6IVxnn9E/GNLoqmLaw12Bhpuoonwqp2t0q4HW9E3ZcsSgvXy/P7mDTJJs6yR9YRRia2 3yPuuH2f3wOEZae3EEIv45prjvuwvYpPl0BzmzXJ3sE8kFyjNdkz8tXq9BZxKQ4Ayxdu o9t+ghGKfOr+7lYrlQCrm9gFKSzt6Q+RuVUBBHQKZfN3uyaLdjTuoCwo9Yif8K6TE3Uv iqlu2QZwSwUEflxPP4miGFKGEyj+NZst2iVksSTTrA6low1Wlfd2TCeIj4WcMVhIL2QN pNpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aUpOkcHC; spf=pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreyknvl@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id z16-v6sor782744wrl.36.2018.06.26.06.15.46 for (Google Transport Security); Tue, 26 Jun 2018 06:15:46 -0700 (PDT) Received-SPF: pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aUpOkcHC; spf=pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreyknvl@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fesVdV6LHBRKNYXBdcmV3hEtSKqlEwR3jkeYNaPRqlo=; b=aUpOkcHC77zwPdvoyCQWtOFI+/au+FXWE52sbYSgk55WFZZJey0GTTHuKlizoKzXeQ aP/dBwRPsy4C/094DdAhIqj0xjNqS00ncYdzLTD9q89aCxs8ifz1U+R7zJRpZJ6QVZuL yBci2MkmwKvNOE4VQKRiG4K98ib3Qb/piWGQzB6OWyTn0fHUl9X+n2tG5HSF4lbmnslB eg/meZ77q//+1bQ22jFd1ecR4XRGxFm5X06IXQdRm2ZlPtUlSLdtHN5mdFibsO2zCGdt pPFG8p1lKJtytCwX6u7AeC7WNInj90vgSHzo8M/97SGtY+9HUDEUE78z7oUmxv88cirE Jl0w== X-Google-Smtp-Source: AAOMgpftwzrXVmZLeNoHXgsYfWg8uDR2FTtM+E+3Y3BKpb9eMVhCZovEfRNDcfa5ONzdpycmM2ScgQ== X-Received: by 2002:adf:9063:: with SMTP id h90-v6mr1519403wrh.147.1530018945895; Tue, 26 Jun 2018 06:15:45 -0700 (PDT) Received: from andreyknvl0.muc.corp.google.com ([2a00:79e0:15:10:84be:a42a:826d:c530]) by smtp.gmail.com with ESMTPSA id w15-v6sm2162639wrn.25.2018.06.26.06.15.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jun 2018 06:15:44 -0700 (PDT) From: Andrey Konovalov To: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Catalin Marinas , Will Deacon , Christoph Lameter , Andrew Morton , Mark Rutland , Nick Desaulniers , Marc Zyngier , Dave Martin , Ard Biesheuvel , "Eric W . Biederman" , Ingo Molnar , Paul Lawrence , Geert Uytterhoeven , Arnd Bergmann , "Kirill A . Shutemov" , Greg Kroah-Hartman , Kate Stewart , Mike Rapoport , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sparse@vger.kernel.org, linux-mm@kvack.org, linux-kbuild@vger.kernel.org Cc: Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Jann Horn , Mark Brand , Chintan Pandya , Andrey Konovalov Subject: [PATCH v4 07/17] khwasan: add tag related helper functions Date: Tue, 26 Jun 2018 15:15:17 +0200 Message-Id: <0aaff2112647cc4b3aaa1a2be127285dcb5af2c5.1530018818.git.andreyknvl@google.com> X-Mailer: git-send-email 2.18.0.rc2.346.g013aa6912e-goog In-Reply-To: References: MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This commit adds a few helper functions, that are meant to be used to work with tags embedded in the top byte of kernel pointers: to set, to get or to reset (set to 0xff) the top byte. Signed-off-by: Andrey Konovalov --- arch/arm64/mm/kasan_init.c | 2 ++ include/linux/kasan.h | 23 ++++++++++++++++ mm/kasan/kasan.h | 55 ++++++++++++++++++++++++++++++++++++++ mm/kasan/khwasan.c | 47 ++++++++++++++++++++++++++++++++ 4 files changed, 127 insertions(+) diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c index 7a31e8ccbad2..e7f37c0b7e14 100644 --- a/arch/arm64/mm/kasan_init.c +++ b/arch/arm64/mm/kasan_init.c @@ -250,6 +250,8 @@ void __init kasan_init(void) memset(kasan_zero_page, KASAN_SHADOW_INIT, PAGE_SIZE); cpu_replace_ttbr1(lm_alias(swapper_pg_dir)); + khwasan_init(); + /* At this point kasan is fully initialized. Enable error messages */ init_task.kasan_depth = 0; pr_info("KernelAddressSanitizer initialized\n"); diff --git a/include/linux/kasan.h b/include/linux/kasan.h index 336385baf926..d7624b879d86 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -155,6 +155,29 @@ static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} #define KASAN_SHADOW_INIT 0xFF +void khwasan_init(void); + +void *khwasan_set_tag(const void *addr, u8 tag); +u8 khwasan_get_tag(const void *addr); +void *khwasan_reset_tag(const void *ptr); + +#else /* CONFIG_KASAN_HW */ + +static inline void khwasan_init(void) { } + +static inline void *khwasan_set_tag(const void *addr, u8 tag) +{ + return (void *)addr; +} +static inline u8 khwasan_get_tag(const void *addr) +{ + return 0xFF; +} +static inline void *khwasan_reset_tag(const void *ptr) +{ + return (void *)ptr; +} + #endif /* CONFIG_KASAN_HW */ #endif /* LINUX_KASAN_H */ diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index 19b950eaccff..a7cc27d96608 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -8,6 +8,10 @@ #define KASAN_SHADOW_SCALE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) #define KASAN_SHADOW_MASK (KASAN_SHADOW_SCALE_SIZE - 1) +#define KHWASAN_TAG_KERNEL 0xFF /* native kernel pointers tag */ +#define KHWASAN_TAG_INVALID 0xFE /* inaccessible memory tag */ +#define KHWASAN_TAG_MAX 0xFD /* maximum value for random tags */ + #define KASAN_FREE_PAGE 0xFF /* page was freed */ #define KASAN_PAGE_REDZONE 0xFE /* redzone for kmalloc_large allocations */ #define KASAN_KMALLOC_REDZONE 0xFC /* redzone inside slub object */ @@ -126,6 +130,57 @@ static inline void quarantine_reduce(void) { } static inline void quarantine_remove_cache(struct kmem_cache *cache) { } #endif +#ifdef CONFIG_KASAN_HW + +#define KHWASAN_TAG_SHIFT 56 +#define KHWASAN_TAG_MASK (0xFFUL << KHWASAN_TAG_SHIFT) + +u8 random_tag(void); + +static inline void *set_tag(const void *addr, u8 tag) +{ + u64 a = (u64)addr; + + a &= ~KHWASAN_TAG_MASK; + a |= ((u64)tag << KHWASAN_TAG_SHIFT); + + return (void *)a; +} + +static inline u8 get_tag(const void *addr) +{ + return (u8)((u64)addr >> KHWASAN_TAG_SHIFT); +} + +static inline void *reset_tag(const void *addr) +{ + return set_tag(addr, KHWASAN_TAG_KERNEL); +} + +#else /* CONFIG_KASAN_HW */ + +static inline u8 random_tag(void) +{ + return 0; +} + +static inline void *set_tag(const void *addr, u8 tag) +{ + return (void *)addr; +} + +static inline u8 get_tag(const void *addr) +{ + return 0; +} + +static inline void *reset_tag(const void *addr) +{ + return (void *)addr; +} + +#endif /* CONFIG_KASAN_HW */ + /* * Exported functions for interfaces called from assembly or from generated * code. Declarations here to avoid warning about missing declarations. diff --git a/mm/kasan/khwasan.c b/mm/kasan/khwasan.c index e2c3a7f7fd1f..d34679b8f8c7 100644 --- a/mm/kasan/khwasan.c +++ b/mm/kasan/khwasan.c @@ -38,6 +38,53 @@ #include "kasan.h" #include "../slab.h" +static DEFINE_PER_CPU(u32, prng_state); + +void khwasan_init(void) +{ + int cpu; + + for_each_possible_cpu(cpu) + per_cpu(prng_state, cpu) = get_random_u32(); +} + +/* + * If a preemption happens between this_cpu_read and this_cpu_write, the only + * side effect is that we'll give a few allocated in different contexts objects + * the same tag. Since KHWASAN is meant to be used a probabilistic bug-detection + * debug feature, this doesn’t have significant negative impact. + * + * Ideally the tags use strong randomness to prevent any attempts to predict + * them during explicit exploit attempts. But strong randomness is expensive, + * and we did an intentional trade-off to use a PRNG. This non-atomic RMW + * sequence has in fact positive effect, since interrupts that randomly skew + * PRNG at unpredictable points do only good. + */ +u8 random_tag(void) +{ + u32 state = this_cpu_read(prng_state); + + state = 1664525 * state + 1013904223; + this_cpu_write(prng_state, state); + + return (u8)(state % (KHWASAN_TAG_MAX + 1)); +} + +void *khwasan_set_tag(const void *addr, u8 tag) +{ + return set_tag(addr, tag); +} + +u8 khwasan_get_tag(const void *addr) +{ + return get_tag(addr); +} + +void *khwasan_reset_tag(const void *addr) +{ + return reset_tag(addr); +} + void check_memory_region(unsigned long addr, size_t size, bool write, unsigned long ret_ip) {