| Message ID | 11d1f8fc954a83945930a5b11f47e00c063bdc1b.1628174413.git.baolin.wang@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanup for page migration | expand |
On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang <baolin.wang@linux.alibaba.com> wrote: > > Change to use bool type for 'page_was_mapped' variable making it > more readable. Seems better to me. Reviewed-by: Yang Shi <shy828301@gmail.com> > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> > --- > mm/migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 6f048a8..0ab364f 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -957,7 +957,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > int force, enum migrate_mode mode) > { > int rc = -EAGAIN; > - int page_was_mapped = 0; > + bool page_was_mapped = false; > struct anon_vma *anon_vma = NULL; > bool is_lru = !__PageMovable(page); > > @@ -1060,7 +1060,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > VM_BUG_ON_PAGE(PageAnon(page) && !PageKsm(page) && !anon_vma, > page); > try_to_migrate(page, 0); > - page_was_mapped = 1; > + page_was_mapped = true; > } > > if (!page_mapped(page)) > -- > 1.8.3.1 > >
diff --git a/mm/migrate.c b/mm/migrate.c index 6f048a8..0ab364f 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -957,7 +957,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, int force, enum migrate_mode mode) { int rc = -EAGAIN; - int page_was_mapped = 0; + bool page_was_mapped = false; struct anon_vma *anon_vma = NULL; bool is_lru = !__PageMovable(page); @@ -1060,7 +1060,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, VM_BUG_ON_PAGE(PageAnon(page) && !PageKsm(page) && !anon_vma, page); try_to_migrate(page, 0); - page_was_mapped = 1; + page_was_mapped = true; } if (!page_mapped(page))
Change to use bool type for 'page_was_mapped' variable making it more readable. Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> --- mm/migrate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)