From patchwork Mon May 21 22:35:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10417023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F423600CC for ; Mon, 21 May 2018 22:45:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D5C128AB7 for ; Mon, 21 May 2018 22:45:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1239028AD0; Mon, 21 May 2018 22:45:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9FEB228AB7 for ; Mon, 21 May 2018 22:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6779B6B000A; Mon, 21 May 2018 18:45:39 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6008F6B000C; Mon, 21 May 2018 18:45:39 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A42B6B000D; Mon, 21 May 2018 18:45:39 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f70.google.com (mail-pl0-f70.google.com [209.85.160.70]) by kanga.kvack.org (Postfix) with ESMTP id 0889C6B000A for ; Mon, 21 May 2018 18:45:39 -0400 (EDT) Received: by mail-pl0-f70.google.com with SMTP id e1-v6so9351810pld.23 for ; Mon, 21 May 2018 15:45:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:from :to:cc:date:message-id:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=I/HTIamXSHT48zkSjDpQQcJguPFq5a5gmXiSIMaU8No=; b=JXvAsCO7Z8+MGmoLSC97xxFOlPa/XWPQqP+5QpaB+zlAaxTMEDOErTKXbD1R1gxojZ mBrhB4SaqrPWkvjYybFjmIJxxZKAhCQpN3e76CwT4yLVg4s0BWXTS/wNizb0n178o/a8 3fpFzJ8oBbo5801hFA/uV+rdL4dhNFSPNgV4k84nxDj/DxGjlJTlMB59J/t/Mu56fyXl kn9BbDePHXoyK+qgdN8ug+BKeZbgjyIbNPSYviBPyGQ12PpETLZNN50BvA1SkVoh7gHG wu65Ph9+tIsIeQ/ZiJpOfJ8De0eiFiRmUWHXgGREBJzBsrQ2GdYOS70pa9+Ptj3V0gFU fc5g== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: ALKqPwf1toEK917P62QgjLD7lTPvlrxS8UHSMVsBy/qNRxSnHquoZo3V Rv+aYaHJx+PPTzzpIHSR1XXgSKxHY56TklQDc2c2pxawCXpPT0i8Pbk2xEcT5w1ZAbu8ULck5mE U7DP6/Srmo42JvQkQvISVcKWv8YUdjazoPs9ohgi4e77qvClROa2uiGxljLvYKZBTxA== X-Received: by 2002:a63:61c8:: with SMTP id v191-v6mr17160211pgb.184.1526942738709; Mon, 21 May 2018 15:45:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp9mCohPNYrARch84/v+2WrUQzQCoSXKo5wme5KN+mI5Blb9D4ocUSsVmqk+9+8VVGdTaul X-Received: by 2002:a63:61c8:: with SMTP id v191-v6mr17160188pgb.184.1526942737936; Mon, 21 May 2018 15:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526942737; cv=none; d=google.com; s=arc-20160816; b=oNr0oy0QiU1jzCbB1iT8D2RXIpRrZ1+a7ZOX/dmhFkWMlmJry3ZgIqNTC0YIOlGjGw o07IHNcaufSwCNKiM9hJZ1X0KLPv335dUI3/znoxQsGn94hXye4g8EnobXHY8z3TQ/2w nZfOWuOj8303KtvKoRjRHh+dV3ydfuQMcCRqM2ZoBFA7NNg1d15WoYcWP0XD/gUVxtpi QF6gTghlIMVh80rBbNiCZ4SKQ7BCJee98voxbs/rqd2+aWXgZmsRtuPGRchxvjJhJnIR RnsviHeMivFja9IEz7+eNOJcm40BCP6otg11T7ePUie7vtOLc/WBSXv+7DvWpgorDHWC TRpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject :arc-authentication-results; bh=I/HTIamXSHT48zkSjDpQQcJguPFq5a5gmXiSIMaU8No=; b=LGiBBJ8fbYSbtk240U6ofrdKcnhZhWrRgzZQAvlVkvPNldbTgD633dCKN7Y3lY+oYj M5VQLMTwTXSPsVrNZBuo5ik/GAnASOtVymBy3l/JD2A00IaoJO2MiZjmLafeRFI8+J1C LZnXabU56mX1dKa32XQNCuTgZtquEe6rWvj7+chA0JEoXC77vMTpwZsl61gFHlXTOnfD UaOlkopmD4jkG26KHw1ec6dEDGwcoxnxfU10yv8UtM7dp+nT2PrRvA8Ryig0WTJTNpfq z9jjS6YltbJx8s7kPEL/cMuKB2VJehEbo2bUz6NAgn9Sg0gGX4TE+x1BXN77hzAd/+ar DwBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga12.intel.com (mga12.intel.com. [192.55.52.136]) by mx.google.com with ESMTPS id f3-v6si15343939plf.436.2018.05.21.15.45.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 15:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) client-ip=192.55.52.136; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 15:45:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,427,1520924400"; d="scan'208";a="48696924" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by fmsmga002.fm.intel.com with ESMTP; 21 May 2018 15:45:37 -0700 Subject: [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL From: Dan Williams To: akpm@linux-foundation.org Cc: Christoph Hellwig , =?utf-8?b?SsOpcsO0bWU=?= Glisse , Logan Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Mon, 21 May 2018 15:35:40 -0700 Message-ID: <152694214044.5484.1081005408496303826.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <152694211402.5484.2277538346144115181.stgit@dwillia2-desk3.amr.corp.intel.com> References: <152694211402.5484.2277538346144115181.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The routines hmm_devmem_add(), and hmm_devmem_add_resource() are small wrappers around devm_memremap_pages(). The devm_memremap_pages() interface is a subset of the hmm functionality which has more and deeper ties into the kernel memory management implementation. It was an oversight that these symbols were not marked EXPORT_SYMBOL_GPL from the outset due to how they originally copied (and now reuse) devm_memremap_pages(). Cc: Christoph Hellwig Cc: "Jérôme Glisse" Cc: Logan Gunthorpe Signed-off-by: Dan Williams Reviewed-by: Christoph Hellwig --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index a4162406067c..d9aef1266ed6 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1072,7 +1072,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1131,7 +1131,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a