From patchwork Tue May 29 04:01:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10434309 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7F9AA602BF for ; Tue, 29 May 2018 04:01:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61C9D285C3 for ; Tue, 29 May 2018 04:01:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52A5F285BE; Tue, 29 May 2018 04:01:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29CA2285BE for ; Tue, 29 May 2018 04:01:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 771E26B0003; Tue, 29 May 2018 00:01:49 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7217A6B0006; Tue, 29 May 2018 00:01:49 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613A66B0007; Tue, 29 May 2018 00:01:49 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id 385BC6B0003 for ; Tue, 29 May 2018 00:01:49 -0400 (EDT) Received: by mail-qk0-f199.google.com with SMTP id f207-v6so6874449qke.22 for ; Mon, 28 May 2018 21:01:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:dkim-signature:message-id:subject :from:to:cc:date:in-reply-to:references:mime-version :content-transfer-encoding; bh=BP39hfAMrprKkc6gRnLiUtmpwBZxuRGMXZSW4HkPJ94=; b=kwbm+rG/kvxR2G22EreEF7DIns42ZYh1EpkWC3Qb/b+HAgNJlPxPAklbMYRkcguyzD Bbe4uJB+3QX8MnYLK2sM5RQcVTEZxOiKmgbeL5M1I8bg81Y9NpQjttY6AUhLtGxdFLY8 LBc1pB0jAqZACkg6wZNAKIi9qZFEcdWuG1AcWcruoqwG2JGL/HuvvP+ijgFzciIG84vW 7TBJWP+DM9wp6+2XwGJ2sFemT5DDvxU1hW1J+Uu4kZJx0dWhoYdA0lhvAHIoMrkjNQAo I7pw7hCmqt3HUS8kHdWgXjEcmb56boBc67pU30PtmN3ttMyRFpt5nuCgZFkq9v9oGtXd hlAA== X-Gm-Message-State: ALKqPwdqzQ2SomrW8KV9h6RLkl8F4EdbiEvc8cEnjxy+TeIU9ZTGsufp YQe7IlYKa0RQlndj3lVYnCNnWyGo6EScvgwrJTQjSFdVH06ycGitmX/p30Eu6lKxNrBIa3zsmSE jxYGvFF13usFbfaOMUEeGHJgwSKn1nrfOZSxx6nKFOnuFWQ9qG18H+LIYaub3rzsX7A== X-Received: by 2002:a37:8542:: with SMTP id h63-v6mr13169770qkd.342.1527566508841; Mon, 28 May 2018 21:01:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLOwwYNvRmZiGWPg6ibXK5qEiKyjmRkgeax5etc4pZzUBxWYWoST7TTaidOUgUpJ6+oUHPE X-Received: by 2002:a37:8542:: with SMTP id h63-v6mr13169736qkd.342.1527566507925; Mon, 28 May 2018 21:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527566507; cv=none; d=google.com; s=arc-20160816; b=aa9L0nce/atbF6Hek3IkNVVwZxLyOKBzPsU78bBdXEIZ8U0cNCFEGE0W7tCv5u0N1T csP1NzYV69Zc3fN1M8fC/Q/GNdcAPe0M0zr34KxC+dXkSIAIW+Ka6aWNCEIkzTVwR3zO NFjYPgpHhe0YjJTvVrArfI5kXvtASWyYahdzKcZFIdm+hT1O1aAsxKAh6/rRRJZjriFd iOx6Uv2lULtKRHdVwRJcnncvAwYdJGrLn+fRiqP3uk82hkRBX9g1+kt/KpchtgnTuD4v elrfQmWOke9QLx/sBdPnzP0LLeM6ikFUrQT52HQrYG2W49+IHf05x2MdZG4jUjk6DK1q vSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:dkim-signature:dkim-signature :arc-authentication-results; bh=BP39hfAMrprKkc6gRnLiUtmpwBZxuRGMXZSW4HkPJ94=; b=AsqDjnfd1OCBWHnvnRVOMzJkB6RAohDEW/7MiuoBOFS14fC7REbGn/QS5jm6NTAVef N0Cg06Usn0i1iOHwA2fPwlSq0SqsowFVIr7Nu3FYD0bCVs7mWeA3yxJtW94kRSpN2sRy uQNM7MPsCWSNmS09juIav1s71MIyVvd+1ej+BOl9i8nLdmB1CERyOjzJy9kJrKYHeg9K LB+mqdGQaT4fTy73zwXD7vPy2zmIHPYHktYjRkO7QGJeHcXg7JzhIaZzOGz84zybbXOb Ayr27KkWMDRw4wTaMUeoiXeGaxyJGULJfVR83GQ2Fe2/5GJiSlLStkSI1IrOgrqPKnby mprg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@themaw.net header.s=fm3 header.b=pWcEgFXH; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=enJA9ATV; spf=neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) smtp.mailfrom=raven@themaw.net Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com. [66.111.4.25]) by mx.google.com with ESMTPS id w36-v6si13788030qtb.19.2018.05.28.21.01.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 May 2018 21:01:47 -0700 (PDT) Received-SPF: neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) client-ip=66.111.4.25; Authentication-Results: mx.google.com; dkim=pass header.i=@themaw.net header.s=fm3 header.b=pWcEgFXH; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=enJA9ATV; spf=neutral (google.com: 66.111.4.25 is neither permitted nor denied by best guess record for domain of raven@themaw.net) smtp.mailfrom=raven@themaw.net Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5ADB520D56; Tue, 29 May 2018 00:01:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 29 May 2018 00:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=BP39hfAMrprKkc6gRnLiUtmpwBZxu RGMXZSW4HkPJ94=; b=pWcEgFXHyBcSlskCMjM4v9fYsu3A2Y/Jo0byRXjfSkiRe vALlRkQCGGOTZ56aG7vHbz/TB9wcjTDfdonDg68yAhVhNW+4N4Cq44u8LzoM+D/Y n/qifxDRixJkQ9wjKFH5KK66r4+zBp1kJgSI6UFAHIiA8fwmMipmuYWaED0Oa00X PDdsiYKmBO5UNViF0o/0Km06scVQxuXgmyMMrlgLfMFTSWPQ9OPXlIjmcu7py5H2 fEkC0j0rfut67PxJnFzBz4ks329VdxcjDbthFocnqaiXDvL19YfX6GVkhgTUua8/ AIMMDKQmcL8nHgJVmwSweCyqx9RyH+UJV0ylxOifA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BP39hf AMrprKkc6gRnLiUtmpwBZxuRGMXZSW4HkPJ94=; b=enJA9ATVuqTj9fdu/45AYg unzTZDC1lMDjcBIel/vDYIebIbHxH8wN0TBF0E2SX0hyQF3W2cvFEWMvfgyjsXTF 784ogjUuwTnnAcMpK5z+cAL8cFFpx/z5yh9XWguG3ilDklktcQPsdmTzis2UAffN A6OX/0GCkcviealBy4tamc6zXYVkP6WomQ2IOmno8BbsIEnUzYN5V58R4i937Iao Tf/bWIIz/uFSKOkwhcPUvSl7Ii2RXOmeaF4ock+k6F5eqNNNOYCLh4W3Xsdfp6s6 VHyUxsKlcoMsF11VF9ntAN73I8O86TXDuDbc46bMM6TTON7dHQ5b8sfJwuNX5omg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from localhost (unknown [118.209.33.215]) by mail.messagingengine.com (Postfix) with ESMTPA id EA0D7102DA; Tue, 29 May 2018 00:01:43 -0400 (EDT) Message-ID: <1527566501.2723.22.camel@themaw.net> Subject: Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix From: Ian Kent To: Andrew Morton Cc: Andrey Ryabinin , Paul Menzel , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Date: Tue, 29 May 2018 12:01:41 +0800 In-Reply-To: <1527482351.2693.12.camel@themaw.net> References: <201805261122.HdUpobQm%fengguang.wu@intel.com> <20180525204804.3a655370ef4b41e0d96e03f3@linux-foundation.org> <1527480795.2693.4.camel@themaw.net> <1527482351.2693.12.camel@themaw.net> X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2018-05-28 at 12:39 +0800, Ian Kent wrote: > On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot > > > wrote: > > > > > > > Hi Andrey, > > > > > > > > I love your patch! Yet something to improve: > > > > > > > > [auto build test ERROR on mmotm/master] > > > > [cannot apply to v4.17-rc6] > > > > [if your patch is applied to the wrong git tree, please drop us a note > > > > to > > > > help improve the system] > > > > > > > > url: https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/mm-kasa > > > > n- > > > > do > > > > nt-vfree-nonexistent-vm_area-fix/20180526-093255 > > > > base: git://git.cmpxchg.org/linux-mmotm.git master > > > > config: sparc-allyesconfig (attached as .config) > > > > compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > > > > reproduce: > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sb > > > > in > > > > /m > > > > ake.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # save the attached .config to linux build tree > > > > make.cross ARCH=sparc > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > fs/autofs/inode.o: In function `autofs_new_ino': > > > > inode.c:(.text+0x220): multiple definition of `autofs_new_ino' > > > > fs/autofs/inode.o:inode.c:(.text+0x220): first defined here > > > > fs/autofs/inode.o: In function `autofs_clean_ino': > > > > inode.c:(.text+0x280): multiple definition of `autofs_clean_ino' > > > > fs/autofs/inode.o:inode.c:(.text+0x280): first defined here > > > > > > There's bot breakage here - clearly that patch didn't cause this error. > > > > > > Ian, this autofs glitch may still not be fixed. > > > > Yes, autofs-make-autofs4-Kconfig-depend-on-AUTOFS_FS.patch should have > > fixed that. > > > > I tied a bunch of .config combinations and I was unable to find any that > > lead to both CONFIG_AUTOFS_FS and CONFIG_AUTOFS4_FS being defined. > > Oh, autofs-make-autofs4-Kconfig-depend-on-AUTOFS_FS.patch was sent as > a follow up patch which means it's still possible to have both > CONFIG_AUTOFS_FS and CONFIG_AUTOFS4_FS set between > autofs-create-autofs-Kconfig-and-Makefile.patch and the above patch. > > Perhaps all that's needed is to fold the follow up patch into > autofs-create-autofs-Kconfig-and-Makefile.patch to close that > possibility. > > I'll check that can be done without problem. I've had a look and I can't see any reason for this other than CONFIG_AUTOFS_FS and CONFIG_AUTOFS4_FS both being set which isn't ok because the file system name is the same for both. I have seen build system configs that have both of these set even though the "autofs" module was removed years ago so that's probably still present in some site build systems. I see you've added the follow up patch I mentioned above as "autofs-update-fs-autofs4-kconfig-fix.patch" with title "autofs - make autofs4 Kconfig depend on AUTOFS_FS" Folding this patch into the patch "autofs-create-autofs-kconfig-and-makefile.patch" with title "autofs: create autofs Kconfig and Makefile" I'm unable to reproduce the breakage which leads me to think the problem must be due to .config having both the CONFIG_AUTOFS* entries defined to something other than n (which certainly does produce the breakage if the follow up patch is not present, so the result is not bisectable until the follow up patch is added). Also, I don't think there is a need to update the description of "autofs: create autofs Kconfig and Makefile" because the patch that is folded into it adds a NOTE to the fs/autofs4/Kconfig help that essentially re-states what is in the description. If this continues to happen I'll need more information about applied patches and kernel config used to work out what's going on. For completeness here's the resulting patch after folding in the follow up patch above: autofs - create autofs Kconfig and Makefile From: Ian Kent Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent --- fs/Kconfig | 1 + fs/Makefile | 1 + fs/autofs/Kconfig | 20 ++++++++++++++++++++ fs/autofs/Makefile | 7 +++++++ fs/autofs4/Kconfig | 8 ++++++++ 5 files changed, 37 insertions(+) create mode 100644 fs/autofs/Kconfig create mode 100644 fs/autofs/Makefile diff --git a/fs/Kconfig b/fs/Kconfig index bc821a86d965..e712e62afe59 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -108,6 +108,7 @@ source "fs/notify/Kconfig" source "fs/quota/Kconfig" +source "fs/autofs/Kconfig" source "fs/autofs4/Kconfig" source "fs/fuse/Kconfig" source "fs/overlayfs/Kconfig" diff --git a/fs/Makefile b/fs/Makefile index c9375fd2c8c4..2e005525cc19 100644 --- a/fs/Makefile +++ b/fs/Makefile @@ -102,6 +102,7 @@ obj-$(CONFIG_AFFS_FS) += affs/ obj-$(CONFIG_ROMFS_FS) += romfs/ obj-$(CONFIG_QNX4FS_FS) += qnx4/ obj-$(CONFIG_QNX6FS_FS) += qnx6/ +obj-$(CONFIG_AUTOFS_FS) += autofs/ obj-$(CONFIG_AUTOFS4_FS) += autofs4/ obj-$(CONFIG_ADFS_FS) += adfs/ obj-$(CONFIG_FUSE_FS) += fuse/ diff --git a/fs/autofs/Kconfig b/fs/autofs/Kconfig new file mode 100644 index 000000000000..6a2064eb3b27 --- /dev/null +++ b/fs/autofs/Kconfig @@ -0,0 +1,20 @@ +config AUTOFS_FS + tristate "Kernel automounter support (supports v3, v4 and v5)" + default n + help + The automounter is a tool to automatically mount remote file systems + on demand. This implementation is partially kernel-based to reduce + overhead in the already-mounted case; this is unlike the BSD + automounter (amd), which is a pure user space daemon. + + To use the automounter you need the user-space tools from + ; you also want + to answer Y to "NFS file system support", below. + + To compile this support as a module, choose M here: the module will be + called autofs. + + If you are not a part of a fairly large, distributed network or + don't have a laptop which needs to dynamically reconfigure to the + local network, you probably do not need an automounter, and can say + N here. diff --git a/fs/autofs/Makefile b/fs/autofs/Makefile new file mode 100644 index 000000000000..43fedde15c26 --- /dev/null +++ b/fs/autofs/Makefile @@ -0,0 +1,7 @@ +# +# Makefile for the linux autofs-filesystem routines. +# + +obj-$(CONFIG_AUTOFS_FS) += autofs.o + +autofs-objs := init.o inode.o root.o symlink.o waitq.o expire.o dev-ioctl.o diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 53bc592a250d..2c2fdf989f90 100644 --- a/fs/autofs4/Kconfig +++ b/fs/autofs4/Kconfig @@ -1,6 +1,7 @@ config AUTOFS4_FS tristate "Kernel automounter version 4 support (also supports v3 and v5)" default n + depends on AUTOFS_FS = n help The automounter is a tool to automatically mount remote file systems on demand. This implementation is partially kernel-based to reduce @@ -30,3 +31,10 @@ config AUTOFS4_FS - any "alias autofs autofs4" will need to be removed. Please configure AUTOFS_FS instead of AUTOFS4_FS from now on. + + NOTE: Since the modules autofs and autofs4 use the same file system + type name of "autofs" only one can be built. The "depends" + above will result in AUTOFS4_FS not appearing in .config for + any setting of AUTOFS_FS other than n and AUTOFS4_FS will + appear under the AUTOFS_FS entry otherwise which is intended + to draw attention to the module rename change.