From patchwork Tue Aug 7 10:24:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 10558491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4DD3B14E2 for ; Tue, 7 Aug 2018 10:24:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38E59287D1 for ; Tue, 7 Aug 2018 10:24:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A379295FC; Tue, 7 Aug 2018 10:24:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B787F287D1 for ; Tue, 7 Aug 2018 10:24:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893696B0005; Tue, 7 Aug 2018 06:24:37 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 86CD16B000D; Tue, 7 Aug 2018 06:24:37 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DFBE6B000E; Tue, 7 Aug 2018 06:24:37 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id 11FFD6B0005 for ; Tue, 7 Aug 2018 06:24:37 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id f8-v6so5227794eds.6 for ; Tue, 07 Aug 2018 03:24:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=wLQoCuaF7nZTHfLZjHSkGbSR0zX+AJkXtEJehuZZLS0=; b=hAkesIXN5de3ApS5RT7+0ky2JFhrHGyajRKvRx9pJ74PQXdFrpOIoB7aEsEAHErAHv 2WYe5D1Y+2JTtXzEcL6ZPlj51isuy3oRo2WqV6X3iTHV1W4ZpxzS34aXxu52Mh9FRzTv i+vr7mnZ9gR92h2FQKkNJov74EB4Vn8IBxuyIrqkKr2CZyNt82j+q0sYKEWKcucafcoE 7R3p35HcfRRJBuhhAZ8jwPwWrfxobKSHxs0wR06W81uQr53xSBjFXe1rNcYQLDghL6cF whj/v8S+AOI4PTMCeIUABSKSF5SVNhe4VE1MhPep5dCg/57xMjn6KRYfPYYYDC3pZevL SjDA== X-Gm-Message-State: AOUpUlHBXpMFF8GTMsNgGn5hm/+UbJ1e5AD7sXoXq0qvZZEB0l5o2qtI G6+IGhXCQD4RAUe7y3+1LL0i20D5wbO8pHTNDA3GnsqzfyMEKMMH+n6WlVxm6E72PjLGqh+8edk 1kvLkYTZqhaPto/9jaJkcHWJcYVvCjmfV+9B1fYbWq0Lg382rqTXL1vSIx2JT2aklog== X-Received: by 2002:a50:b613:: with SMTP id b19-v6mr22376405ede.255.1533637476564; Tue, 07 Aug 2018 03:24:36 -0700 (PDT) X-Google-Smtp-Source: AAOMgpckX5LeyC2Aekjx1w5fETl0tLZouevnDHWTWWLjE0H7SxsDlrujkXirzIWVgCgK1fvo7an5 X-Received: by 2002:a50:b613:: with SMTP id b19-v6mr22376336ede.255.1533637475458; Tue, 07 Aug 2018 03:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533637475; cv=none; d=google.com; s=arc-20160816; b=db02JON/LA3gFeTdmhG9qW33ZGvNxcTuQc8lxs7pfGeeTJYYlexBFQGiiX4aUDAqQp Vo3B+GWnnG0P22Osy5BLLKpMLl2eavrVvA1PULPYggoUn5VKhkfO/BsNPa4rU0mwalvY 9xyN88JL8d3EUlmWsQwbPXcdOW35z5naGm8wCWBYKs8FLPW62rysqPfY3OqHo4kjwZgF COVL7in4HXRSDspcZreEGr5/nn06aQnVOmshF76C71ClqFqk4uNgCZ/LP343zZOxxi1y mdGyDY1kpb9k+5o2NJt8zpWi8iDBdqBgwcF5S0Mu/6EaKbxieVhbtS5amPNjm3kNY2zY /tqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=wLQoCuaF7nZTHfLZjHSkGbSR0zX+AJkXtEJehuZZLS0=; b=Z70iF35dLDSWFQMy7FAF0aXuIqtF+e3neWU0RMf9HTVWM/nMsYu/VrNruDMONLQHWz O+tSmZMaWhQ29jZW2x9UIbwl0aoxpqcqBJFOzJ5+jcF36oXNwToWooNVOIf58lIp84fQ /PBz6VPlFT6Pt74OZ76J/U7eaOX2L/aYY1c7jQFtSLTavbKtfY/Anu+xoDAFpih8WPZk GR1O9jfpGWaGZ/tNRvDsIbT1SWgNoz+HqjB03udJ+VzHXpvDwVLN8knFRS3Zc789X7+x R/orD8MuitTDXtL4RzZ564z93CWEglIqEYhVjm82u4GVu158fZc/74RN4u8tzBNJ5Hc1 qLaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@8bytes.org header.s=mail-1 header.b=O36mKEnR; spf=pass (google.com: domain of joro@8bytes.org designates 2a01:238:4383:600:38bc:a715:4b6d:a889 as permitted sender) smtp.mailfrom=joro@8bytes.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: from theia.8bytes.org (8bytes.org. [2a01:238:4383:600:38bc:a715:4b6d:a889]) by mx.google.com with ESMTPS id t18-v6si664794edf.80.2018.08.07.03.24.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Aug 2018 03:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of joro@8bytes.org designates 2a01:238:4383:600:38bc:a715:4b6d:a889 as permitted sender) client-ip=2a01:238:4383:600:38bc:a715:4b6d:a889; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@8bytes.org header.s=mail-1 header.b=O36mKEnR; spf=pass (google.com: domain of joro@8bytes.org designates 2a01:238:4383:600:38bc:a715:4b6d:a889 as permitted sender) smtp.mailfrom=joro@8bytes.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: by theia.8bytes.org (Postfix, from userid 1000) id 997C32F5; Tue, 7 Aug 2018 12:24:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1533637473; bh=Hj+SU0Qi3gZNMXnmPL7TuoJ+PAqH5xoY7fEQcBwdn6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O36mKEnRWyC79mRhCh+IPXmc77EAS47qmqWnud68YuK+bTATmtwKgih5zHkOixjf4 e9mVudDghe9YdMTU7R+8G2K+uP/n1rpu46WC2St5KwunHzxWiWDN1tCo8kuRBv4Mnd V0ibcAkf2cAjJMlVOSQUaHv/K4VV+UW6NKW4s8xi/BBE2S9cvfLiznD5wHXMw8q0l+ 3DdLOnQranBg0zwlJTGKzwLgZ78AtcLWCFz1OzgAm2CXNzhpmKihlOqLhzUOkNKpuZ oQri8X7dZhYpTP+MUQV1UU8vFehR9VsUb5dYI5mw66uWg2ShlJpZcGjBfaVrKgaITH blQRNyoL9YtmA== From: Joerg Roedel To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , aliguori@amazon.com, daniel.gruss@iaik.tugraz.at, hughd@google.com, keescook@google.com, Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , jroedel@suse.de, joro@8bytes.org Subject: [PATCH 2/3] x86/mm/pti: Don't clear permissions in pti_clone_pmd() Date: Tue, 7 Aug 2018 12:24:30 +0200 Message-Id: <1533637471-30953-3-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533637471-30953-1-git-send-email-joro@8bytes.org> References: <1533637471-30953-1-git-send-email-joro@8bytes.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Joerg Roedel The function sets the global-bit on cloned PMD entries, which only makes sense when the permissions are identical between the user and the kernel page-table. Further, only write-permissions are cleared for entry-text and kernel-text sections, which are not writeable anyway. Signed-off-by: Joerg Roedel --- arch/x86/mm/pti.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index 113ba14..5164c98 100644 --- a/arch/x86/mm/pti.c +++ b/arch/x86/mm/pti.c @@ -291,7 +291,7 @@ static void __init pti_setup_vsyscall(void) { } #endif static void -pti_clone_pmds(unsigned long start, unsigned long end, pmdval_t clear) +pti_clone_pmds(unsigned long start, unsigned long end) { unsigned long addr; @@ -352,7 +352,7 @@ pti_clone_pmds(unsigned long start, unsigned long end, pmdval_t clear) * tables will share the last-level page tables of this * address range */ - *target_pmd = pmd_clear_flags(*pmd, clear); + *target_pmd = *pmd; } } @@ -398,7 +398,7 @@ static void __init pti_clone_user_shared(void) start = CPU_ENTRY_AREA_BASE; end = start + (PAGE_SIZE * CPU_ENTRY_AREA_PAGES); - pti_clone_pmds(start, end, 0); + pti_clone_pmds(start, end); } #endif /* CONFIG_X86_64 */ @@ -418,8 +418,7 @@ static void __init pti_setup_espfix64(void) static void pti_clone_entry_text(void) { pti_clone_pmds((unsigned long) __entry_text_start, - (unsigned long) __irqentry_text_end, - _PAGE_RW); + (unsigned long) __irqentry_text_end); } /* @@ -501,7 +500,7 @@ static void pti_clone_kernel_text(void) * pti_set_kernel_image_nonglobal() did to clear the * global bit. */ - pti_clone_pmds(start, end_clone, _PAGE_RW); + pti_clone_pmds(start, end_clone); /* * pti_clone_pmds() will set the global bit in any PMDs