Message ID | 1536747974-25875-3-git-send-email-will.deacon@arm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88E3D14DB for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 12 Sep 2018 10:26:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76AE829A7C for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 12 Sep 2018 10:26:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A0D529A8D; Wed, 12 Sep 2018 10:26:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5397629A7C for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 12 Sep 2018 10:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CBAB8E0005; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 570918E0001; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472158E0005; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 2051D8E0001 for <linux-mm@kvack.org>; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) Received: by mail-oi0-f70.google.com with SMTP id w12-v6so1728467oie.12 for <linux-mm@kvack.org>; Wed, 12 Sep 2018 03:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=5Z6J2RQTqMWhpJ0pzFttI0SwIzpZ6lRPEY1BeHTRt8o=; b=DyvSTmI98Yl3v0Uo7JooRuC3Ktyc+2VCjwn7hNRYmgcP28sgc7VJq/hmf2uzxholWr WxT8036SsO+KavZkmQrnxfAgkUO49eXT23IFfJ8tXrQv5e7pF74vj/bi2Y6+xaiyQpR+ 6kPR3KbSqkTcCFgzctaPWr9LI2zAdpJdlsjV2CYIlF06d/6hyp16gECQUelFlqDrU0Sh rvXH0b9kp1QPuctxRv9Q240fIG4ORUNY57K91AuPBFaf11kp23+X+sv1adxjbNTRTB5L YwS7rSInhoNd1U9chVzKzPVDU362ECh0PzCyKpvbfeskMIGkUPK6T7Ag5VGany0wQ/Vm XJBw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com X-Gm-Message-State: APzg51Dpnc0SC4hSVZkRUfK0/2mVMOjwH6aal2Hm/bLKfc46P5TfOork w32EGo7NKMruyBh1eEowBBjB2ikKDHoARFauR5yvcYERZsY2pBcz4FC5k8psNqbDgWe01s0JNEk ec+G65druwuF6AQkoxPG6ememwBYFFifRJuwE+2RStrzUIzOUpcKIU7tpAoLtHzVIyA== X-Received: by 2002:aca:dbc2:: with SMTP id s185-v6mr1269706oig.251.1536747963919; Wed, 12 Sep 2018 03:26:03 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbd5659cAON1DLYVe2svFW0ohXnkWkTSQUqVeXxO2mvNF4HBaVFz7AmPh1vK27kt6foEayh X-Received: by 2002:aca:dbc2:: with SMTP id s185-v6mr1269631oig.251.1536747962895; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536747962; cv=none; d=google.com; s=arc-20160816; b=ZYhZeIg08uc3rNjwbzaA9ngudui0CxyUsyVc9ep8TyhcSg1AbCOiDxzCRBZkpipPYD 3Ft+odPk85RrDPGHtWKfVQB14w6/3ROVecJcZXbrQL8mg2T8r7Ty4cXj9dzNck7QkkQ6 I+VoPvUMa9WLGRd/zveD1JjrL4BvE9JLdBy3DDcQ3s8UepEbMNQAPtN24953pG6Iv9fs C+eRL25GMAIYLsHCs1ycZCytbiZAiDddO2Bwgpnzb2wDu4Kjl9YHIGVXDfI4X3MUVPtB znphq8uapq1dmSkVmnWE47NvZCTnKnFrnXZocCO75LTcApH4g0rVs0SCsdi5mp1e8FI0 0yzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=5Z6J2RQTqMWhpJ0pzFttI0SwIzpZ6lRPEY1BeHTRt8o=; b=m+c37tb4wbQcs8R/P+r5nq2sHkv60YhtnvK1hT0ZngdGjfKWt4uMfkPW58yASdoGz4 HkruNnJMb6OLA4TXLrODFAUBRe/XcZk/Qb2CIkYiBwvUgYWfKQkf4Z2dFrEscqcsqaVJ 18RnXY+v5LbYkYHt9dnD85o6q5LY1f1H83avsgyfu389Te+WQyhRspovDshmHfpH4HjQ 98pWduDeHeXFwqrMXXhkvXFfRgBbGu28jDeTXepG4yn/F3X9qvAQ6XDuGxHqHLewTAzV oMBC2ZcSKqU91CUVcfd3WLVrMIowp583E1RqLx8lyk+kE/bNAD8WiBQRPQm1eEKAPUkK yjWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id b135-v6si452780oii.71.2018.09.12.03.26.02 for <linux-mm@kvack.org>; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) Received-SPF: pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01D3B15BF; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C76BD3F7DB; Wed, 12 Sep 2018 03:26:01 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 939EC1AE3318; Wed, 12 Sep 2018 11:26:18 +0100 (BST) From: Will Deacon <will.deacon@arm.com> To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, akpm@linux-foundation.org, Will Deacon <will.deacon@arm.com> Subject: [PATCH 2/5] arm64: mmu: Drop pXd_present() checks from pXd_free_pYd_table() Date: Wed, 12 Sep 2018 11:26:11 +0100 Message-Id: <1536747974-25875-3-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1536747974-25875-1-git-send-email-will.deacon@arm.com> References: <1536747974-25875-1-git-send-email-will.deacon@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Clean up huge vmap and ioremap code
|
expand
|
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 8080c9f489c3..0dcb3354d6dd 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -985,10 +985,8 @@ int pmd_free_pte_page(pmd_t *pmdp, unsigned long addr) pmd = READ_ONCE(*pmdp); - if (!pmd_present(pmd)) - return 1; if (!pmd_table(pmd)) { - VM_WARN_ON(!pmd_table(pmd)); + VM_WARN_ON(1); return 1; } @@ -1008,10 +1006,8 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr) pud = READ_ONCE(*pudp); - if (!pud_present(pud)) - return 1; if (!pud_table(pud)) { - VM_WARN_ON(!pud_table(pud)); + VM_WARN_ON(1); return 1; }
Now that the core code checks this for us, we don't need to do it in the backend. Cc: Chintan Pandya <cpandya@codeaurora.org> Cc: Toshi Kani <toshi.kani@hpe.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Michal Hocko <mhocko@suse.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/arm64/mm/mmu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)