From patchwork Wed Sep 12 10:26:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 10597325 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 21BAB14DB for ; Wed, 12 Sep 2018 10:26:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 105FC29A7C for ; Wed, 12 Sep 2018 10:26:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 04FA229A94; Wed, 12 Sep 2018 10:26:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9124C29A7C for ; Wed, 12 Sep 2018 10:26:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5BC8E0008; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 87D358E0001; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A7EF8E0008; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by kanga.kvack.org (Postfix) with ESMTP id 3F5AC8E0003 for ; Wed, 12 Sep 2018 06:26:04 -0400 (EDT) Received: by mail-oi0-f69.google.com with SMTP id b8-v6so1790235oib.4 for ; Wed, 12 Sep 2018 03:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=1JT3gBGB2fQ1eze1dftN8gxIxDA2nlm9MPmGKsks1qM=; b=GOWg9AuIPcZ4wY17s5EC6qb2MX3I0q5Omu80NzdPgD1ezpr7+QNMMlIdnIlCjoX/by /p76H7LYykG6Ozw4SgbhDzpkI1LonlsVs2A5eDaSu1RVsBzBA0pKW24LkbAZSgro5HAM KwVOPA4r19YQXKw32SMxfDIVv9JnaXFJs2b7/y53m/2unbzWSm61v884m6jBaOMqrCnG sVzX6aYgbDIgRsFii1ejl7FaCaojGdKlfzeRrdY3GYEjxGl6/aOrdD6o5oe9aQR5wJV7 yCKeINEW/cEfkFGerwCAGy4IIDH55KkAbh8W8LNBvqmmEmN+o4YNSfqFQOl4MdwLQkJ/ +gWQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com X-Gm-Message-State: APzg51BLHh9QL00M33jeLMoBc5voqKiyrJr1CHuR11dMWC+57T0YoI1Z EFxnhMcuf7fVRdGW4MwNx8SLGsAqRJUcvo+JBmL3y/o2Hn7qygdaC4YhOvKqCD21bddYvtLX5Nf 5CDNB0lr0FEUSvBFi05AwH4Od4U47DJZ+T5PqMA3+cdvrmYmDJTEfMwAmxMpLoNgBjw== X-Received: by 2002:aca:3606:: with SMTP id d6-v6mr1300553oia.327.1536747964015; Wed, 12 Sep 2018 03:26:04 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaTS1W/FBK58k/2Z2Kz8Hq2BQFAsdOe1GLn5LsNfFE8VCxgJ6yWGARnWQsD0eBdY24LMCdA X-Received: by 2002:aca:3606:: with SMTP id d6-v6mr1300467oia.327.1536747962894; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536747962; cv=none; d=google.com; s=arc-20160816; b=nEPFcd0YtsYusSf2MCZhLWaX8uqAfEn7pGF/+R2V47mX6mEG5lmlx1rgISikxXyeOE hFda2X+qCt00skz3gqu+AGFs936RdbO8l/BzKp0i8dSONQfW+fezB0zjfRWsb18SM2fg 7cj9gchckhb9QtAnvePSLHqw4uS0CRDt1LEgF6+nEMSxPZlTKt3djiG6j73AyMMRdtdx WA6bAIAR0nauCdWvHGRymeRkhWMrpxy6kiZYLRgGmpu+3X1pf2/pLA3Br6jiwA2rSOSQ kfL3J+PlUzyCfDpv9g7cByCItiCn2kdtwT1s9W37Nq8e7f4TATxuVRotzxcla9XEl6Ah b3sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=1JT3gBGB2fQ1eze1dftN8gxIxDA2nlm9MPmGKsks1qM=; b=JFRtVAeVGHiyadyy3AXve/5bXK/ZnyUP7v+1/Dlb5jVy+RY+vTgHYxr8AtmG7GV82B XrVIuzTmRmWn1Qw3vieWq5azbVMuv2SBP8aLzW6LMMBZKD1pMP7//u9YL5ZvhA8A6eWR shG2EMTxqaggC0yT2HUVFmnqtoKFOilpX0EHpm7XOgFay2SCFNoRQJZsfE3WpQGtk84i hqXNW+E7uutKN3JJjBhH7aNtMvRefCNyzWsaYd4x45WkiZAz5V0XC6bvFP6wVJfKhyB1 GmkjrFXgrYlbuFJ5WyNXFMbKrAY1OvAEbwMb2j+psWH/kduUIG72q9gcN/v/ONG2LNz3 1/Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id a200-v6si451339oib.18.2018.09.12.03.26.02 for ; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) Received-SPF: pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 111FC1682; Wed, 12 Sep 2018 03:26:02 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D766F3F907; Wed, 12 Sep 2018 03:26:01 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id A3E011AE33B8; Wed, 12 Sep 2018 11:26:18 +0100 (BST) From: Will Deacon To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, akpm@linux-foundation.org, Will Deacon Subject: [PATCH 3/5] x86: pgtable: Drop pXd_none() checks from pXd_free_pYd_table() Date: Wed, 12 Sep 2018 11:26:12 +0100 Message-Id: <1536747974-25875-4-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1536747974-25875-1-git-send-email-will.deacon@arm.com> References: <1536747974-25875-1-git-send-email-will.deacon@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Now that the core code checks this for us, we don't need to do it in the backend. Cc: Chintan Pandya Cc: Toshi Kani Cc: Thomas Gleixner Cc: Michal Hocko Cc: Andrew Morton Signed-off-by: Will Deacon Reviewed-by: Toshi Kani --- arch/x86/mm/pgtable.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index ae394552fb94..b4919c44a194 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -796,9 +796,6 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr) pte_t *pte; int i; - if (pud_none(*pud)) - return 1; - pmd = (pmd_t *)pud_page_vaddr(*pud); pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL); if (!pmd_sv) @@ -840,9 +837,6 @@ int pmd_free_pte_page(pmd_t *pmd, unsigned long addr) { pte_t *pte; - if (pmd_none(*pmd)) - return 1; - pte = (pte_t *)pmd_page_vaddr(*pmd); pmd_clear(pmd);