Message ID | 153981644678.5568.12082748496872368668.stgit@magnolia (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 30952157A for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 22:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2177C288C7 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 22:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 160BB288E4; Wed, 17 Oct 2018 22:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA6F7288C7 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 22:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BC866B0297; Wed, 17 Oct 2018 18:47:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 96B3E6B0299; Wed, 17 Oct 2018 18:47:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85ADE6B029A; Wed, 17 Oct 2018 18:47:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by kanga.kvack.org (Postfix) with ESMTP id 43F5A6B0297 for <linux-mm@kvack.org>; Wed, 17 Oct 2018 18:47:31 -0400 (EDT) Received: by mail-pg1-f200.google.com with SMTP id s7-v6so21314603pgp.3 for <linux-mm@kvack.org>; Wed, 17 Oct 2018 15:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:from:to:cc:date :message-id:in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=jZPaIA2I61+2o/Blz6OYutRXgyd1ozFk3SQt5++KfCo=; b=myVSANrFBs3DKtVrtBYXcg5n/a8QqcJQIRBXKiOvhVoLSpjdoymvxnNzYpmyomb381 0ybiZKgccxWAMzUGQv2GJwz3ILquVb/t9AaDv8YHJJyekS2x3OyzHEf+H4USte8TqQiq bQnDzs+snam4Cy/kvZ0frCdh6gbWTxgjhUG980nrrN8B3ZwiJjsOXDcAVpYsVLlvu9vt VuSiTDsQmyiZdPHpbBb+opW8y5MyY+jDoOHjcf/U1P8tANixabvt5kzvUf1puMmmhrYW Ko7PP+jx3C+sBUFXQsbziDkE4PpufpHNA7miW0ZkQIugxJVnqApp/UtxpGc2LoBQjQGL A8qA== X-Gm-Message-State: ABuFfoiJk+l/qTIkdaCpuMvMraGWzzeCCh45tLW/my18GCNy+A3fCw9f BPRPHgJ0ctolc0s2QWwRxldBORlM6u4lUVB3dOe2sN4p+Yhkn5oHhZLis8VstUHtnmRpt35H0f2 bPsLgT6pTPE6R8idEd5aDX4yPNyKEhyNgDmElHhvl4/EtRNmv7Y12sngA/3XPnZk2aQ== X-Received: by 2002:a17:902:5590:: with SMTP id g16-v6mr27302839pli.46.1539816450943; Wed, 17 Oct 2018 15:47:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV62VTDj6+HtvodoMbaUB8ntsx35+zFzbZCYK6o5tw3MJd6uiWK9sxu2yibNQCgh1iM6bT7V4 X-Received: by 2002:a17:902:5590:: with SMTP id g16-v6mr27302809pli.46.1539816450321; Wed, 17 Oct 2018 15:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539816450; cv=none; d=google.com; s=arc-20160816; b=Z9S7G+juELeVawVbnNGk5VSmOdpFDVAGZwC0zyebuc3lUEIs3U4xbKukluICuFmih7 zSSecWCNDIBkUFkS1SdQzFa6hZ3mTOLz9Tx7ppt0cHucpl3RqPADzVq6hNyegGzEpX8g hJdNeNU/9i2bV7lIOM7i3Yx/6YkUJlQz7eQok/vRk8KxpYJcpF0wOvGZLB9rFKQE+R1Q birqfSnQdPHfl9xq+5VdeIOJQ5FVzJsqmkyZqdnXs3U/hpVW2lRZijrdTC5Iati4eCUb LNXoJfktACgNxCtzobR5dc46kiM8EslVaAYcuxEkFR/F64LkKu+wXHsJAS1CBHMm9wl4 +5eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject:dkim-signature; bh=jZPaIA2I61+2o/Blz6OYutRXgyd1ozFk3SQt5++KfCo=; b=0WsKHEQM6K2G3Wel5+kege2CoTtj+W2sYzbNaqfitkvidKpJlHsib+6zXYAa0Zf55y RslrcXa2VRHUw4++F1QLb0wWyL4mvmlPn/T0ycteaKjSIY75d0gvkbZ8YcknjPNAjjsu cDSpoLH6Bu7gZY0LCdJcTyoWerODPdAbNZ/TVBIfgOIQcksexuHYqjKzL3YM5rXhvTcn PMrFj8iUhEWFsYY6QgIceiCtkYq0ITSwN1c3a1e5/OK/cc0KDMweQp8SvRQYZQnruv9/ EaVGAKNCObY+kuKqzXghIz2Yt9twQc0wrg9aZdfKsXlRYP66FPaKFuZmwmuEVdUWULtn 01RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=et99L8gB; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2120.oracle.com (userp2120.oracle.com. [156.151.31.85]) by mx.google.com with ESMTPS id g24-v6si19287134pgh.188.2018.10.17.15.47.30 for <linux-mm@kvack.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Oct 2018 15:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) client-ip=156.151.31.85; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=et99L8gB; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9HMiLoX189514; Wed, 17 Oct 2018 22:47:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=jZPaIA2I61+2o/Blz6OYutRXgyd1ozFk3SQt5++KfCo=; b=et99L8gB2MUC0kjQQLsBf5KglW6mvyO+CGSRLYvf6VyqpuLhl4nuZ0flh0AxGDtVDAvv Q4lvfKCK4C9lUkqt6reNowEq3JsreJQ851PMtcLOdOLVzfKOvmD5NLNzZd4E92RGsxRJ QOY8lGCAXMYD2BaiheEhYsRfMff+zhQbgUNWaMONWZVi7YSY+3Z4DOzjTiZJKESii6l3 P2jlzDJCpUzOz11dnHoYsohBxlNHBsTcCaal12BfRGlCaghUln7gxllPnHHL+u3mwnuh +FRoH3mcpmCclYzpn20F7XAc9Yj6xVDsqI1yZA0eZr/Bb4RMccBOV/QnsZ/voAQvp3CG PA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2n39brhpc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Oct 2018 22:47:29 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9HMlS3N013123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Oct 2018 22:47:28 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9HMlSIM032606; Wed, 17 Oct 2018 22:47:28 GMT Received: from localhost (/10.159.132.177) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 17 Oct 2018 15:47:28 -0700 Subject: [PATCH 27/29] xfs: remove redundant remap partial EOF block checks From: "Darrick J. Wong" <darrick.wong@oracle.com> To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Date: Wed, 17 Oct 2018 15:47:26 -0700 Message-ID: <153981644678.5568.12082748496872368668.stgit@magnolia> In-Reply-To: <153981625504.5568.2708520119290577378.stgit@magnolia> References: <153981625504.5568.2708520119290577378.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9049 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810170188 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
fs: fixes for serious clone/dedupe problems
|
expand
|
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 4abb2aea8f31..bccc66316cc4 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1314,7 +1314,6 @@ xfs_reflink_remap_prep( struct inode *inode_out = file_inode(file_out); struct xfs_inode *dest = XFS_I(inode_out); bool same_inode = (inode_in == inode_out); - u64 blkmask = i_blocksize(inode_in) - 1; ssize_t ret; /* Lock both files against IO */ @@ -1342,24 +1341,6 @@ xfs_reflink_remap_prep( if (ret < 0 || *len == 0) goto out_unlock; - /* - * If the dedupe data matches, chop off the partial EOF block - * from the source file so we don't try to dedupe the partial - * EOF block. - */ - if (remap_flags & REMAP_FILE_DEDUP) { - *len &= ~blkmask; - } else if (*len & blkmask) { - /* - * The user is attempting to share a partial EOF block, - * if it's inside the destination EOF then reject it. - */ - if (pos_out + *len < i_size_read(inode_out)) { - ret = -EINVAL; - goto out_unlock; - } - } - /* Attach dquots to dest inode before changing block map */ ret = xfs_qm_dqattach(dest); if (ret)