From patchwork Mon Nov 12 06:07:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10678173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7AC2F14E2 for ; Mon, 12 Nov 2018 06:08:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A02C29332 for ; Mon, 12 Nov 2018 06:08:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5DDDC2A017; Mon, 12 Nov 2018 06:08:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E898029332 for ; Mon, 12 Nov 2018 06:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70CD86B0010; Mon, 12 Nov 2018 01:08:14 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE2A6B000E; Mon, 12 Nov 2018 01:08:14 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DA846B0010; Mon, 12 Nov 2018 01:08:14 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 1AC2B6B000C for ; Mon, 12 Nov 2018 01:08:14 -0500 (EST) Received: by mail-pf1-f199.google.com with SMTP id g76-v6so7072300pfe.13 for ; Sun, 11 Nov 2018 22:08:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=jMLb2BKzmXBCJuzHEvroGcLpPS2Cq9AGTSdXYh98axA=; b=qFgURo5w3vA5twJTHnS3Btr0jDQkUvwEvhiio5nsTXSaPqeyyfylQFgEtWWjJEQR6w VDSTfN0h5u7ffbAB63De29+OuiUYLIUmNzRvwnTtogZ9IzWOQl8OJDDRm1iUu+BLqXRv jvtHv/6UfEcCKE1KY8bWvCtnsNxIbb0s191mSTnK3+xJ6OvQttmJeyQaN3yN/tTaX2p+ YVxdhsw2s5Q+fc1E667s3ij5NpAvpgimSY7jVjeGs/mxL6dL31o7JlPyeVucSxTMnpUx Amhkoh3wnJxRFlkqMOTZjnPMhgP4U0+3qh4IzZQ3Ia0t4GguLa+sCX5ZhDrD22UuOM5Q 8+Rw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.198 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: AGRZ1gJ2VG1Vzz7H/4N+A4913G+ex4ZpR2j1EMUsIUeOA7uezHmDvefQ WtnLykTYNYRg5CWu86zCuc+zqaamMwoyTwXGGwU2B/6RkLP8uQ1B0t2P8GYsqm3esRhvSdxb9/V Dq5ZEJgBXSsRzw9toI/AoO3sZzB1JBsQlZZntp3KQBirh2x0oJchf2uB9uqiie0c= X-Received: by 2002:a17:902:7882:: with SMTP id q2-v6mr18961695pll.188.1542002893795; Sun, 11 Nov 2018 22:08:13 -0800 (PST) X-Google-Smtp-Source: AJdET5cTf1jZKiaElGn6xXimx3oM9nfZjI53rhrP6hhFcMpNh5+UlwZ6UwjxbkBAPZvZwDZX7EAP X-Received: by 2002:a17:902:7882:: with SMTP id q2-v6mr18961556pll.188.1542002890511; Sun, 11 Nov 2018 22:08:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542002890; cv=none; d=google.com; s=arc-20160816; b=WMFkjfh7QRqBKk3owWWZE2+g9pghyPMDIk5B+q//LnX2pJkK91I/WKOZFRB+iv+MXr T54xVqL1PB3FNCng2qsWdiIxKLnStYO5dMUbfjZ6Z4n3r23XEjZYR0QcvMqZiNpwduPk KnhITStutmLOvYhJX3IU6LtjHk+qr6PMucZb/lXJl/96CXdivv/jKSabfhpI+AvwfGt6 fvzV1d2Pd5j1M0san4e5NO2FX70qNWB5wUXxacqyXNni5y+yz2dK+vkad1xLod69Wrut XsnALVTqhnirXhX0Mwi6MDHflKYe0BnN5eYh7sXm8BJ6/mUkQK7uQbF1LLP9OCApbE1t 7eTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=jMLb2BKzmXBCJuzHEvroGcLpPS2Cq9AGTSdXYh98axA=; b=ZXkwOAhpyjWXR7xZCAch8p1dzNLydrwO+dGkvIXySPc/1YOwZxFacJlro6LnXhLasc pI2Gek5ggb4Qq+Zff+MB7VDN9RMb4Y2d8KwPNTC3nf1A/pQ6Dyz0Q2yL+3SII8G5HFYf 2ZPEdfhDI+o1YcAYXjpbT56t7QVvQQ+EOJAw4D0znV2rGOWQT0HNG5bAPYdWTN6hpTgh l2I0OZgBGVQYuEAPTarBvrh5enCTZ55R0G6bRAjxQ10MFyG+3zme/RT8CFOuAnqlHvu4 xkNT4JGHHjvYSVK3GkfnJb42kDv7/iHt0n/WxAdOXH/EI4SO9hrlvVTe4GejUQ2Un718 iR2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.198 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr.qualcomm.com (alexa-out-blr-02.qualcomm.com. [103.229.18.198]) by mx.google.com with ESMTPS id 2si16377227pgz.395.2018.11.11.22.08.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Nov 2018 22:08:10 -0800 (PST) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.198 as permitted sender) client-ip=103.229.18.198; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.198 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,494,1534789800"; d="scan'208";a="236422" Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by alexa-out-blr.qualcomm.com with ESMTP/TLS/AES256-SHA; 12 Nov 2018 11:38:09 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9074"; a="5747618" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg01-blr.qualcomm.com with ESMTP; 12 Nov 2018 11:38:08 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 96C2924B7; Mon, 12 Nov 2018 11:38:08 +0530 (IST) From: Arun KS To: Cc: keescook@chromium.org, khlebnikov@yandex-team.ru, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vatsa@codeaurora.org, Arun KS Subject: [PATCH v4 4/4] mm: Remove managed_page_count spinlock Date: Mon, 12 Nov 2018 11:37:49 +0530 Message-Id: <1542002869-16704-5-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1542002869-16704-1-git-send-email-arunks@codeaurora.org> References: <1542002869-16704-1-git-send-email-arunks@codeaurora.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Now that totalram_pages and managed_pages are atomic varibles, no need of managed_page_count spinlock. The lock had really a weak consistency guarantee. It hasn't been used for anything but the update but no reader actually cares about all the values being updated to be in sync. Signed-off-by: Arun KS Reviewed-by: Konstantin Khlebnikov Acked-by: Michal Hocko Acked-by: Vlastimil Babka --- include/linux/mmzone.h | 6 ------ mm/page_alloc.c | 5 ----- 2 files changed, 11 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index e73dc31..c71b4d9 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -428,12 +428,6 @@ struct zone { * Write access to present_pages at runtime should be protected by * mem_hotplug_begin/end(). Any reader who can't tolerant drift of * present_pages should get_online_mems() to get a stable value. - * - * Read access to managed_pages should be safe because it's unsigned - * long. Write access to zone->managed_pages and totalram_pages are - * protected by managed_page_count_lock at runtime. Idealy only - * adjust_managed_page_count() should be used instead of directly - * touching zone->managed_pages and totalram_pages. */ atomic_long_t managed_pages; unsigned long spanned_pages; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index f8b64cc..26c5e14 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -122,9 +122,6 @@ }; EXPORT_SYMBOL(node_states); -/* Protect totalram_pages and zone->managed_pages */ -static DEFINE_SPINLOCK(managed_page_count_lock); - atomic_long_t _totalram_pages __read_mostly; EXPORT_SYMBOL(_totalram_pages); unsigned long totalreserve_pages __read_mostly; @@ -7065,14 +7062,12 @@ static int __init cmdline_parse_movablecore(char *p) void adjust_managed_page_count(struct page *page, long count) { - spin_lock(&managed_page_count_lock); atomic_long_add(count, &page_zone(page)->managed_pages); totalram_pages_add(count); #ifdef CONFIG_HIGHMEM if (PageHighMem(page)) totalhigh_pages_add(count); #endif - spin_unlock(&managed_page_count_lock); } EXPORT_SYMBOL(adjust_managed_page_count);