From patchwork Tue Nov 20 23:13:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10691445 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7349D16B1 for ; Tue, 20 Nov 2018 23:25:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EFD82AC58 for ; Tue, 20 Nov 2018 23:25:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52FCA2AC59; Tue, 20 Nov 2018 23:25:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2A6A2AC5C for ; Tue, 20 Nov 2018 23:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 952D26B2294; Tue, 20 Nov 2018 18:25:55 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9014C6B2296; Tue, 20 Nov 2018 18:25:55 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817246B2297; Tue, 20 Nov 2018 18:25:55 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by kanga.kvack.org (Postfix) with ESMTP id 38F5E6B2294 for ; Tue, 20 Nov 2018 18:25:55 -0500 (EST) Received: by mail-pl1-f198.google.com with SMTP id e68so4127730plb.3 for ; Tue, 20 Nov 2018 15:25:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:from :to:cc:date:message-id:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=KwMl5p8j+73VGDeoGja2a8heb8DxLlCZxG1xuU9a2ec=; b=duUlOsZl+mDDd154xCoJDaGS51fY0Z3c5SNJIr3O2NysOyHO0267SCceIvijFzxpV3 iuQ6Hq2YBZ4BuBjnIPtcRola7yxTjydgIl6qdJebVSE7m/lXxUfl2UBuGAfhFPP08coy XauQkeqUOQMKGEKUOkud5NRPRfM0YXYHvYYGTCktL+es9iP8c68h1/HZvKP1wRdx+84r UTpIuZ2leZBNM++ndbqQnCHzXdcJoCiwlFtyD628nWhaRlxgk9i+xn076fvvqlch8BGW ksdJqbEnZJ9jsoYEYrkXv/Z2bNrC+lp6QqfWIt4Oa6fznkqo77QOlrwaG+9lRrcekm1v wDJg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: AGRZ1gIpSBbkVyfP4HcehDu1wytye3B24OfBS90oEAgx77SVEwWaFvGt iLpOQ/fVS1AQLNFR/Z00Z4PHk6V2ixNV0Fy4uYscoIOHV0Iulm74CoZdNaDO8zffgGRaTiVZR15 +x887myRdE7BiHVUhax6uKT/D1OgvjEiDUVO1RKoXZYhws5jooJAehAzXOXnGp8z9aQ== X-Received: by 2002:a62:2095:: with SMTP id m21-v6mr4308221pfj.32.1542756354878; Tue, 20 Nov 2018 15:25:54 -0800 (PST) X-Google-Smtp-Source: AJdET5enYo5a6lEAPLlTAVdQhF8/xhdsk79jNhlE8RUYlqx2dAXtrw+2F+XPZWcKUASHYqY+H5le X-Received: by 2002:a62:2095:: with SMTP id m21-v6mr4308164pfj.32.1542756353859; Tue, 20 Nov 2018 15:25:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542756353; cv=none; d=google.com; s=arc-20160816; b=rKhSxUCCasKen4uCe1pxpal72KCfidk2vdPFsxsGfAdzmnHYzE3/v+zcGAjysZJ/KO T1e4M/lq6+2V8suLQCWImqu7P/f3gQSJVSeSqm26SSHFCnVYJ46lPAd7cOGbA/PYX821 AapcjW1tnvZCjzUFbTxdmC214PbuQAPNca0ed+O5CB1ZBh8htgkBy+59+SXl3Wpudm5X ynelRUob+TWIsgglNvYPTYQlJnFpVsfuG/YG93lUNp3hzBGGJVVRHF2bfQS1WL771nGu F9AL7fV+0DnUtd9qUZRVqvsmYMa5t6qPqJOsK2R/oMhp72IJgrSFq2GBaEkXSBLS3dcx Gc5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject; bh=KwMl5p8j+73VGDeoGja2a8heb8DxLlCZxG1xuU9a2ec=; b=frKnq8WCPkXqZXxyTF5zLCcyjldtOdxQhujshcwZ6AMYuzhzwjWHjFQtWItOSyTZXG fYdszNK2vNJMU3gQc/KF6viCSK5xla2B6Ge0URtD/NbRw+uL7grLz9CLQj0LPCwG3RPI XqJdftj6nk0xBXqKw8ZlZ2kOVTwaCjLfUlEkKx9e9tokkxdoPhYx4ZECfYFg5zV07Kf5 0ttVlWvmpCMjidLJGHKqNc20kljhKiYOiARypgdtHVj91vYMBvYt4RmwRkO+Ng2YGsLq +b3mUF6YhtHtOvA9FjI69LYmHYVyRvtcRT5PWmdpEFGM4rNQf3fpSzfKQS+qv6MYJyHW Ssew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id z129si1576898pfz.13.2018.11.20.15.25.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 15:25:53 -0800 (PST) Received-SPF: pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) client-ip=134.134.136.24; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 15:25:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,258,1539673200"; d="scan'208";a="106328848" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by fmsmga002.fm.intel.com with ESMTP; 20 Nov 2018 15:25:52 -0800 Subject: [PATCH v8 7/7] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL From: Dan Williams To: akpm@linux-foundation.org Cc: Logan Gunthorpe , =?utf-8?b?SsOpcsO0bWU=?= Glisse , Christoph Hellwig , torvalds@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Tue, 20 Nov 2018 15:13:25 -0800 Message-ID: <154275560565.76910.15919297436557795278.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <154275556908.76910.8966087090637564219.stgit@dwillia2-desk3.amr.corp.intel.com> References: <154275556908.76910.8966087090637564219.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The routines hmm_devmem_add(), and hmm_devmem_add_resource() duplicated devm_memremap_pages() and are now simple now wrappers around the core facility to inject a dev_pagemap instance into the global pgmap_radix and hook page-idle events. The devm_memremap_pages() interface is base infrastructure for HMM. HMM has more and deeper ties into the kernel memory management implementation than base ZONE_DEVICE which is itself a EXPORT_SYMBOL_GPL facility. Originally, the HMM page structure creation routines copied the devm_memremap_pages() code and reused ZONE_DEVICE. A cleanup to unify the implementations was discussed during the initial review: http://lkml.iu.edu/hypermail/linux/kernel/1701.2/00812.html Recent work to extend devm_memremap_pages() for the peer-to-peer-DMA facility enabled this cleanup to move forward. In addition to the integration with devm_memremap_pages() HMM depends on other GPL-only symbols: mmu_notifier_unregister_no_release percpu_ref region_intersects __class_create It goes further to consume / indirectly expose functionality that is not exported to any other driver: alloc_pages_vma walk_page_range HMM is derived from devm_memremap_pages(), and extends deep core-kernel fundamentals. Similar to devm_memremap_pages(), mark its entry points EXPORT_SYMBOL_GPL(). Cc: Logan Gunthorpe Cc: "Jérôme Glisse" Reviewed-by: Christoph Hellwig Signed-off-by: Dan Williams --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index bf2495d9de81..50fbaf80f95e 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1110,7 +1110,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1164,7 +1164,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a