From patchwork Wed Sep 18 14:38:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 11150505 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D08D112B for ; Wed, 18 Sep 2019 14:39:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3992120665 for ; Wed, 18 Sep 2019 14:39:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4AGJTsD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3992120665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 280096B02C8; Wed, 18 Sep 2019 10:39:18 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 230DD6B02CA; Wed, 18 Sep 2019 10:39:18 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16DE66B02CB; Wed, 18 Sep 2019 10:39:18 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id EDE766B02C8 for ; Wed, 18 Sep 2019 10:39:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 98C72824376C for ; Wed, 18 Sep 2019 14:39:17 +0000 (UTC) X-FDA: 75948299154.05.news60_5117c7c3ba924 X-Spam-Summary: 2,0,0,93cfa6f04f38d11b,d41d8cd98f00b204,laoar.shao@gmail.com,:peterz@infradead.org:mingo@redhat.com:acme@kernel.org:jolsa@redhat.com:namhyung@kernel.org:akpm@linux-foundation.org:tonyj@suse.com:florian.schmidt@nutanix.com:daniel.m.jordan@oracle.com:linux-kernel@vger.kernel.org::laoar.shao@gmail.com,RULES_HIT:41:355:379:541:800:960:973:982:988:989:1260:1345:1359:1437:1534:1541:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3871:3874:5007:6117:6261:6653:7514:7903:9413:10004:10904:11026:11658:11914:12043:12048:12296:12297:12438:12517:12519:12555:12895:13069:13161:13229:13311:13357:14096:14181:14384:14394:14687:14721:21080:21444:21451:21627:21666:30054:30056,0,RBL:209.85.214.193:@gmail.com:.lbl8.mailshell.net-62.50.0.100 66.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: news60_5117c7c3ba924 X-Filterd-Recvd-Size: 4266 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Sep 2019 14:39:17 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id b10so51629plr.4 for ; Wed, 18 Sep 2019 07:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=quDi5FFcEHmlmH1e9u/MVGG/WChEumxXk9EifB9fhCs=; b=X4AGJTsD51BzXMVwK60Kca2mkVAorXHjtmOlaZmPsf02Km0NHNPnq13zWfat/YHbtE MV426iBdoaftcc9CNARoo9dNrKrwcZL4wBWxBcv93uDY1tG18vQdFyTr5wQz5d6/1lq5 3lQz/3U76yl0m6th7oYYIAGey6OJIu9/koqpHyYGIMnlIFoRXuty8rR1WIYFh0yF+GVB AhYxq+YLPDtaaYDt0eYStxC/EKX79V2fKip58qT/VjKFMF7VmJYvOuJXaJWGMI1C854P PfMMGrru9f7WlqiI2p3n2RWtbExtuQYTlaSnLnzYyKxhGMvtyzsu/7caN3OpTAvEUyUF oYeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=quDi5FFcEHmlmH1e9u/MVGG/WChEumxXk9EifB9fhCs=; b=B9yzyaMzj5byg4dZdYTVU4OY4O8jG6eS8hmukICF1UD36da0eET0kbpJyfZ+JcY1Nt YPiG1yC/bYAvd9u6YSFKtufSfmlMHm58F1cN8wfzM9Fj5q7filE2IiyMjPS2l0cxRrbP EkwVsKWuz8x+QgEA7Z3QdETPOsxMID+PzgZF1/+XeS3RwN25zexnlUBymDyG6a33sMVr eWQwHwZhpPxkjZsUf4qMizobFckbTAs/S+y5h6IyX7UOYR/Qg8mMR09CfQR8kKzj+oHR q2lZlRN87KkQdkphzNXXpoKK+u0HCCZfeH9LWbYuIiVc0/OsDCG527I/iRaXg12BBzCG Dhxw== X-Gm-Message-State: APjAAAW26oRjHJ2sL/O76kUyBVUJOJgHz05Fefr8kN1Q2CsG6K3kHxM2 WVLbEz8afmZ7CaxKG5jsWTM= X-Google-Smtp-Source: APXvYqzMwzc7yuyYjnb76QPE6ltH+wKNbQpk+wmIggNsOZEqgDsGe2eSrc7MLGYNJSazFP7gPANnIg== X-Received: by 2002:a17:902:7c13:: with SMTP id x19mr4662626pll.322.1568817556152; Wed, 18 Sep 2019 07:39:16 -0700 (PDT) Received: from dev.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id l11sm5272197pgq.58.2019.09.18.07.39.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 07:39:15 -0700 (PDT) From: Yafang Shao To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, jolsa@redhat.com, namhyung@kernel.org, akpm@linux-foundation.org Cc: tonyj@suse.com, florian.schmidt@nutanix.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yafang Shao Subject: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim Date: Wed, 18 Sep 2019 10:38:42 -0400 Message-Id: <1568817522-8754-3-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1568817522-8754-1-git-send-email-laoar.shao@gmail.com> References: <1568817522-8754-1-git-send-email-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently there's no easy way to make perf scripts in sync with tracepoints. One possible way is to run perf's tests regularly, another way is once we changes the definitions of tracepoints we must keep in mind that the perf scripts which are using these tracepoints must be changed as well. So I add this comment for the new introduced page-reclaim script as a reminder. Signed-off-by: Yafang Shao --- include/trace/events/vmscan.h | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index a5ab297..f0447ad 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -1,4 +1,17 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0 + * + * Bellow tracepoints are used by perf script page-reclaim: + * mm_vmscan_direct_reclaim_begin + * mm_vmscan_direct_reclaim_end + * mm_vmscan_kswapd_wake + * mm_vmscan_kswapd_sleep + * mm_vmscan_wakeup_kswapd + * mm_vmscan_lru_shrink_inactive + * mm_vmscan_writepage + * We must keep the definitions of these tracepoints in sync with the perf + * script page-reclaim. + */ + #undef TRACE_SYSTEM #define TRACE_SYSTEM vmscan