| Message ID | 1587349685-31712-1-git-send-email-qiwuchen55@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte() | expand |
It would ve great to keep the cc list if reposting. On Mon 20-04-20 10:28:05, qiwuchen55@gmail.com wrote: > From: chenqiwu <chenqiwu@xiaomi.com> > > Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"), > the assignment to 'page' for pte_devmap case has been unnecessary. > Let's remove it. > And also [willy@infradead.org - changelog] > Signed-off-by: chenqiwu <chenqiwu@xiaomi.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > Change in v2: > - According to Matthew's suggestion, update commit title and message. > mm/memory.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index f703fe8..2143827 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > get_page(page); > page_dup_rmap(page, false); > rss[mm_counter(page)]++; > - } else if (pte_devmap(pte)) { > - page = pte_page(pte); > } > > out_set_pte: > -- > 1.9.1 >
diff --git a/mm/memory.c b/mm/memory.c index f703fe8..2143827 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, get_page(page); page_dup_rmap(page, false); rss[mm_counter(page)]++; - } else if (pte_devmap(pte)) { - page = pte_page(pte); } out_set_pte: