From patchwork Tue May 25 10:23:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yejune Deng X-Patchwork-Id: 12278385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB280C4707F for ; Tue, 25 May 2021 10:24:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84AEA6142A for ; Tue, 25 May 2021 10:24:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84AEA6142A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 242F66B006E; Tue, 25 May 2021 06:24:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 219916B0070; Tue, 25 May 2021 06:24:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E2166B0071; Tue, 25 May 2021 06:24:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id D27846B006E for ; Tue, 25 May 2021 06:24:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 697F28249980 for ; Tue, 25 May 2021 10:24:18 +0000 (UTC) X-FDA: 78179368596.24.C18D914 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf09.hostedemail.com (Postfix) with ESMTP id 7CE72600025B for ; Tue, 25 May 2021 10:24:14 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id b7so11959745plg.0 for ; Tue, 25 May 2021 03:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cLiMXok1HQJuL5Rj9yY5lszCyh+gFs0zLJeC+o5z94c=; b=Bz/nbq1oGbrrm56CB2fKjHBESrj31Ydsy8kYssPxnd2xlnyPBFUjqX2y+LTxZ7PIy0 CGD4x4VnX8nEIFkdchkIVMwA8L7MPOUal2+95/85OEhUORReDUcoC5KnflVcvAWEQOh1 ecgmGIn4sqKtzH9/kGCwhAQQMBwTBSXwGxZqOPI/D5ULYR24NH7odd5panmBf70BITxz NEE/3mSPUMgjnNGRSiG2JhhhMJ3ERwuLi/9tFgeg9EzgUuNZJZua4/WbQ6MuITqKED6X DrB5QgR+f6L6SQU+0fzqbcRTz4k7SC8eg4KWGE5RiaVPFETbVhGB1QD+jLqwzdyFgefq FLJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cLiMXok1HQJuL5Rj9yY5lszCyh+gFs0zLJeC+o5z94c=; b=E+kBlcXzo2mPnqY/j18n2UzGQvH5cRI+B2/RPch2g8WSv9u6gHWOVlduTYWhOXaoXg +j01NoJCshAdwGMSfD8vFrgbS5FG/DhNdNtZTSu2Gu0vz3cHpYfkl+3/gFH16JW6LfBl DN3j2FrLckoNcYlHVtrTWYGpjxWWJZ2wnL7HdXIbL417YP6GknVkTPC0JT8QLI3bavHa MNlzCCtcqIgrl4/OKi/N2x79u6bqHKNmP5qtqHHhWIxd08JXd5TPQ034feKD4TVIyWbF 6tbF8v+/0MdQXE+fY7xa5rbfaUN0YkME8rODnuI0gY9kxB3oeRlOlyfsdkmCXCfWNSeP 4mVg== X-Gm-Message-State: AOAM531ikWUFbPhjWXwF+n7uQBJLCov5weQ76cn/PtGZLmNFNpNlndTO hwUe5pIxT0c8kXQ7QGP3GfccATphSbrOCJhHc50= X-Google-Smtp-Source: ABdhPJzOZGCs1ZL8oOqgsUOzWd1lleLZnaW16A6bNlsH1nuPaSnQ7ZNdEQWKMV8FvjR1cce1QrCQVg== X-Received: by 2002:a17:90b:33c6:: with SMTP id lk6mr29636485pjb.57.1621938256939; Tue, 25 May 2021 03:24:16 -0700 (PDT) Received: from sz-dl-056.autox.sz ([45.67.53.159]) by smtp.gmail.com with ESMTPSA id x187sm7821229pfc.104.2021.05.25.03.24.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 May 2021 03:24:16 -0700 (PDT) From: Yejune Deng X-Google-Original-From: Yejune Deng To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yejune Deng Subject: [PATCH 2/2] mm: slub: use DEFINE_RAW_SPINLOCK init object_map_lock Date: Tue, 25 May 2021 18:23:55 +0800 Message-Id: <1621938235-11947-2-git-send-email-yejunedeng@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1621938235-11947-1-git-send-email-yejunedeng@gmail.com> References: <1621938235-11947-1-git-send-email-yejunedeng@gmail.com> Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="Bz/nbq1o"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of yejunedeng@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=yejunedeng@gmail.com X-Stat-Signature: t5qqzwquq7ynram7jhg9i4zi5fwtxziw X-Rspamd-Queue-Id: 7CE72600025B X-Rspamd-Server: rspam02 X-HE-Tag: 1621938254-462119 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use DEFINE_RAW_SPINLOCK instead of DEFINE_SPINLOCK object_map_lock that won't be preempted on mainline and PREEMPT_RT kernels. Signed-off-by: Yejune Deng --- mm/slub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index c2f63c3..995f3d0 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -445,7 +445,7 @@ static inline bool cmpxchg_double_slab(struct kmem_cache *s, struct page *page, #ifdef CONFIG_SLUB_DEBUG static unsigned long object_map[BITS_TO_LONGS(MAX_OBJS_PER_PAGE)]; -static DEFINE_SPINLOCK(object_map_lock); +static DEFINE_RAW_SPINLOCK(object_map_lock); #if IS_ENABLED(CONFIG_KUNIT) static bool slab_add_kunit_errors(void) @@ -481,7 +481,7 @@ static unsigned long *get_map(struct kmem_cache *s, struct page *page) VM_BUG_ON(!irqs_disabled()); - spin_lock(&object_map_lock); + raw_spin_lock(&object_map_lock); bitmap_zero(object_map, page->objects); @@ -494,7 +494,7 @@ static unsigned long *get_map(struct kmem_cache *s, struct page *page) static void put_map(unsigned long *map) __releases(&object_map_lock) { VM_BUG_ON(map != object_map); - spin_unlock(&object_map_lock); + raw_spin_unlock(&object_map_lock); } static inline unsigned int size_from_object(struct kmem_cache *s)