From patchwork Mon Feb 6 01:02:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 13129228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A405C636CD for ; Mon, 6 Feb 2023 01:02:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B2966B0074; Sun, 5 Feb 2023 20:02:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 262336B007B; Sun, 5 Feb 2023 20:02:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12A416B007D; Sun, 5 Feb 2023 20:02:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 045E76B0074 for ; Sun, 5 Feb 2023 20:02:49 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA44D1608FC for ; Mon, 6 Feb 2023 01:02:48 +0000 (UTC) X-FDA: 80435067216.25.702AA3E Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf24.hostedemail.com (Postfix) with ESMTP id 9ABF8180004 for ; Mon, 6 Feb 2023 01:02:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e7t2nDwo; spf=pass (imf24.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675645366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SYcqHqXqWBmUxiNkmsR7zsutAFtrAKEoBuJf+0yeadY=; b=AOGibk8HqybjL56BWLnuVu5YOLhGLYK2gm7OsGwNKpdFuVxeCpwK/WjIhoQ/WqRPAlUJ36 Nb/L54j3szK0SzOx97KM/fKHQGlruv9fTuMsQ6N3p3j41llzVg0KhtE7yma6yhgFzOgQEI /jFSMiHNrkOpwWauFlK/VNtvk4Xpf9g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e7t2nDwo; spf=pass (imf24.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675645366; a=rsa-sha256; cv=none; b=b3qTRZIeA/olRTFxt6U9R20DF0KJymXe10PuBo1iTcA6vOCaxjUP/8VRObL65+bTGICbcc UWGV+Qgk6q2io6nofqAq327mxmFgCjWxu4aLwlt8dJtZNqll8KqSl6dzXPKG/BG+xzNB2r dmU3fV13Rtn9dIOk41QytgWEI0T/6vg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675645366; x=1707181366; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yb8ZrYfywa+KhatYaUiHluR1JdOlK0Jjr6L/f1PwJLc=; b=e7t2nDwoNb+uIEsh993w0izEa8mmYBvCqYCqwTBSq4PDXkOy/vxOB6oU wpd21Z4fF/iH0hBdxWocp3LViKoQDIMX3lXnJpj6gZHRjHB2ubl8TVBvt XOFMcPKyyp/DKBzzlyosbg4HVpjX5vTvG8J2AQ/rwbV6SD9NGB/gGYd3B jhrca1sILgvOUYmSpDrd8X0UREgYGTEQW31ik5RgQ6vlTqETADsRN2UJb wukBZvCO+XMkiZBJUYGJP6yelijxsi6DtaUixEbC8US5XT7NxlxKtr7me Cr2EKOXvWCKh2m9Y+xAZxE8M9+w/hjY41ON/80xpfzZveEE8EacckMD1V A==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="331243791" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="331243791" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 17:02:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="643855738" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="643855738" Received: from mkrysak-mobl.amr.corp.intel.com (HELO dwillia2-xfh.jf.intel.com) ([10.212.255.187]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 17:02:46 -0800 Subject: [PATCH 03/18] cxl/region: Support empty uuids for non-pmem regions From: Dan Williams To: linux-cxl@vger.kernel.org Cc: dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org Date: Sun, 05 Feb 2023 17:02:45 -0800 Message-ID: <167564536587.847146.12703125206459604597.stgit@dwillia2-xfh.jf.intel.com> In-Reply-To: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> User-Agent: StGit/0.18-3-g996c MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9ABF8180004 X-Stat-Signature: ysdraiedzhzqciz471ckpb8spjxy7tr4 X-Rspam-User: X-HE-Tag: 1675645366-840354 X-HE-Meta: U2FsdGVkX1+RMsA9PMwFvKORcmWnkGQT60XA+cIG3bzamcUg+3hdoymbVXfz+tkxtTdN90BvILeOBFlqA8VfFn7xN6YxVtXEY4oAyJt+q6NTX/cDBEp3wdYBepTb1pZH1if1eRJaFjalcoC35v0unvPcUHZ22HI8C7abbmcTamoClZ9L9rvFgCtKQbNkXeJ/lRfKy+nk8L2y7IbmVm40qqU0h5BqTzVPFCL2lZAl1iahO46wII2MvBdMZT8LkB9SinbOW4hM5hkMjHzK5HaMKYDnyJIBkpfZl4FJO8fYRZueVPsJ+zOA81oflxK1bIvhR8ifF4UDiCtW23c25lws2vbqxF4VIK8ORi/KlGxWbaoG9FiTqPw/qyn1rJgmAr9a/cwyq7D0Ies7huDpleP+u7PHIPrPkntf01KznE+RPnLRoLumBXqkKwlxhR+URDQYsZS8roZ/SImdiEWkZZgQBbGyw4nF3b7Hz06xw02tszbJ618QU2wBDQxtDTa5Wm58ZZlbBLHwp6FoX7TXTNtvZ3cia9ITUFUMfAx7jcTpC1uotUVP/XtO5pYd1x1aFuBIZDC8wPTOhNkLGo3/CILGffaXn+Ffc+tBHFHHbX3iSr5AUIbXx7c3wEWBEXhNj9ASPQ8TIQ+mZNglhSfDlhulVBqUgKDFMJRHyeJFvSbkxqmYX+9eTTf87mbr1rb+o9sNoR5GWDZ2mno8erWW8hJfgbk6iM33EwtDXcPPgwzeMawYBW4L97mrJkdQ9d+hJ6Rs9L53ZRbhuwVLLw4WpmhgIYgx5P2QVRFEWBBg/x/IdAFnBxHaJYa9VGptjN+QywKElfYphbglsDex1llqHtisTH3NJGtcT2sdbugnKkATcfhMEk14WK8bMC1y6vuL9RfIkE78AI8rtMNBMDMcp2f3PNOfS3qW54v0Ck2/Zx4iayXKCdTQJ9chseE8WucGmb6klwfBm2MhbKAYgClLPNI ha9lW1bg LcH6T/ZkM3sXy0lh5gGwENaRb3EvWX6hH5BVj5iYhQNPhnASxR7a0AicBHvfkPNTkCHprA/bSAhLzIVx7oN5cAMuYt07oYBv5L7HB9thZ9Kvc5Qr4W1dhCUYPOEIGQ18td/QBY9Hpp/oBIlpMClabtDlIykddzApDY24sxlR/1G2ZLXn6HX3h+LzaYZUao3EA9+GhHMefvlnTmjdb6Whe+vgNDWDms1XWZyiDNe9Q4AdVdc2sgqLXah7iwBVvbyebPvyK8SPFT2m9YeWlK/OwE7N1PvKcTlm3BvJH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Shipping versions of the cxl-cli utility expect all regions to have a 'uuid' attribute. In preparation for 'ram' regions, update the 'uuid' attribute to return an empty string which satisfies the current expectations of 'cxl list -R'. Otherwise, 'cxl list -R' fails in the presence of regions with the 'uuid' attribute missing. Force the attribute to be read-only as there is no facility or expectation for a 'ram' region to recall its uuid from one boot to the next. Signed-off-by: Dan Williams Reviewed-by: Vishal Verma --- Documentation/ABI/testing/sysfs-bus-cxl | 3 ++- drivers/cxl/core/region.c | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl index 058b0c45001f..4c4e1cbb1169 100644 --- a/Documentation/ABI/testing/sysfs-bus-cxl +++ b/Documentation/ABI/testing/sysfs-bus-cxl @@ -317,7 +317,8 @@ Contact: linux-cxl@vger.kernel.org Description: (RW) Write a unique identifier for the region. This field must be set for persistent regions and it must not conflict with the - UUID of another region. + UUID of another region. For volatile ram regions this + attribute is a read-only empty string. What: /sys/bus/cxl/devices/regionZ/interleave_granularity diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index 17d2d0c12725..c9e7f05caa0f 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -45,7 +45,10 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *attr, rc = down_read_interruptible(&cxl_region_rwsem); if (rc) return rc; - rc = sysfs_emit(buf, "%pUb\n", &p->uuid); + if (cxlr->mode != CXL_DECODER_PMEM) + rc = sysfs_emit(buf, "\n"); + else + rc = sysfs_emit(buf, "%pUb\n", &p->uuid); up_read(&cxl_region_rwsem); return rc; @@ -301,7 +304,7 @@ static umode_t cxl_region_visible(struct kobject *kobj, struct attribute *a, struct cxl_region *cxlr = to_cxl_region(dev); if (a == &dev_attr_uuid.attr && cxlr->mode != CXL_DECODER_PMEM) - return 0; + return 0444; return a->mode; }