From patchwork Mon May 8 09:33:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 13234267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70148C77B7F for ; Mon, 8 May 2023 09:34:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBBD86B007D; Mon, 8 May 2023 05:34:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F0D6B007E; Mon, 8 May 2023 05:34:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34CB6B0080; Mon, 8 May 2023 05:34:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C9316B007E for ; Mon, 8 May 2023 05:34:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4F64BA018A for ; Mon, 8 May 2023 09:34:12 +0000 (UTC) X-FDA: 80766576744.10.B4AD626 Received: from SHSQR01.spreadtrum.com (mx1.unisoc.com [222.66.158.135]) by imf12.hostedemail.com (Postfix) with ESMTP id 1296440008 for ; Mon, 8 May 2023 09:34:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683538450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05B9HLEVIXOyu73vSo8T/gNbsWk1TAFnDf+P1UFDg/w=; b=GRHIfcHspP7FFWBczjc7EcR4i4Wm8HlQ9yNzexwZBx9BjORGLcDY3jNHz9HK16ywtYm0uL GtkdLaXXUZpqI+NQooeyhBKTJ6qcER9Wb7aGCAy1o6iMdYZP8UQOfBZmLHbvtfLf/5apq4 FTqG7a3ENpZ1nk0dLReVC0NsIN0Dz6M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683538450; a=rsa-sha256; cv=none; b=B/Y6sSIMmo7ETLLcN5MttyOSqeqXeBEODEFdtBw7I79E7+2NBwsQPrbvMMArUUKMkgFaCX tRU3nWCd368M74KqMEBegSIQjxqlL/ktwuwqPZ+AjPNqqtk1WDqFkveKPZenNKXWrKQaGC vRkPOoVFpv0z6f/Yltf6XmWAGIPB5hM= Received: from SHSend.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by SHSQR01.spreadtrum.com with ESMTP id 3489XTVE033277; Mon, 8 May 2023 17:33:29 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from bj03382pcu.spreadtrum.com (10.0.74.65) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Mon, 8 May 2023 17:33:25 +0800 From: "zhaoyang.huang" To: Andrew Morton , Roman Gushchin , Minchan Kim , Roman Gushchin , Joonsoo Kim , , , Zhaoyang Huang , Subject: [PATCH 1/2] mm: optimization on page allocation when CMA enabled Date: Mon, 8 May 2023 17:33:02 +0800 Message-ID: <1683538383-19685-2-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1683538383-19685-1-git-send-email-zhaoyang.huang@unisoc.com> References: <1683538383-19685-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 X-Originating-IP: [10.0.74.65] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 3489XTVE033277 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1296440008 X-Stat-Signature: dde591hsdsy4twofhu4ky8qtn7bkh9p6 X-HE-Tag: 1683538449-763790 X-HE-Meta: U2FsdGVkX1+K84S2F2IsW70ImyPSYrXFr6M90a++qyl2MntnecuPevWc/wQRLksQUvsxEY/UZsoqfzw0eRZvK03uiC1CuZ4COacaKekEs4PRJU0+dlH9xWIkApUViHfS0Nj32KKOZr4KL37zbUxgawNWx9lnFNGFQ1R3Uf+PlHsliMMhBtoLUAkjIK5LqFMLVttKEE43QLA7bqsdUmndxz9F2PSRt6si8ULjd2vaNI5Ysmj5wdFWstyHXEAkruBmleABeaTuPaLNSLXS/m835q5FGcSWZYS10X/bxz0lXikNZvtWcV4Iiljq2P3OwHvxVpyPlhBuJSWuEji/YALqlVrPq2e9yY8BWKenNwx4/FkaRREEuphal45hwuvut41soNGH/QxTO0OGRXcSUx+CK6b6t0ruGhGjE2OiGo6iUNAhuBRbW9MXkkQSC9vWIpTnOSp71jV0PFrp0Gls+odqLtToOyJ0vNG5hxKDhLbmi2+Q+J7SfjllOZ3JdKiVpB4MPHdbjMPaSPYou5xq+7cDMq1AZ0hIEzj8gEPcE6dLL/05IIWPugqg2JoACp7I80Zilz9iw5isFhlBgaFBWCWnSMVUsv2/D87idA+XCMIGDEacLSsxZv49kl+MGl000PZhv+Au/xdrkf/w59XEBOS/RNrmia8wVTOQzpQQbg1U56YuPdq8r6p7gQo1BJPBxUHP4EmUdQZ2APwg4mWNlL6M1GTpeP49S4RK8v9hkwpLP7IYW3vNBbG5gOyH+hAdHr/QdK9C/5DJb9DuhQqttkuv0Lmmy3Up+PtRmeDkbhoEuBlAukG7Z3Ua03JEyTGrTNj5w6DLSotUCW2FcfzO6VMb06+beLf66LWJfqWu5mngbJmCFH/SqVj4ZRpqPK59o6VWILRVllEscCTl9ovVhLc2F0nUnmiBA3Fr9l3p2oSD04XPzYNoffZLjS0mE3txVvv9zmchkGl5ewhCib86ptE WBSlHmRb og6aurBH89AB+1Plfsntnjz+wOLZm2ovNqV4suSyI5RSZDRCF/xBrkYKKZiyuzv3SBD0KS1nHo46WvUWpjIxtFHFbq5nurvtKxiA93mxYpTeupGE07HexPy3XrtcjMFzGlewn5pcAT1nTd5bRvkMJVZlV73MTvcMypJ8NOD7Uypq/rS+LheYkZKcB9keV1yXOolkTXnz0XxYbJXXPCh+DzkYB4NuvuGqA9F/6kZxEd67jpo8ddXaUYvPSNmZtuKCUznm4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhaoyang Huang Let us look at the series of scenarios below with WMARK_LOW=25MB,WMARK_MIN=5MB (managed pages 1.9GB). We can know that current 'fixed 1/2 ratio' start to use CMA since C which actually has caused U&R lower than WMARK_LOW (this should be deemed as against current memory policy, that is, UNMOVABLE & RECLAIMABLE should either stay around WATERMARK_LOW when no allocation or do reclaim via entering slowpath) -- Free_pages | | -- WMARK_LOW | -- Free_CMA | | --- Free_CMA/Free_pages(MB) A(12/30) B(12/25) C(12/20) fixed 1/2 ratio N N Y this commit Y Y Y Signed-off-by: Zhaoyang Huang --- v2: do proportion check when zone_watermark_ok, update commit message v3: update coding style and simplify the logic when zone_watermark_ok --- --- mm/page_alloc.c | 46 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 0745aed..7aca49d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3071,6 +3071,41 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac, } +#ifdef CONFIG_CMA +/* + * GFP_MOVABLE allocation could drain UNMOVABLE & RECLAIMABLE page blocks via + * the help of CMA which makes GFP_KERNEL failed. Checking if zone_watermark_ok + * again without ALLOC_CMA to see if to use CMA first. + */ +static bool __if_use_cma_first(struct zone *zone, unsigned int order, unsigned int alloc_flags) +{ + unsigned long watermark; + bool cma_first = false; + + watermark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK); + /* check if GFP_MOVABLE pass previous zone_watermark_ok via the help of CMA */ + if (!zone_watermark_ok(zone, order, watermark, 0, alloc_flags & (~ALLOC_CMA))) + /* + * watermark failed means UNMOVABLE & RECLAIMBLE is not enough + * now, we should use cma first to keep them stay around the + * corresponding watermark + */ + cma_first = true; + else + /* + * remain previous fixed 1/2 logic when watermark ok as we have + * above protection now + */ + cma_first = (zone_page_state(zone, NR_FREE_CMA_PAGES) > + zone_page_state(zone, NR_FREE_PAGES) / 2); + return cma_first; +} +#else +static bool __if_use_cma_first(struct zone *zone, unsigned int order, unsigned int alloc_flags) +{ + return false; +} +#endif /* * Do the hard work of removing an element from the buddy allocator. * Call me with the zone->lock already held. @@ -3084,13 +3119,12 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac, if (IS_ENABLED(CONFIG_CMA)) { /* * Balance movable allocations between regular and CMA areas by - * allocating from CMA when over half of the zone's free memory - * is in the CMA area. + * allocating from CMA base on judging zone_watermark_ok again + * to see if the latest check got pass via the help of CMA */ - if (alloc_flags & ALLOC_CMA && - zone_page_state(zone, NR_FREE_CMA_PAGES) > - zone_page_state(zone, NR_FREE_PAGES) / 2) { - page = __rmqueue_cma_fallback(zone, order); + if (migratetype == MIGRATE_MOVABLE) { + page = __if_use_cma_first(zone, order, alloc_flags) ? + __rmqueue_cma_fallback(zone, order) : NULL; if (page) return page; }