From patchwork Thu Mar 30 10:43:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13193863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4154DC761AF for ; Thu, 30 Mar 2023 10:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D696B900005; Thu, 30 Mar 2023 06:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D193A900002; Thu, 30 Mar 2023 06:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB9D0900005; Thu, 30 Mar 2023 06:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ACA49900002 for ; Thu, 30 Mar 2023 06:44:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7AF83140168 for ; Thu, 30 Mar 2023 10:44:21 +0000 (UTC) X-FDA: 80625230322.03.D203679 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf04.hostedemail.com (Postfix) with ESMTP id 640A140014 for ; Thu, 30 Mar 2023 10:44:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=i+baureG; spf=pass (imf04.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680173059; a=rsa-sha256; cv=none; b=u24B6zsrZ3iWaGMeQJcQ7Ks9wHCkd9ag16nmEsUazcVnu2RISNpt+vl46FoNb/Xp/Fw5th Axkyac6A3WEH47m2OV17LW5L8QxmTB9c5R3Sxj01v5EVdAI5m7E3h3zZv8vSUzGcGhkwS4 3DTv591LK7b+0o6PuNsGCm8LkvC8xtU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=i+baureG; spf=pass (imf04.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680173059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rj9p2ML7UHam5+bM5W4iYW8IY6YeiyfeC2bpmKX2tVw=; b=pP4UWp+w4dk2dQMmbqikxw8aNyQO5dtXlPbX6hKot0Rt3XB5JkxKpUXDrcB5/oPQy+e+zC 7HtHiF75n/ssnSEo9SH5Eya9wr0lDo0bU6gk8jp5dyMsTkWMgCh5+1ahQlFlMXt/V/HkI+ 6sHSwgD+hvNCRZRmO6WAZoY5GiNdwXU= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680173059; x=1711709059; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mX1ugZUMlV3kS9C+vBwAioR51KxgcrVIz/0Juw9keV4=; b=i+baureGrXF/ZIHW41rfKyEOHJCvgtnB1JxGi24QK4VCWG6qtJFu35rk 6CtGSDJCDlADNKedKTqSX9Qi4U/h2gCTe5GF6BVHRG5kXlg7hISCxV/2Z Z4oEyWitv5wXRBxjCd9DPk6JVcSv9aokK4JzVEjdsXPm4EBdqyJlYg1lL tm/vy4TD58xWOVI5GDBKdHO5dbiIqRVLnUF9q+RgHUfN+B+1/HlLkHW6u dJxpgHbotTt/NQqiOB8EN4ndsO3dltCler+lGOLO88q8ug5W4+Tb6Xmr+ me96BuzcmOaf/pTKtAEMYqXWXicEKWPOYkU9QwpJXQRh7X2VZ/22k15Gr Q==; X-IronPort-AV: E=Sophos;i="5.98,303,1673884800"; d="scan'208";a="231853899" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 18:44:17 +0800 IronPort-SDR: B5S+MrWswuhnE8VtOcjamppvt2rs7y9rQRGuh8VzwGhzIf2HHZcI5Ku+0b2f7v7iqH3bEp+pZ7 w3Dm5FDGMYxioMWJaO69P7UTH3Nig6Mw4AUtO68RUdOFzfVEzAeTUrIrManNoXuykh6YUaOzNP 4VpLHr7HiOgU2mpImPrmLFKc5FY+j3/sgKtkIxncb7BmjVisyBoJcQ+ArT/FNESQxZpe2OxcqZ hA9KeJ/33hJtPaxhIXvx8k11JnGMSpZPLnm0CxWeKXWlK8axSm8720Sibrcx71GidKA8u7T4oN 7ww= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Mar 2023 02:54:45 -0700 IronPort-SDR: tGiYEQMjhW4+FrecuKxL+pgIOJGkToeN8EqS2UrmeIc+jDKs2LGUqC5wI3lkpfIG0rY9KtD7vW nIXhgAj3MxSOzjMcp86VQe4PR65gCJ8t/Hr1B/e2y6ez9iviPUznUuSsFvmn3O88X1mcUdVcMt QW0hYZrihvAJT5JS7wACEa1P+gmczN4rkDt/LCKCq32xB6tvek7oUUECHgErjCvhLuoZBvN/xK 9puzg1a+1RXgqpR24l5LZUwbmEKk1F58oXHxor04IMFieHnETCM2z+v6HEWQ9+B8eqMai+lo6B aDQ= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.72]) by uls-op-cesaip01.wdc.com with ESMTP; 30 Mar 2023 03:44:15 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v2 04/19] fs: buffer: use __bio_add_page to add single page to bio Date: Thu, 30 Mar 2023 03:43:46 -0700 Message-Id: <1848c9a0ec37fddf7bda3f97c6363a7de97eae19.1680172791.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 640A140014 X-Rspamd-Server: rspam01 X-Stat-Signature: bfkex4hr6sfpr7yeont3mhfuygix8uzt X-HE-Tag: 1680173059-296222 X-HE-Meta: U2FsdGVkX1+zPtm9pZlEj2bhQ8YfPLmJ9D1HMyVynQEyTrL1BlaYVgBhOH0DfWmDYulpYmVbRhYad+SDv8fyCoVBsQZFm3pxCC0fYjOzB4957dz9J6D40oQu/IPY2qNhfXZCbgK50FrqMo410MjGq8StyIGYGJShi3dCp0vUJYji54r+gmeM+1vk2JBJxzcSAx8VmHWia345bp+rjP33tU7Z9RPmMwRNI9vqmmuAEP26l+cLWYmO2XK1Ec45nODwI05P647NwYCxex4wPfOWyEhnSPl44pxowqECZBGYeDc+GVWXUX0PRmWBLj4DLugp0cjIX15JYyWJJdO9OK+Hitnv7gfMAW9gcaXgO7UoIeEWEjdp4JrR2KwAHdXI2h8XJsRQRKW7uc/hbY3Y7nS33dq6KHfgF24fTgIs2ek1oWXS5KFBDtUHV+C2shhM1OVqE9UYW5KjNRF8KpOss2Jzm92HGDesUsAQhcQLlxQ78GfNx2qIigVI1M2ezkBwpIllKSNRrNRrJNSIuIS7FpPakwHhn7CfkCX+JIuGw1EwgQsrYqYmkST9wMxD0u3g3STcMzxTuK/TCEkCn73w17SjE9Q/Pcqca8S1q9YUgXPNShSkKypBHqPY8ORH7frfJMbWPsuqFrlESBGbtDuv8XJVqJ2iNWbnP+tvzAXbN7pUI4ssRS1jM6iAVC3O03hFm/ZYZTZe/d3SRSzoLh/gaMI6H2evPYj2H0XIcAUMpsjnrSxrq9eLKKYjlCIIGsURo3mZY1/jyYa39rxmhnr2+vQaN1rdbEurwpWzEsRGCuBoaV1u1d/aXjH8pdEfyYlTGnOc8pe+quiTyr0LAsYAdZndu2zq4biCsX9FlxtHjlXxkX52BSDgkcmm6pWN0/4Lyb/8JOfT6iCyYQUnyIEqqys6bYEKftlkudXz6P4JM/HztpXSpqOC9E24kDNlogf5XnAkibkgqQ60XwYddwUsrp8 uZ4u2OJs ZounpJcS0El1JzrzYb5G0NBgBcKctwYhofMT5mqZgMwSM8t7sUPaBt7AhGk/n7MA3dJoH/01X0CXGyFIj+M7Nm/R1Sw+M4hFUNAt4sNMZ1+JK6KkdRRLbJRHxaUcSskq65jHMf2/juWQ0Xd+6dJGS9cDHllj27m0G8w7VrURhuK2CAcIiGMbPlrCl8MsDMQ2tImDwOS32AY5vJaao8PVkOCAums2o9LbS9/dBuZUvz5DgxJU6LT+M8t1Vg4Vxx7TpQost2r37f+EyMhPc94eOS+9SxymxqOdTR+SFW4mQrYh1ks6LKiHlcPeuEjfwHMXn20FmA7ciOQXWGgE1Gpftb+Cp5zZ7WUpe8XGewmlkUfMSf/3fO9pDNHZer3z3xviqZVKJ7kfcuXoavNq0o6Z373VX6qegxHuH5xLk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The buffer_head submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- fs/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/buffer.c b/fs/buffer.c index 9e1e2add541e..855dc41fe162 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2733,7 +2733,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9); - bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); + __bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); BUG_ON(bio->bi_iter.bi_size != bh->b_size); bio->bi_end_io = end_bio_bh_io_sync;