From patchwork Tue Apr 8 16:48:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Gordeev X-Patchwork-Id: 14043392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFFF9C369A2 for ; Tue, 8 Apr 2025 16:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50A4E28000B; Tue, 8 Apr 2025 12:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44006280010; Tue, 8 Apr 2025 12:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AB3828000B; Tue, 8 Apr 2025 12:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EBE7328000E for ; Tue, 8 Apr 2025 12:48:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE6071411D5 for ; Tue, 8 Apr 2025 16:48:37 +0000 (UTC) X-FDA: 83311460274.22.87EE576 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP id BD814160009 for ; Tue, 8 Apr 2025 16:48:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=npw3deZg; spf=pass (imf08.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744130915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pLqNtHwxdz+KjzF0o4al3IuUdgKeg437/opuwF8rOgY=; b=3xOaFJcTpZWuLIrsOLx/2RKhZLtJBzxCUno0hoRH9Lr4Fn8yJ/h/vn65lWUUQKjUNU0oPc vj8nJeMW7TTHQkaxHrNTsgP9O561AM2EcIaNhqV+8O2Id/f7ysGLEvm/UKFaE155XOAS4m OusfP6IE2cKqENFgsfHPYnT/j53YdK0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=npw3deZg; spf=pass (imf08.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744130915; a=rsa-sha256; cv=none; b=aO7jjXg0fXOj2lCRBikW1ZrkzNoWMrfENCHw8UkDM5Q+glUYiBGqs4hVyZkSQmUtBB8z5p 4PQ3GA97vwXQfHoXDSGdRn5P2eAy5PV/NdTaEiUI1WlDLw4svb4AhuJ/W8D1hO3yedixN2 ++6h35aq0/21/sQgSmolbuwUHPcMbVs= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5389aNfO028866; Tue, 8 Apr 2025 16:48:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=pLqNtHwxdz+KjzF0o 4al3IuUdgKeg437/opuwF8rOgY=; b=npw3deZgeMGx00Ar/mKuWmvCigPm0u2VO Ii52mQgYTAomVmfOm48ZVhxMbdrQ1GUR6Emzc9NVGE0oB2iMPDc2Ap+aPS38b1WT bsG/3vET2Rw+QSe7dwDMHqy9A2D/uqI59oqS23wwBOQyEMZmCTYEkgRBbKJhQ+Ol /2xtekq3+cuoDT/Ge8MqWCp0Uir/u23SHYcb/QhZDJzdZjUyRKqwsHKen7EcN0YA GwWtZetcyB60xluns20Z4kL84aR2CdgE6J4ri4Zsg+civDs0WFEAWiiwOffZIJvz KlqErpfaSdF/gjlJnP25WvspGWFGv7yL3NJk3GQCb3UZFEjntAXew== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45vnx0mumr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 16:48:34 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 538F8unP024583; Tue, 8 Apr 2025 16:48:34 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 45ueutbt19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 16:48:33 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 538GmW6I51183992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Apr 2025 16:48:32 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 430D820043; Tue, 8 Apr 2025 16:48:32 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 317F820040; Tue, 8 Apr 2025 16:48:32 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 8 Apr 2025 16:48:32 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id D3F1DE0577; Tue, 08 Apr 2025 18:48:31 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org Subject: [PATCH v2 1/1] mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context Date: Tue, 8 Apr 2025 18:48:31 +0200 Message-ID: <18bf936f63e0d1e53d8291a3bc2ee2c577876d9c.1744129955.git.agordeev@linux.ibm.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Yis3B4fiIrhXZdJ58ZjXe__p4Xw6AsHO X-Proofpoint-ORIG-GUID: Yis3B4fiIrhXZdJ58ZjXe__p4Xw6AsHO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-08_07,2025-04-08_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=777 lowpriorityscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504080114 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BD814160009 X-Stat-Signature: kqupby5uh7mgnnar43fowy5emstd4mcp X-HE-Tag: 1744130915-505615 X-HE-Meta: U2FsdGVkX1/uv7Q8TJAYElJ/sPmtLI3jRA8wm6+SjnGXmpgXE+EhZHBtfHVEnrtSr1nBMRfdApF/rIZXlAZLUyne0LzCCPTw+LLioxrNvAPwDQxB6DZW3UUVanhtJcPW7DADyqf0tc+V57c1B2M0m4kyY+TrKGtSS4mrGq4pnpaQMECPxVdxdqnAZqIw6+vhD8EYAEFzywuDBf95RNFCRfnV0cpZRjK4vrIdiLnOR+JDjM02Ow9JQu1qjNoXophkOlY4P7AksTz740EWEIarHc83aWvnepzZeVJGXlD774Y9svRfHiMxkzKsCMhGJJdqPBYH+jZnqNtT20E28O0c9lLxNvnTwiW1JFNF+UbiSeRIA5vHYk5Bl/H4YhMsXaAMJo4S/Tv2vhotjuIfvOvGFdXy0lbjGJGkZ+qAiaIk1N9Y1DP3++zjIkjQ46o5AgTAkd70UUURX01zVZpXcK9O05Higs/poDHMFWNEVxkTubfhA7J9s8/YgfeUbpnSCdwoO8dkQt+gVQcgJYWBA0dQuz5QLFtIK49XOmmpCTlZQ5RbBNH/PBVUSswIFvxVXPy4v8DwJpe65cs9OQMT8wLbW85MkhuOoz2tZMA0i3V7GGCJLr1djrJcqN2y8PB2IQ/4oPSrJXpzvmhr67UmsOrSNnVLWMlymMqQNDODs2WI6fQHmYqYGqEML2PM7aIvPJH23HX7dKvCYm5o0u2jfCMedGh1kugf4rgmbFbTqucAylCzv0cFR3ZQqrYKytoTrNi2EyWlK5wWpWabkR2z2yyspmQ2HaH07nURqC5H1iUetyIHcijK/7WrjbJ+5IiVDH3xlJyNiYlrhUMPAL4wLKNjzrJLxtJxyV7dSkYpTLMIOLrhrWswMqwaW1B6Qd47ZFMW2cJOlCsuAh5gbViOP/l8/CYdBirTjGyvZMYdzMXB6UrqXzZo9kqt/jwKc6o97HmO1Cq0AYNna+RGd6oGxn2 t2Pnc7gr zrm/H9TIOI3n4ULcGukBjRQ4nfC8zxhNCdHv8nRrLcjQivwAyZnGt7EBJFP+YlFp9fgCc5WPAzFewfgGOC3lpIxrlyRB9Hc7dCESm6r7M6sScQypKACJZ6eCO0BKQmo8U2H1rAAf8MSSl+9vbilWzx7InXgfhrY7RJBtgLmhVtiZORi+IokweE0OlYmgtWciRtSPA3dcqnoqWeZD4r+eDfdQeeWni3MqKPiiTTKYrADPehVOpiOBQWLu0fM4aQQMV/IqDP1aRMQnoIHTmqNBzQYSS4JHA1/OXZS2eOkFmM7xJKXbP8J4VGc2T39BAb2r5BOCiU/+Tx8ZhPm+JapDPitKk39tkoO/4fraXXiY8JfjSHNSgKK7j0KGa0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The lazy MMU batching may be only be entered and left under the protection of the page table locks for all page tables which may be modified. Yet, there were cases arch_enter_lazy_mmu_mode() was called without the locks taken, e.g. commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash lazy mmu mode"). Make default arch_enter|leave|flush_lazy_mmu_mode() callbacks complain at least in case the preemption is enabled to detect wrong contexts. Most platforms do not implement the callbacks, so to aovid a performance impact allow the complaint when CONFIG_DEBUG_VM option is enabled only. Signed-off-by: Alexander Gordeev --- include/linux/pgtable.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index e2b705c14945..959590bb66da 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -232,9 +232,18 @@ static inline int pmd_dirty(pmd_t pmd) * and the mode cannot be used in interrupt context. */ #ifndef __HAVE_ARCH_ENTER_LAZY_MMU_MODE -#define arch_enter_lazy_mmu_mode() do {} while (0) -#define arch_leave_lazy_mmu_mode() do {} while (0) -#define arch_flush_lazy_mmu_mode() do {} while (0) +static inline void arch_enter_lazy_mmu_mode(void) +{ + VM_WARN_ON(preemptible()); +} +static inline void arch_leave_lazy_mmu_mode(void) +{ + VM_WARN_ON(preemptible()); +} +static inline void arch_flush_lazy_mmu_mode(void) +{ + VM_WARN_ON(preemptible()); +} #endif #ifndef pte_batch_hint