Message ID | 20180518164830.1552-28-hch@lst.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B632601F9 for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 18 May 2018 16:50:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C6462844E for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 18 May 2018 16:50:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 711E7288BD; Fri, 18 May 2018 16:50:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 011DB2844E for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 18 May 2018 16:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C4D6B062E; Fri, 18 May 2018 12:49:58 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B4B6F6B0630; Fri, 18 May 2018 12:49:58 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C9306B0631; Fri, 18 May 2018 12:49:58 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f70.google.com (mail-pl0-f70.google.com [209.85.160.70]) by kanga.kvack.org (Postfix) with ESMTP id 5219A6B062E for <linux-mm@kvack.org>; Fri, 18 May 2018 12:49:58 -0400 (EDT) Received: by mail-pl0-f70.google.com with SMTP id i1-v6so5353260pld.11 for <linux-mm@kvack.org>; Fri, 18 May 2018 09:49:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=4d92gz5FcfVDVVFBdsw4sS4Q2ll0I9g6+oG5w6eOyfg=; b=kzXaMZujjI9gkWRIaGAHKRsCjziyJzTfU51ev+qWV804pfPna/ArWPzlnB+NJOLiEO n0rP7/tzai+TXvEi0FpYSMSyst00U99MmBESEKNvfrm1/u0YOTIemS9KxKoitTwBk4jt Ld0khsucx2m8WWmOvSSe1HwlvkIw3NeRqCpNg9UQQPqlJSQ3gapJyk1HIIvznpyMK9dv mAoeVBTKaDOa6H2t1lVliv4MxEp+zBn/1/3LZM69AaCqGsuretGercIIo29H96HHuJYY qmANAM7JzIXCLXodj+ihnTq6KzlC/Vl4YZ3SY9k5DuR8VXl1EsGW5lQVsaZV/f/6ZbSh gsQg== X-Gm-Message-State: ALKqPwf9jXbcV6/gjkgAq47qjgbheI94edNofn0sVo1wClQ68LwNlubk ayk1Smq0ENeFIPT48sScYQ4+OfvnT/JXw6TaIYnM6DOU/3mZf01XfF6Fy6VHIqsNqwCh3MtK5O1 31nSIEU1SoKyDgi9lXAQEJuKrWA6z2vMNhLRlgtubE+VSVWuJTGZrF+/TXuxO1zg= X-Received: by 2002:a17:902:b490:: with SMTP id y16-v6mr10182643plr.92.1526662198061; Fri, 18 May 2018 09:49:58 -0700 (PDT) X-Google-Smtp-Source: AB8JxZooxQ+Ca5itRcwWHcuYF53Il9nfh6ex5IDMa+MVLZCBIrkZJmIAJJo2ogFhpIzkHizM54sd X-Received: by 2002:a17:902:b490:: with SMTP id y16-v6mr10182608plr.92.1526662197362; Fri, 18 May 2018 09:49:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526662197; cv=none; d=google.com; s=arc-20160816; b=APB/j5ZjMdicojdDTu1x3d3Br2m1basglGOMzu+OvZcp4mhxH/f+H8MvRYktrszPtg TuFTIA7LLBWx33PLYQiE3Np/28eloEdKhqFXzMjUBS4VNHPB7pBj3J2k9aQSfK0/8hcK c8PS7hSpzGZ3RH/9iMEme09nZWedoNPHVfBLIS7jbtCQn8kO10cdlG33486+rzOhBtOv FQPuPKWIquDtnpHmq/eJM+La2L448e7LC1QzIvRbRbPwM+WjPDiTH3r0uOvMSL+u0k5g nD3NRsWYiqCud4I3aLcy+xcc3h0GxIIp3/E+BlkwADA2vhx2ZhITJ0xhD5JscOc6GqgW W+BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=4d92gz5FcfVDVVFBdsw4sS4Q2ll0I9g6+oG5w6eOyfg=; b=KDEAHq060RSEYcDiDn39V7pQd+WJTHRp64JM00OmUjEStPxLuLXb0eEsGXKtYo/MWj 7ufuA3unhoUCEAyTFMYXmxKFev8+jJMYf31VuhBEG8x325UhrroSMyELtnpCSbQCULaW WDR9NJCwmzPMjjFh8F2BnjbGrsWNKVHUI+/VWN2y5EpSdDIH7D7u6Do6ECjyldTqgz4m FOGkuZctFXsnehn1Uk74LU/2tcuanIUj/ukLjq73KF11lBrcQF/ir8i4rr98/LtoCBI9 5aP8tnk6NnAWudkdeTequgnjOB0rqJigMXWVi+Q+K/9kMUu4knuWGdNiKZDtI09zJHxU cliQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=rHg0xNU/; spf=pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id f2-v6si8557770pli.569.2018.05.18.09.49.57 for <linux-mm@kvack.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 May 2018 09:49:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=rHg0xNU/; spf=pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4d92gz5FcfVDVVFBdsw4sS4Q2ll0I9g6+oG5w6eOyfg=; b=rHg0xNU/IZMmukwx3MesQvBle JGu79kzcdNiHNgn9KKc8M4XwEnoujWXNOssSZhdHJ4/OngqWK02NVFD8+EpgftcmW7Blu3XqcREcr hepl5QlzHO2zQJyz1Qye5HMQY/oJ9RbIEGyWg8Yo1cpyIjH1WB02dNPGxMzgPuKqj+72NBBQ+ixFt 431oek6XmVmsz3Ws9y9haV7rv0Y11j0+/Yz0/GvLCCfjwIJe2kZhEJwOyIHf+N2KsSKX/ENygQl0i W2NitwwES5WfQzpwS6n48jsi55D20OeBDa3iu87UHTEB2fLJuPcfWNDtmI8MlwObANnKpLCndT3pg RDr9UgaZg==; Received: from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJiZl-00070X-9i; Fri, 18 May 2018 16:49:53 +0000 From: Christoph Hellwig <hch@lst.de> To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 27/34] xfs: don't clear imap_valid for a non-uptodate buffers Date: Fri, 18 May 2018 18:48:23 +0200 Message-Id: <20180518164830.1552-28-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180518164830.1552-1-hch@lst.de> References: <20180518164830.1552-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index b1dee2171194..82fd08c29f7f 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -859,15 +859,12 @@ xfs_writepage_map( break; /* - * Block does not contain valid data, skip it, mark the current - * map as invalid because we have a discontiguity. This ensures - * we put subsequent writeable buffers into a new ioend. + * Block does not contain valid data, skip it. */ if (!buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); uptodate = false; - wpc->imap_valid = false; continue; }
Finding a buffer that isn't uptodate doesn't invalidate the mapping for any given block. The last_sector check will already take care of starting another ioend as soon as we find any non-update buffer, and if the current mapping doesn't include the next uptodate buffer the xfs_imap_valid check will take care of it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_aops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)