From patchwork Wed May 23 15:11:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 10421825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A1E7C60224 for ; Wed, 23 May 2018 15:19:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 931CE28F48 for ; Wed, 23 May 2018 15:19:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86EB328F5D; Wed, 23 May 2018 15:19:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBBCE28F48 for ; Wed, 23 May 2018 15:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 091A16B000A; Wed, 23 May 2018 11:19:32 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 019026B02A9; Wed, 23 May 2018 11:19:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFCBE6B02AA; Wed, 23 May 2018 11:19:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id AFB136B000A for ; Wed, 23 May 2018 11:19:31 -0400 (EDT) Received: by mail-qk0-f197.google.com with SMTP id u127-v6so22831628qka.9 for ; Wed, 23 May 2018 08:19:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=mRHOd3ID8KeFQfhWoqrIl2xzZTJODTsdGMJvfgkFVKI=; b=i+9ii18c2vdlQQbFYfXgkudeORfTR3auhtgbTDpglAMibqVUQs5xbfeYuafuB0Z/Ms ENUT1JPkhILC4/6tFB0Hdt+TYxNKpQ9Sp/I9y4Lhl2DPolwnjtVhWO0iu0QZc1KeY+Xj KXBrGCVZF55n3VACAykvzxe0C2CYCvaGxpAUYDU5ptYC0k7vhuRs1fPEnYL3wZ9FvOSx 0dKCHTvz/oFEy5YmxWFCcAKD78YnH6R7yiuNXWYa1dh62wiSWD4Hiy/Xx6n7XsLlOD4x QtxlM/y4utIOTskS3uE21KDMjddRQ348H/I9NKvFkECrPJEbETwsGv/k6Sn3gphbSFFm 7g3g== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: ALKqPwdXXbwvDTuXMd48+w92FcvaXfVy8Crili2/bfNvn73QCvdYR3ha J9omeTufZJp3aS5wdgqqfdVXfh6PAAfyG0VsOLEXrbeCZfkA0kPATbA3NrnSU014KtLz+JugsfF Ptrnok+SCxMBlenrUHR/i/BvjojrB5vwZDpW1kcp6Ma2SbMBBBAiJZxktFxdNxLhz8g== X-Received: by 2002:a37:328c:: with SMTP id y134-v6mr2909748qky.411.1527088765139; Wed, 23 May 2018 08:19:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLEa3p/9D46vxxVFBMJ0QFmX+wqS9ZjDnJBdhwrdM02eIya6rhmgqgLU7uuHQnf+/t/ZEwv X-Received: by 2002:a37:328c:: with SMTP id y134-v6mr2881514qky.411.1527088348868; Wed, 23 May 2018 08:12:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527088345; cv=none; d=google.com; s=arc-20160816; b=wiQLqBLsNgF3pNxmVvUw2gfn0pKZuW3SmuxKyElbkHxwpsmn2nnsT8vv6ODksCZbEL fAsoCOTi5JJ+wAVKx8wllZuCEC9e2S8DFsq4+Q+jnE+Nupp8E/Cx2bj/c7SGhpFyE++/ 6Dw2XF7KsFnKTdRnmjeE2qeLNi4vjfDjM9XC6btX66pts+xHLqt62JZrPnfuI8szJ2Fb WYt5UyptR5U8UKmFEvDKT/avmAXGuKX/U//hRfgF0CvOHFDB8fjjfyDeJI0pCt9BW4p5 lDVoC2Q4XqlFT4sjupPqdRHNkM7iGWTl5XanwsRBVhoZr2aXU4jarUJarm1VTS9hJYQN SnIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=mRHOd3ID8KeFQfhWoqrIl2xzZTJODTsdGMJvfgkFVKI=; b=0wSwy8rarTYVIanf3epyiS1KWP5F0bRkiS3xYjPBLy605eyIyebEK/DftbIUkZy9HS OrWrxrbX1dCmPYYP0QyU5ySg/snGF/Tk4DBxfQVe4bI3BXJnd2sbL3tj0c9RnZehDXKF ASV7f1+TAB4YHkW0k4YslLt+YCSBAUuPzvbkx7du1h+h+qxetGzWu87tpKX8qlOxXven WOzKUtKMgky6ltzhyXyIGv9XJ555BlBCdpQQ7iJcqKu4qiarDYx9kHp2H3OkcOXFPPj6 XJwNUDsfizIbWP40S01nsmVq0W3NXJmBUBrwbTXVvRuAgM/45YC7+3mbZoexBo+eODhJ ugeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id k2-v6si7245305qkf.87.2018.05.23.08.12.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 08:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) client-ip=66.187.233.73; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13AC3401EF08; Wed, 23 May 2018 15:12:25 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38AC010C564A; Wed, 23 May 2018 15:12:23 +0000 (UTC) From: David Hildenbrand To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Michal Hocko , Vlastimil Babka , Dan Williams , Reza Arbab , Pavel Tatashin , Thomas Gleixner Subject: [PATCH v1 07/10] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() Date: Wed, 23 May 2018 17:11:48 +0200 Message-Id: <20180523151151.6730-8-david@redhat.com> In-Reply-To: <20180523151151.6730-1-david@redhat.com> References: <20180523151151.6730-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 23 May 2018 15:12:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 23 May 2018 15:12:25 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Let's try to minimze the noise. Cc: Andrew Morton Cc: Michal Hocko Cc: Vlastimil Babka Cc: Dan Williams Cc: Reza Arbab Cc: Pavel Tatashin Cc: Thomas Gleixner Signed-off-by: David Hildenbrand --- mm/memory_hotplug.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 8c0b7d85252b..27f7c27f57ac 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -943,9 +943,11 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ ret = memory_notify(MEM_GOING_ONLINE, &arg); ret = notifier_to_errno(ret); if (ret) { +#ifdef CONFIG_DEBUG_VM pr_debug("online_pages [mem %#010llx-%#010llx] failed\n", (unsigned long long) pfn << PAGE_SHIFT, (((unsigned long long) pfn + nr_pages) << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_ONLINE, &arg); return ret; } @@ -1668,7 +1670,9 @@ static int __ref __offline_pages(unsigned long start_pfn, offlined_pages = check_pages_isolated(start_pfn, end_pfn); if (offlined_pages < 0) goto repeat; +#ifdef CONFIG_DEBUG_VM pr_info("Offlined Pages %ld\n", offlined_pages); +#endif /* Ok, all of our target is isolated. We cannot do rollback at this point. */ offline_isolated_pages(start_pfn, end_pfn); @@ -1703,9 +1707,11 @@ static int __ref __offline_pages(unsigned long start_pfn, return 0; failed_removal: +#ifdef CONFIG_DEBUG_VM pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n", (unsigned long long) start_pfn << PAGE_SHIFT, ((unsigned long long) end_pfn << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_OFFLINE, &arg); /* pushback to free area */ undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE);