From patchwork Tue May 29 21:17:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10437067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0B12A601E9 for ; Tue, 29 May 2018 21:17:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F067C28991 for ; Tue, 29 May 2018 21:17:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E52122899C; Tue, 29 May 2018 21:17:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 425FA28991 for ; Tue, 29 May 2018 21:17:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE3196B000C; Tue, 29 May 2018 17:17:33 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id A13856B000D; Tue, 29 May 2018 17:17:33 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79E396B000E; Tue, 29 May 2018 17:17:33 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id 49F5A6B000C for ; Tue, 29 May 2018 17:17:33 -0400 (EDT) Received: by mail-qk0-f197.google.com with SMTP id y124-v6so14509548qkc.8 for ; Tue, 29 May 2018 14:17:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=ZEQhu3WT2vrLlb25BDJ81qDNzncILk6QIrMc35SIdhE=; b=MCRdPGpXlRqRMBQcTVGkraQaKOP67IrfcPOgReCNCa4UBBoj2TBBDmVPB51XLGQ88S GP/WhNmfoCWcPrueXzaIwQIpi/57J15g2/6UbqRadUELJBKZbvryaNeKmS2/udPbLNdq qyU7FbYF4BgsHabHXkS9+nvoKzTuBCGb3KQbEY0DwJOUTD/2cux+pLDMFFuADb/WGsnq HoRseXw2+XVtgSJBgpdXzysQSfzJ9rE7ORmf+uKgggWUQ9X5kSPQOoPYZ5CYkwFONGNM 6vcVxdSCqN0S6NjDfLaRKofaJIU464gnCb+uIHA1KQqI3F5QnwOQ7LcUNWh42YtM+smn wdyw== X-Gm-Message-State: APt69E16Nhs8wCooDvAd9Iijwxvng1agG3I7+4gZE/eGvTpJPmc02/5G rz8WJBH9lqp99jJWJbReBG0I3a+WzfRGRt00T3kbmqUOChyuIkrP8SCt2x81ZsxrBScIpA5H33Z 1L693UuaLXtq3SbAgPlDb+tUySqMIBqT5qC/tdWPLcbPbOvZpaiitD/TIK6k7R6S4FxfYq8rygZ XdWMX+BnFzJVzAoqZxn5E9SHCfBVxhNO2+gAXRGaBohgSQgMKOg4QgFBdrc+wvsz0vCowhYsX1M KyoqSko7JggVHwJs3GfejDe9Q+Qvat4zuS+SQo4W85u8aB9+XiuP7MZSQ8JzMA0jADCtj0Ymqgc dTDO18SL3qbRMt6rTm2Iu0MSnTs63Abht46FzTGPcC0NBlW7IKkXDAMfSnKQdFwJrm0nK99xLwI + X-Received: by 2002:a37:4385:: with SMTP id q127-v6mr44225qka.315.1527628653072; Tue, 29 May 2018 14:17:33 -0700 (PDT) X-Received: by 2002:a37:4385:: with SMTP id q127-v6mr44197qka.315.1527628652418; Tue, 29 May 2018 14:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527628652; cv=none; d=google.com; s=arc-20160816; b=KtxNDDM9Zc4zHcEpQxetB+0DpIqrZgJQ1ddXShn451OBpQyt2Fkkwb54ldT7Pk47Hq FpoJ7zrvKHS3pJRs7oLqekW7NRsMEyXdDIo48XTUbgE9g/16SpIFdAuDlEA4BF3C926k zzW9Z6BFsFauEAr7B/Y4EtDeQACyuAUIx26vSdPBhHXhAgiSit8TXqxcnuAxJV1nPqNz phFxNYKwCzlpu+nz8WBDtz3vUW8ya/4Rkm5hu20vzGs6egVwNR6kvREMa0uJGdqlRYSH MnRHMtChZvdSiUbxRwrG8BsYgZHs7VLQcBWLCfbgnLpGFwZkmxtRq9EQHS1uPVQ1+9I2 5u6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=ZEQhu3WT2vrLlb25BDJ81qDNzncILk6QIrMc35SIdhE=; b=wMKnMbpWsTYZ3d6smaAhUGe9/oJmikNtzfsZVGmZEv53xWrQS/KRAGmVHDkginB+u0 Mdv/ENqtZDg2g/bG/GnTZtb2RhF38RwjnyYUBFq+/YBViczSjFkeWYvwBkIaCGH7xe+0 jmzKfWSc86C8F57dcKEt8Dc/a/YgSX8U06I2HH6NkQuO3x9wLRXaate18iWd0f+/SB1U yCAeRIVEV6GsNmwyz7AEfqH7ISHAVZ5EdDZ/fW7Rcdavy28cjnbPl7YJ1CoTCjcUNZ4C QYBzcVt3ynVHKkQyircPHy/WJ6ZJ+wBYAw4aYVdiZtKe3W4GqcBTf21W9u7rMFscXTXL Cm5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=R2GbRWyY; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of josef@toxicpanda.com) smtp.mailfrom=josef@toxicpanda.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id k195-v6sor125484qke.53.2018.05.29.14.17.32 for (Google Transport Security); Tue, 29 May 2018 14:17:32 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of josef@toxicpanda.com) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=R2GbRWyY; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of josef@toxicpanda.com) smtp.mailfrom=josef@toxicpanda.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZEQhu3WT2vrLlb25BDJ81qDNzncILk6QIrMc35SIdhE=; b=R2GbRWyYGljhw+xZUkDdu2tAceCVGfM3u403a6pJoT2Hxo+wEJXn9afo9tERKc8RGU KjD40vAZNS0BmxGN6AYvA6U0puU76/m8dMIutyoV422lJIdGAAfRBQsKxpndmPaCXl42 tEGbY+Sy+jH3yrgLu8rTLEVXzAcoUgNML9y2Shwr1KItgi+3DBYgMC3HDshNmjk+FOPP fUFdT1L6ALa4CrlWbUHfzMm1y0T0WG2vvJnS5AVbnArxaTy7mjJJ8EB74cl8AZHJv/fK XvJMW8R3fNCG+LHDsqu9Rl3ktZZMsBzfc7D7+OlmwNPVxGy2M7UvOX9pcUbQsTOpS2MU r+jg== X-Google-Smtp-Source: ADUXVKLMnDmPk/RWV1FW8yuYFHneMOc44iW8G2K7SDgynYfAML7OndSO/LoIPX21kGYZ2VBFGJ6K+g== X-Received: by 2002:a37:2545:: with SMTP id x66-v6mr85417qkg.190.1527628652161; Tue, 29 May 2018 14:17:32 -0700 (PDT) Received: from localhost (cpe-2606-A000-4381-1201-225-22FF-FEB3-E51A.dyn6.twc.com. [2606:a000:4381:1201:225:22ff:feb3:e51a]) by smtp.gmail.com with ESMTPSA id u192-v6sm23559749qka.55.2018.05.29.14.17.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 14:17:31 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, tj@kernel.org, linux-fsdevel@vger.kernel.org Cc: Josef Bacik Subject: [PATCH 03/13] blk-cgroup: allow controllers to output their own stats Date: Tue, 29 May 2018 17:17:14 -0400 Message-Id: <20180529211724.4531-4-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529211724.4531-1-josef@toxicpanda.com> References: <20180529211724.4531-1-josef@toxicpanda.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Josef Bacik blk-iolatency has a few stats that it would like to print out, and instead of adding a bunch of crap to the generic code just provide a helper so that controllers can add stuff to the stat line if they want to. Signed-off-by: Josef Bacik --- block/blk-cgroup.c | 52 +++++++++++++++++++++++++++++++++++++++++++--- include/linux/blk-cgroup.h | 3 +++ 2 files changed, 52 insertions(+), 3 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index eb85cb87c40f..9e767e4a852d 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -954,13 +954,28 @@ static int blkcg_print_stat(struct seq_file *sf, void *v) hlist_for_each_entry_rcu(blkg, &blkcg->blkg_list, blkcg_node) { const char *dname; + char *buf; struct blkg_rwstat rwstat; u64 rbytes, wbytes, rios, wios; + size_t size = seq_get_buf(sf, &buf), count = 0, total = 0; + int i; dname = blkg_dev_name(blkg); if (!dname) continue; + /* + * Hooray string manipulation, count is the size written NOT + * INCLUDING THE \0, so size is now count+1 less than what we + * had before, but we want to start writing the next bit from + * the \0 so we only add count to buf. + */ + count = snprintf(buf, size, "%s ", dname); + if (count >= size) + continue; + buf += count; + size -= count + 1; + spin_lock_irq(blkg->q->queue_lock); rwstat = blkg_rwstat_recursive_sum(blkg, NULL, @@ -975,9 +990,40 @@ static int blkcg_print_stat(struct seq_file *sf, void *v) spin_unlock_irq(blkg->q->queue_lock); - if (rbytes || wbytes || rios || wios) - seq_printf(sf, "%s rbytes=%llu wbytes=%llu rios=%llu wios=%llu\n", - dname, rbytes, wbytes, rios, wios); + if (rbytes || wbytes || rios || wios) { + total += count; + count = snprintf(buf, size, + "rbytes=%llu wbytes=%llu rios=%llu wios=%llu", + rbytes, wbytes, rios, wios); + if (count >= size) + continue; + buf += count; + total += count; + size -= count + 1; + } + + mutex_lock(&blkcg_pol_mutex); + for (i = 0; i < BLKCG_MAX_POLS; i++) { + struct blkcg_policy *pol = blkcg_policy[i]; + + if (!blkg->pd[i] || !pol->pd_stat_fn) + continue; + + count = pol->pd_stat_fn(blkg->pd[i], buf, size); + if (count >= size) + continue; + buf += count; + total += count; + size -= count + 1; + } + mutex_unlock(&blkcg_pol_mutex); + if (total) { + count = snprintf(buf, size, "\n"); + if (count >= size) + continue; + total += count; + seq_commit(sf, total); + } } rcu_read_unlock(); diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 69aa71dc0c04..b41292726c0f 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -148,6 +148,8 @@ typedef void (blkcg_pol_online_pd_fn)(struct blkg_policy_data *pd); typedef void (blkcg_pol_offline_pd_fn)(struct blkg_policy_data *pd); typedef void (blkcg_pol_free_pd_fn)(struct blkg_policy_data *pd); typedef void (blkcg_pol_reset_pd_stats_fn)(struct blkg_policy_data *pd); +typedef size_t (blkcg_pol_stat_pd_fn)(struct blkg_policy_data *pd, char *buf, + size_t size); struct blkcg_policy { int plid; @@ -167,6 +169,7 @@ struct blkcg_policy { blkcg_pol_offline_pd_fn *pd_offline_fn; blkcg_pol_free_pd_fn *pd_free_fn; blkcg_pol_reset_pd_stats_fn *pd_reset_stats_fn; + blkcg_pol_stat_pd_fn *pd_stat_fn; }; extern struct blkcg blkcg_root;