From patchwork Wed May 30 10:00:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10438295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B2A46602CC for ; Wed, 30 May 2018 10:02:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3B20288ED for ; Wed, 30 May 2018 10:02:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 988EE288F1; Wed, 30 May 2018 10:02:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27711288ED for ; Wed, 30 May 2018 10:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513756B028F; Wed, 30 May 2018 06:01:28 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 4C3A26B0290; Wed, 30 May 2018 06:01:28 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38CD86B0291; Wed, 30 May 2018 06:01:28 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id EF5936B028F for ; Wed, 30 May 2018 06:01:27 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id w14-v6so5156248pfn.12 for ; Wed, 30 May 2018 03:01:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=W/wEKQoz8vz98uzFMPWj4cEIIV271n85SO7RkIRC3fk=; b=AthLbe6vF6hF+sgx4BPvMG3sSBW/NDzMZme9lZjXmx/VG/WlqX59MM8/5ywznABmYT HQVX4eZOTzOQBJSBl7ourdPijVQdXFuH0GvNg/IAhia91beX+hc7BGzyXf3GTUkH9YPM gdgtqe18lRzaxY4wVEGj8Xa6k/SSoU9ChghQlld5kptDKeKc8wLyK5p+AYkg2+LlFTBE +hyrJA34LZ5Rnrwt7a5DNrUIFKnfhQ7rOmA+pVGqG7gj0mzZ5JQ9cPU90ExHqYps6wqz tM9H913a5YJVkDoSpKhHqJ2lUTl+3XXFRnkyDB2wsKFMGoacN/TKNDmoK3Sxg/LyDwNr XWWw== X-Gm-Message-State: ALKqPwfwTOaM4o82MHrbI4Ach7kEGJBunvP8nY0gGtcHYgZfuWEVlYwO 5vOIWeFy+O9slCBQiDXQizjcFdkh0UkbYTcWdGBBguYsOcDqwJPEHk/wUw/LmnjfafVEbynvmRn bkThziEk6uVirVX4FGhwSMn8hn7Su30kkt2JQzcAXExac6Gx0Iw3R4e7bX+isD64= X-Received: by 2002:a17:902:7844:: with SMTP id e4-v6mr2180598pln.296.1527674487675; Wed, 30 May 2018 03:01:27 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJfYXG0dRMXkIzt1F/qgp4up2HUHO7G50Jjr/SO34g2uSWgd9O90EvM89wWanFb5L9Anu51 X-Received: by 2002:a17:902:7844:: with SMTP id e4-v6mr2180541pln.296.1527674486936; Wed, 30 May 2018 03:01:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527674486; cv=none; d=google.com; s=arc-20160816; b=rwIi+Ll3AQ5gZsSwaK+HtqZCFNdB6CxcznyaDxrIzKsLicN9FMVSaCx0+AD1/WaeLl L0TCLsIzjah+3xpjZuoY+nRTCWHwY3ICNain4g/fnq1Qy28ckJngtsF/xzvCM4EsVfvC Khxdpqf2q229XOTMcM7YXLpVl2gks+zVG9jkyruXyXhp1wQa/hjVBvEiVHWE78kI6pSz SuxzkPXnRcAniX48vKVYND/wx5+Ztx8yXfHhhnjjaA9piDbVsu8hsfWNLz81oQJzgpFe bVfaxYQtRYF7UnT6eLLADr1A+ivVfbBvtqlx6DLaHaEv0jPvFbBSr4FE37Sybqm9aeKr IqFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=W/wEKQoz8vz98uzFMPWj4cEIIV271n85SO7RkIRC3fk=; b=hRJ01VIhmO3Fy1tPfdwOFefD/1B40+cp8kB80phMIQqpXRG2l0JD9nRrqsYKBz3dDX fIcT36vUGTBtNVU6Lwuq7mn4plbDX6frympCTD+94gxBBr2uIx99g3yK4lrrYAjfs4d0 5STKZbH5ACHwMevq5sGQaBAeXSfl2f8t+N3VGhPfB0a2dYEp4VhNFLo64FYiwqgtdppx DXVmY5tIshfDx/gSlMSrFIHZnR9S00PKgcsTwuskNcnuSH4R2lMx7RRXKQPGvpibvpYw PUf7H/NPem3mEMsgESmKAlYna8S2wssV69JRP/Jp9HN3zj0Dd5czIQqnWGJvn8nAhHhk FiTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=WXu+kVSq; spf=pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id w1-v6si27222893pgp.10.2018.05.30.03.01.26 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 03:01:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=WXu+kVSq; spf=pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=W/wEKQoz8vz98uzFMPWj4cEIIV271n85SO7RkIRC3fk=; b=WXu+kVSqkuiHdEoqAFFnqqeyQ 0kjSxPqjmmmn/Upgylm9TvQtoDx+aTflD9MXEWmMh8vK55dWatpBHQz/wD29c+jFb/W6XN0v0YpEZ TY49U8zzFIImtISVz3TU6Kzip4h+ssH1EEDTXt1i0CFE34wxTGZxiFpDtKJZWxiO81qmOtZ/gsjw8 ixvGffKGeD8oQEAwIgxrVxQgdi6j6Jcmlw9zMq4k55x+nD/aNFS8uoxEagHNeHa0vkR/ln1bw7aqb NvO0X+HxoOpa1TmAmDYFSNVyMN8ScctX951ghrUjKk0dK+8vq/Bf/hjAIhhu052JHWjVouVemEKV2 3WMKbTnAA==; Received: from 213-225-38-123.nat.highway.a1.net ([213.225.38.123] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNxv3-00007M-OO; Wed, 30 May 2018 10:01:26 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 16/18] xfs: refactor the tail of xfs_writepage_map Date: Wed, 30 May 2018 12:00:11 +0200 Message-Id: <20180530100013.31358-17-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180530100013.31358-1-hch@lst.de> References: <20180530100013.31358-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Rejuggle how we deal with the different error vs non-error and have ioends vs not have ioend cases to keep the fast path streamlined, and the duplicate code at a minimum. Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Reviewed-by: Brian Foster --- fs/xfs/xfs_aops.c | 65 +++++++++++++++++++++++------------------------ 1 file changed, 32 insertions(+), 33 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 38021023131e..ac417ef326a9 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -873,7 +873,14 @@ xfs_writepage_map( * submission of outstanding ioends on the writepage context so they are * treated correctly on error. */ - if (count) { + if (unlikely(error)) { + if (!count) { + xfs_aops_discard_page(page); + ClearPageUptodate(page); + unlock_page(page); + goto done; + } + /* * If the page was not fully cleaned, we need to ensure that the * higher layers come back to it correctly. That means we need @@ -882,43 +889,35 @@ xfs_writepage_map( * so another attempt to write this page in this writeback sweep * will be made. */ - if (error) { - set_page_writeback_keepwrite(page); - } else { - clear_page_dirty_for_io(page); - set_page_writeback(page); - } - unlock_page(page); - - /* - * Preserve the original error if there was one, otherwise catch - * submission errors here and propagate into subsequent ioend - * submissions. - */ - list_for_each_entry_safe(ioend, next, &submit_list, io_list) { - int error2; - - list_del_init(&ioend->io_list); - error2 = xfs_submit_ioend(wbc, ioend, error); - if (error2 && !error) - error = error2; - } - } else if (error) { - xfs_aops_discard_page(page); - ClearPageUptodate(page); - unlock_page(page); + set_page_writeback_keepwrite(page); } else { - /* - * We can end up here with no error and nothing to write if we - * race with a partial page truncate on a sub-page block sized - * filesystem. In that case we need to mark the page clean. - */ clear_page_dirty_for_io(page); set_page_writeback(page); - unlock_page(page); - end_page_writeback(page); } + unlock_page(page); + + /* + * Preserve the original error if there was one, otherwise catch + * submission errors here and propagate into subsequent ioend + * submissions. + */ + list_for_each_entry_safe(ioend, next, &submit_list, io_list) { + int error2; + + list_del_init(&ioend->io_list); + error2 = xfs_submit_ioend(wbc, ioend, error); + if (error2 && !error) + error = error2; + } + + /* + * We can end up here with no error and nothing to write if we race with + * a partial page truncate on a sub-page block sized filesystem. + */ + if (!count) + end_page_writeback(page); +done: mapping_set_error(page->mapping, error); return error; }