From patchwork Wed May 30 10:00:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10438297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 70B48602CC for ; Wed, 30 May 2018 10:02:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62076288B7 for ; Wed, 30 May 2018 10:02:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5705B288EF; Wed, 30 May 2018 10:02:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E98AB288B7 for ; Wed, 30 May 2018 10:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75CFB6B0299; Wed, 30 May 2018 06:01:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 70E026B029A; Wed, 30 May 2018 06:01:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623826B029B; Wed, 30 May 2018 06:01:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 247EE6B0299 for ; Wed, 30 May 2018 06:01:31 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id d1-v6so3777906pga.15 for ; Wed, 30 May 2018 03:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=wsld1eDR3Clm7WhHDR82DUB0EotaZ6S/Re6luLQKUYY=; b=GOo/ONUardKeE10SxVRfqXke9KixolUJL8T9f0cPne4Z/FEB78WvpbuDcdlj9WGvNc IsV9x0uII6MLUwn5kdWYXq+fWsYL491o79bB/MSVvWX5JYVLOMYgyQllRd+g7hNZ+RUH p7QSViEohANIx5dNJ2PhVRvYV74j3QfT/2mkiuA6CvEAquA+x+7vlfv+iWmheIR/3hTl YI5+20rqAQVrFBYGqX9P36iiYB7PeAeqOCBwQivff959OscYheKicxShYCb5QtirAwL4 NlxfRMZAfWjQbY6KNuXpLfgxXiE0es31Me0IKnw+ldhy/KSC1DvSea6/KEyfAd1jlfy3 azCA== X-Gm-Message-State: ALKqPwepyLv3s1HMTlCfynrRNgXnCB4u1YjcuKToqgXbjHLzmabU9c7G wETwBYyVeeqKh9uveX9g+Gr4OsT+aGaKk3rXvVX6d3RcAuDwr1zjpYRTz8WmYmxzZlSVY2CfwRq TCsoO55FbPTIKwsR1K5lBp4+NWU6JIpFCfcV+SoDB2Y58BQBk+XCvgIwjQVrs5sI= X-Received: by 2002:a63:7986:: with SMTP id u128-v6mr1698361pgc.127.1527674490834; Wed, 30 May 2018 03:01:30 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJVnPwF/gOIbe6OVNnEYjjjxSKpCgKBdZnNVeomNmTNm2xYPgCSv3AdxeFow/1OxaSUvKLI X-Received: by 2002:a63:7986:: with SMTP id u128-v6mr1698307pgc.127.1527674490081; Wed, 30 May 2018 03:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527674490; cv=none; d=google.com; s=arc-20160816; b=otBU0kztG7nilUK5Q2TW17tXoNYuqI+Is/p66VXfu8tiv23t7RZLAuGy1vrdaCobMJ TypNwoRsINQAOyDCE/XpJd//Nxvnwl1TwlG385K3jKl4qolLGVL6Fdxv9Oyav45UigmD rrCyg0tiOXF+yptDgABXLhsFOkKGX4wJ68mv4oLvcfvUVSd2zQ/X1Us8tMpUDZ4wRUmX /CPAdfqLtJhOrqDtlx+mZEd1IoW0hJIz4b3L7w8HR2bPlZndc7hBdjdgRNVZ5aY0K51z 9o1CA3xRkIaLn2JdZAqJIvXfg8ywWjJ/98Yprzy95zEZraMyDv0eArK8n4Qm+e1slUc+ fGNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=wsld1eDR3Clm7WhHDR82DUB0EotaZ6S/Re6luLQKUYY=; b=Vz3tK+UwOBIHAkqD31v7wg/SFEkiFLRVQmPpsrSzyKdLhBcEc6O06jM5iH53To8eO0 DXgJufB8GGxAOs7mS8vg2y6dRDIwxuyUoTDuVd9EtxsogYYgVEsG4Q0TsNp0O+aweOyJ /SKgh7tF4IDI/IAZ2zEumKt2ZqOAzjbXC/xHmWav/6JmlzILGgRKVf84y5vznAaVBp7O d71q7fl97xhT9r8TTddc//m+7rKIVEtSqt/unxj8VzTYYSX5yCX6UfX7cf0khvXPRid7 wjAzMMtEFgoAvlBYih56iajel/0a/GC9aobAvzIA09axCPwwdQ/20MZbyWuTO0hWcde0 copQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=gJSoMGwD; spf=pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id 67-v6si34369495pla.475.2018.05.30.03.01.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 03:01:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=gJSoMGwD; spf=pass (google.com: best guess record for domain of batv+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+1f4557cc97fec8e307c5+5393+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wsld1eDR3Clm7WhHDR82DUB0EotaZ6S/Re6luLQKUYY=; b=gJSoMGwDC2i07CyCuLqS28Gw8 kR1SYt8rbrthhQkeQGZHg775fyygLEjnpOHf7CaHA5OQM3JmL8ZVUAfN2E5aL/gqQgFzm3bJ4nJw6 yzczx0j/R/cHP2w740cS05m6Nc4Yq0YxyM+ZZShvXuyQFSWlh50GcroLfkr7oAX7pkda9WnPQL+gn 2wBidlVZtYrxyEqZWZVL60POiVOc94YUTdtkPNGSVq83fYk4yXr/dGhwnSSBQgmv61u4xuzAHde+l iC+7cqcgGFGeaGjj2NHwJTBPwwGv2jw2DzIkonWuwAsnD+2OXNZ2nIidtTfAH9IYTTzlEs2wGt6mA g0uZLUA5A==; Received: from 213-225-38-123.nat.highway.a1.net ([213.225.38.123] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNxv7-00008J-0S; Wed, 30 May 2018 10:01:29 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 17/18] xfs: do not set the page uptodate in xfs_writepage_map Date: Wed, 30 May 2018 12:00:12 +0200 Message-Id: <20180530100013.31358-18-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180530100013.31358-1-hch@lst.de> References: <20180530100013.31358-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP We already track the page uptodate status based on the buffer uptodate status, which is updated whenever reading or zeroing blocks. This code has been there since commit a ptool commit in 2002, which claims to: "merge" the 2.4 fsx fix for block size < page size to 2.5. This needed major changes to actually fit. and isn't present in other writepage implementations. Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Reviewed-by: Brian Foster --- fs/xfs/xfs_aops.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index ac417ef326a9..84f88cecd2f1 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -786,7 +786,6 @@ xfs_writepage_map( ssize_t len = i_blocksize(inode); int error = 0; int count = 0; - bool uptodate = true; loff_t file_offset; /* file offset of page */ unsigned poffset; /* offset into page */ @@ -813,7 +812,6 @@ xfs_writepage_map( if (!buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); - uptodate = false; continue; } @@ -847,9 +845,6 @@ xfs_writepage_map( count++; } - if (uptodate && poffset == PAGE_SIZE) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: