From patchwork Thu Jun 21 05:47:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuo Handa X-Patchwork-Id: 10479163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D0825604D3 for ; Thu, 21 Jun 2018 05:47:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B50322890A for ; Thu, 21 Jun 2018 05:47:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A92E128AF5; Thu, 21 Jun 2018 05:47:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F20F2890A for ; Thu, 21 Jun 2018 05:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48ED56B0003; Thu, 21 Jun 2018 01:47:11 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 4175F6B0006; Thu, 21 Jun 2018 01:47:11 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E0B86B0007; Thu, 21 Jun 2018 01:47:11 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ot0-f197.google.com (mail-ot0-f197.google.com [74.125.82.197]) by kanga.kvack.org (Postfix) with ESMTP id F14AB6B0003 for ; Thu, 21 Jun 2018 01:47:10 -0400 (EDT) Received: by mail-ot0-f197.google.com with SMTP id h38-v6so1163428otb.4 for ; Wed, 20 Jun 2018 22:47:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:message-id :subject:from:to:cc:mime-version:date:references:in-reply-to :content-transfer-encoding; bh=MqSurJ3gJjBIF5scNiPtyhHuSse59q/nLtywotLYLkU=; b=l8C0BT91eFbGyONMOYfHqD36wHRuBRKK4/u+6QvPsHstoolV3BYJ9qU8cCxlJhawJe hJRTorWKCm6hx3hGx2UyFsMjBXmmlixVKVvMOSMZaLwwOoL1OHKmhc+9UvdIFSgKmWTz G8zuiyWDIGvWDBJL2WEh2VlwUplTA4Lw/DQZBy+LFMkW4Bbz/dUseo8HEwj4cpj1hVQa owiPvCjNVOqUieOa4aeFKE5YseN20iQubcE+jZUgZrNddh/lgkCOa2tDbH3+3rHtFIGE uOWc9V/2gi+XViyBm+xJhcMRgDsCTrEZdSS9shmZ32F3eg5jzCrl9hZmk42j9TtzwgI7 zFew== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp X-Gm-Message-State: APt69E3/9eZjmehevz3sBlMFqB6LN6Zx2qCvMP3mr7qxz3TjKNyV3LBo KvIVeHnfS1wlSDeTg6RuyY2XEKOldaLagoEy17Va2hvSmnKrPxoPz3ARGuXFdLIKe58ce1kdbNk uoPgoHmtfBUFk+cHBJo2yswHuQtZIH9+/pgqGvqosfmi+opjzIKmxjkfOS2yy+bHrpg== X-Received: by 2002:aca:1b11:: with SMTP id b17-v6mr12884296oib.125.1529560030581; Wed, 20 Jun 2018 22:47:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLsYYJdHT80XVxxkthObUOsTkCfNNoQgRmiNSh5OXc77pVO0wscCcsyKh+6yG3AB3ztvhI9 X-Received: by 2002:aca:1b11:: with SMTP id b17-v6mr12884284oib.125.1529560029873; Wed, 20 Jun 2018 22:47:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529560029; cv=none; d=google.com; s=arc-20160816; b=xxOA4k4WS5RIDcYWc+SPVFG029loSbXGKYNJQaMCgvPyHgUkeOErW01Zj92j/x7cDn G2OZKy5h2uHZb23C2QUOAYnwxzeWEbLwTc1so57QzJnijakYWVmSUIHKDJB0xE7+fIJJ VJAIxeczyEPz9Tt+uLqpNjCW9/7prPL1GCPxxrpNYz3MKHEHA0bvIl65d7igu/Wmp0N+ jhPYyIlpiWCNQPJRoguq8Ea5TUo/3ZS7QGBILDjvOX1jOSvIS6SS4Wr4Lq3k4oLEpIJs Jw5FL0pza/jDx+6Zal5cc857DgXQxEjtOX5YWVjpPn5jFDiqnhbwMY+PQlXT951lvTVu AR/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:references:date:mime-version :cc:to:from:subject:message-id:arc-authentication-results; bh=MqSurJ3gJjBIF5scNiPtyhHuSse59q/nLtywotLYLkU=; b=SQjFMxBQl1WyyqWegays/VJoaWBdpL3klMtvipXUQ77SlL7a06zM5VXeJpvxUwNwxc VVVcz/PanIDMDF9gL8ju2tgwYTX2DA8vfUhYE4HlR8Fn0Gc+yXG65QoVocRTz5MFRY8a 4l3ue7/4n7VA1OB9s1AzUc3WrUzkodZBc0rrOiMDqIAWIO45xVSzj6oPLHywLR9CvrAQ SSQIrp/ep6cv8E+yZ5zR8WLU3KqIiW8/Gv40KTSEFQ4MAC8/X/tinNlLkFLIZjXvhj9Y haIcIIRekAD6jmslfrXO8ajaSXqsAysHhMm6QZyioetIt691F0wbnCmbW7yV7ef36nBg 9v/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from www262.sakura.ne.jp (www262.sakura.ne.jp. [202.181.97.72]) by mx.google.com with ESMTPS id u32-v6si1424529otc.242.2018.06.20.22.47.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 22:47:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) client-ip=202.181.97.72; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from fsav401.sakura.ne.jp (fsav401.sakura.ne.jp [133.242.250.100]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w5L5l53Y029264; Thu, 21 Jun 2018 14:47:05 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav401.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav401.sakura.ne.jp); Thu, 21 Jun 2018 14:47:05 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav401.sakura.ne.jp) Received: from www262.sakura.ne.jp (localhost [127.0.0.1]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w5L5l5xx029259; Thu, 21 Jun 2018 14:47:05 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: (from i-love@localhost) by www262.sakura.ne.jp (8.15.2/8.15.2/Submit) id w5L5l5Mh029257; Thu, 21 Jun 2018 14:47:05 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Message-Id: <201806210547.w5L5l5Mh029257@www262.sakura.ne.jp> X-Authentication-Warning: www262.sakura.ne.jp: i-love set sender to penguin-kernel@i-love.sakura.ne.jp using -f Subject: [PATCH] Makefile: Fix backtrace breakage From: Tetsuo Handa To: Andi Kleen , Steven Rostedt (VMware) Cc: Dave Chinner , Dave Chinner , linux-xfs@vger.kernel.org, linux-mm@kvack.org, Omar Sandoval MIME-Version: 1.0 Date: Thu, 21 Jun 2018 14:47:05 +0900 References: <8fda53b0-9d86-943b-e8b4-fd9d6553f010@i-love.sakura.ne.jp> <20180621001509.GQ19934@dastard> In-Reply-To: <20180621001509.GQ19934@dastard> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From 7208bf13827fa7c7d6196ee20f7678eff0d29b36 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Thu, 21 Jun 2018 14:15:10 +0900 Subject: [PATCH] Makefile: Fix backtrace breakage Dave Chinner noticed that backtrace part is missing in a lockdep report. [ 68.760085] the existing dependency chain (in reverse order) is: [ 69.258520] [ 69.258520] -> #1 (fs_reclaim){+.+.}: [ 69.623516] [ 69.623516] -> #0 (sb_internal){.+.+}: [ 70.152322] [ 70.152322] other info that might help us debug this: Since the kernel was using CONFIG_FTRACE_MCOUNT_RECORD=n && CONFIG_FRAME_POINTER=n, objtool_args was not properly calculated due to incorrectly placed "endif" in commit 96f60dfa5819a065 ("trace: Use -mcount-record for dynamic ftrace"). Signed-off-by: Tetsuo Handa Cc: Dave Chinner Cc: Andi Kleen Cc: Steven Rostedt (VMware) --- scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 34d9e9c..55f22f4 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -239,6 +239,7 @@ cmd_record_mcount = \ "$(CC_FLAGS_FTRACE)" ]; then \ $(sub_cmd_record_mcount) \ fi; +endif endif # CONFIG_FTRACE_MCOUNT_RECORD ifdef CONFIG_STACK_VALIDATION @@ -263,7 +264,6 @@ ifneq ($(RETPOLINE_CFLAGS),) objtool_args += --retpoline endif endif -endif ifdef CONFIG_MODVERSIONS