From patchwork Fri Jun 22 03:51:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Ying" X-Patchwork-Id: 10481123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C63D60380 for ; Fri, 22 Jun 2018 03:55:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D7CA28F91 for ; Fri, 22 Jun 2018 03:55:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41D7828F98; Fri, 22 Jun 2018 03:55:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB9CE28F91 for ; Fri, 22 Jun 2018 03:55:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89D826B0006; Thu, 21 Jun 2018 23:55:14 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7D9716B0008; Thu, 21 Jun 2018 23:55:14 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6671E6B000A; Thu, 21 Jun 2018 23:55:14 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f70.google.com (mail-pl0-f70.google.com [209.85.160.70]) by kanga.kvack.org (Postfix) with ESMTP id 195D36B0006 for ; Thu, 21 Jun 2018 23:55:14 -0400 (EDT) Received: by mail-pl0-f70.google.com with SMTP id s3-v6so2937693plp.21 for ; Thu, 21 Jun 2018 20:55:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=6ot8l5PNSGBpaFuWxnGSb6WePe5Kdlb0Pk5ujnkmQZM=; b=XGjG+5rr9cxJb6INOt0Ag0KQYFwWipqo6k+wgo88gqcMKGS6xd1hTE7F81x341xcmR L3p49nOJ/8QBvQTWtG897p+2Z840sK/7iRMzLCbzJ6p+kU4jnbErPMbFbfZqWa0/laF5 wmBCe9eHuCYMLhkzIrtaVx5VSL0MUW/sox/iro5h5W4fqxN5hF8V0HxcCd6+ojqvzcb2 kNzQHu+++2Pu7swigud4LK6cAI2wqOM9JJfTrVR/rARXb2tcC+BJ7g6lcQEE7y00guBt up7I+E5X2Knk+0Ng3Z6bwJZilE0pZBZchh/5YpMV2U/HXxaJhQiIbdelFv8LoS4Gky3X ma5Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: APt69E2n1AkT8jGyQT2u8uOTrAET/wZjk5BrnPw4wH7kw700D1fzhsF9 fy4bK0OAHO2drfbS//onkJL5AAV8HDo2PGY9ZBkhKmVr79ATB0vmVIng6CfhXlZB2kbHTSl65MY 5u46fIimRMBF/MCntMV1Me2Pnez68ZREupJeopnxwvq7ASNSCPZUH5YUpE/Ne2CWJoQ== X-Received: by 2002:a62:a30e:: with SMTP id s14-v6mr30454705pfe.168.1529639713784; Thu, 21 Jun 2018 20:55:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIcZfQAHT0SFMIFwq1JFO3UcZz/8s3UvIMLkqgqIv9a1ytDq+Y1prqSGaifqZxsnNdbARpV X-Received: by 2002:a62:a30e:: with SMTP id s14-v6mr30454672pfe.168.1529639712616; Thu, 21 Jun 2018 20:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529639712; cv=none; d=google.com; s=arc-20160816; b=GGrsHc+fYkGeADI7ncirwFFs74YuI3MaQUG3uIx4VLr9M3L0xtkKziuI/A8RFseskc 5E/0qLCRJjrBUxwSYHSujV3n5FkWlSgtCZ6IzzP1oDlYh72TBoqJW/LbEgOVBOvzytoZ amb5FnpBkCDXa/kMWiQDqTB0PgMqLmzvIyRvEN03PFyIhs6/uNLvPkh+OZzFn+4AmpH1 ov1Cf13XAB+sINuTeN5m08Jf9az/tnf42YKvjIYQVc4jIDloEAhyY2YGkvHFzcnjCUC9 Dn7qIDM/10TM0Kd9cPzX5fJZPxKWfZKalzxZknBXZ/MB6dEj5bMGyg2Zk/ysupABVa9G 0ycQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=6ot8l5PNSGBpaFuWxnGSb6WePe5Kdlb0Pk5ujnkmQZM=; b=dfzoVyILbEDBA8QxWZAbOCIrEviAt5kXIOXt9AZ3+5gNe6BDAfJBbdFZ8l0YhrwlKG aKwE/pe6g8bFCim5wYRBxQWzJjeoG8tODV74WN7gDhh0mCH577eT9UFsdFeYo833EHlU Rn+93top3b2Qpbbsuz08BGiIljLb822sQsz2Y2+ef2I2qBA8CAtEEkC6GczZvexo3Mov DrJGxOQf86hn/4afbsfHE3JN3MWyPvDWSBi6tfTXQO6sdo91Obt3qwq85q8u/MtwnrVY HYlA7csVDR14PCHOCtkJqqPFVclPwE/qRrTZyh9b6rUfNcXPoMMZQM96TpOKkXHJc4OS bY0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga05.intel.com (mga05.intel.com. [192.55.52.43]) by mx.google.com with ESMTPS id q13-v6si6671342plr.220.2018.06.21.20.55.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 20:55:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) client-ip=192.55.52.43; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 20:55:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,255,1526367600"; d="scan'208";a="65335061" Received: from wanpingl-mobl.ccr.corp.intel.com (HELO yhuang6-ux31a.ccr.corp.intel.com) ([10.254.212.200]) by fmsmga004.fm.intel.com with ESMTP; 21 Jun 2018 20:55:09 -0700 From: "Huang, Ying" To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , "Kirill A. Shutemov" , Andrea Arcangeli , Michal Hocko , Johannes Weiner , Shaohua Li , Hugh Dickins , Minchan Kim , Rik van Riel , Dave Hansen , Naoya Horiguchi , Zi Yan , Daniel Jordan Subject: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP Date: Fri, 22 Jun 2018 11:51:32 +0800 Message-Id: <20180622035151.6676-3-ying.huang@intel.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180622035151.6676-1-ying.huang@intel.com> References: <20180622035151.6676-1-ying.huang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Huang Ying It's unreasonable to optimize swapping for THP without basic swapping support. And this will cause build errors when THP_SWAP functions are defined in swapfile.c and called elsewhere. The comments are fixed too to reflect the latest progress. Signed-off-by: "Huang, Ying" Cc: "Kirill A. Shutemov" Cc: Andrea Arcangeli Cc: Michal Hocko Cc: Johannes Weiner Cc: Shaohua Li Cc: Hugh Dickins Cc: Minchan Kim Cc: Rik van Riel Cc: Dave Hansen Cc: Naoya Horiguchi Cc: Zi Yan Cc: Daniel Jordan Reviewed-by: Dan Williams --- mm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index ce95491abd6a..cee958bb6002 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -420,10 +420,9 @@ config ARCH_WANTS_THP_SWAP config THP_SWAP def_bool y - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP help Swap transparent huge pages in one piece, without splitting. - XXX: For now this only does clustered swap space allocation. For selection by architectures with reasonable THP sizes.