From patchwork Tue Jul 3 11:03:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10503813 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A07E6601D3 for ; Tue, 3 Jul 2018 11:03:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E00A28905 for ; Tue, 3 Jul 2018 11:03:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FDE328924; Tue, 3 Jul 2018 11:03:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 138B728905 for ; Tue, 3 Jul 2018 11:03:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0738F6B0006; Tue, 3 Jul 2018 07:03:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 023366B0007; Tue, 3 Jul 2018 07:03:45 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2E966B0008; Tue, 3 Jul 2018 07:03:45 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by kanga.kvack.org (Postfix) with ESMTP id 850536B0006 for ; Tue, 3 Jul 2018 07:03:45 -0400 (EDT) Received: by mail-ed1-f70.google.com with SMTP id o5-v6so799972edq.15 for ; Tue, 03 Jul 2018 04:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=4wmFmFVkoD+ariWl08jOPo8tw/ypGv5Ba6Mqpe6RGjs=; b=Q0FW4fCaifLuoH1yQVqVmKsd5Ni4FG1hB29aOtnKkyF6lc4aiobm5wz6kvx0Vt71k8 dmnu5T+iyuSj77AKnW2+ENbsLN+IPk7Irj/4AW5s5Wf3FeTudKSNdTc9LT5kIULiLZ/C e2kf7hlz9enDF5EQyVA/UqzOh7wrhXRl0+MEbIJwEZUGl+E7e+7tA1a2vYxBaPHuojb9 ERlOIEBrhmceZu+8WdqBdCmsdCWLpI4sO1GIHeoSSPDW2v3J2svZK29IiiF6v7ns4qaU GPoSDzYMKptv6X6oYImy2MYxKiXhk0n88Rm+yXQkLrmDVkwHcNqw4M+jkAIXDc5IOLrL ITQw== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: APt69E0hPn2wMaZeANb0ufaSubLe0OfhinAuLcGc++LkgaR15vIJrIpI qEWzPk1/lad9rLv42tNZCLYmeGlMdix8wq6CxdcnOzex/xNvTHnabn2JCRnxZ5+y0L1bPfW3Pi3 iO9IxQfJgH5lRRiieJog4AoC+Nedenyszl+8PABujYUSBchTv+8m6pzh4E37lIiw= X-Received: by 2002:a50:b901:: with SMTP id m1-v6mr27799429ede.185.1530615825042; Tue, 03 Jul 2018 04:03:45 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdzlHPeQRN7ZOdkXQm3gIJQgt6d6cHesQuzoruIO5IQAHvdBs9+sCs9f/IM8FSkiyevEjaZ X-Received: by 2002:a50:b901:: with SMTP id m1-v6mr27799372ede.185.1530615824244; Tue, 03 Jul 2018 04:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530615824; cv=none; d=google.com; s=arc-20160816; b=iHRKckOzJsRyLLtVPSKDPkpt6SkxdcHUmpSUVqYHi3zSzhd1GD9irkKAlZ/kTiEvdD HqIWbNoE3HF0b6/1Gs+EcWQWGOUw88hUtdafd92wB+1nD8ozbV+XwPo/XWPE8J/SSVUC Px9QN4lzcRuCw/qz4Hp98ZFcimpbBPxOTE2fyf7i5ZibtTKl0x4Ii5X+VLGBDQTrF/IY 6OwsWM4xjcs1OmqY/IJWT9ZsKUMl6iDmUWJFCM0t/y0n9Oo2FxFXu+bH8AdCX4ukTms6 r/dc51EV8pAdHJrRn7T0JoA44LZnMQCCTyHjlYV82zd1RihywldBl97wQKEi49sF/dtz 4NsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=4wmFmFVkoD+ariWl08jOPo8tw/ypGv5Ba6Mqpe6RGjs=; b=WixKV6XiBm+h+9oHPj2r+2zEiD9i1IdNWr0zq1k5Y6Fc4TtASPpKIHousBTRhwG4xn aEPVyr4zSdUaAxLU5IUYg29Fmpg1zySNZliv8CxhwNGyFKAaSfFqMSJnwBWGFpNhWIpk m0lvQ0Bz+cazsZXVNWrGVWgOEiwt9UcDCEjvM6IVY2Jc0+5NXD4Wd7XpqEG0C9Yz64Ac ywKA5y4LFL9h8hn0987nWq601WlEq9XVhKPP7bVscJL9gEmH4dENR9AMdQUr+Z/dqt4x MpNNDZthQIUICSh1i0vyj7oL/gFSbhXqpPuZKK5Qboe75cZ05y71/ffwV348HPp1BaXq tdXA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id i26-v6si941120eds.215.2018.07.03.04.03.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 04:03:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4A7A4AFC9; Tue, 3 Jul 2018 11:03:43 +0000 (UTC) Date: Tue, 3 Jul 2018 13:03:35 +0200 From: Michal Hocko To: =?utf-8?B?56a56Iif6ZSu?= Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu Subject: Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header Message-ID: <20180703110335.GH16767@dhcp22.suse.cz> References: <1530376739-20459-1-git-send-email-ufo19890607@gmail.com> <20180702101732.GD19043@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Tue 03-07-18 18:57:14, 禹舟键 wrote: > Hi Michal > cpuset_print_current_mems_allowed is also invoked by > warn_alloc(page_alloc.c). So, can I remove the current->comm output in > the pr_info ? > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index d8b12e0d39cd..09b8ef6186c6 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -2666,9 +2666,9 @@ void cpuset_print_current_mems_allowed(void) > rcu_read_lock(); > > cgrp = task_cs(current)->css.cgroup; > - pr_info("%s cpuset=", current->comm); > + pr_info(",cpuset="); > pr_cont_cgroup_name(cgrp); > - pr_cont(" mems_allowed=%*pbl\n", > + pr_cont(",mems_allowed=%*pbl", > nodemask_pr_args(¤t->mems_allowed)); Yes, I think so. Just jam the cpuset info to the allocation context warning like this diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1521100f1e63..6bc7d5d4007a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3416,12 +3416,13 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; - pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=%*pbl\n", + pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=%*pbl", current->comm, &vaf, gfp_mask, &gfp_mask, nodemask_pr_args(nodemask)); va_end(args); cpuset_print_current_mems_allowed(); + pr_cont("\n"); dump_stack(); warn_alloc_show_mem(gfp_mask, nodemask);