From patchwork Wed Jul 4 07:54:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10506081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2591601D7 for ; Wed, 4 Jul 2018 07:54:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E24B028C7F for ; Wed, 4 Jul 2018 07:54:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5F1C28D1A; Wed, 4 Jul 2018 07:54:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CC7B28C7F for ; Wed, 4 Jul 2018 07:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12716B000D; Wed, 4 Jul 2018 03:54:14 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0BE6B000E; Wed, 4 Jul 2018 03:54:14 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B20D6B0010; Wed, 4 Jul 2018 03:54:14 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id 2E6906B000D for ; Wed, 4 Jul 2018 03:54:14 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id x5-v6so1798239edh.8 for ; Wed, 04 Jul 2018 00:54:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=+FCynpXPD3FURpmkX9oyHIlQ+dA4XdV/st7ub+/eZYg=; b=M9Ersce4+2hjfvfnbSs6zwSgpPveFRJDWF0Rrf+5S93ROvdutkQO6Dg7JLYnKuUYZy b9DL60kcpRXdL3iWlzKBVY+hW+zVdfbezHFdROyP3/WjP7a8gzH5qNf/GTxbVSF3gipR CEdHTyE57HV4E19nSXujX7Czd60bGy+2qGGVbh71rUmOvCSAUleF7WmJAO1YnhjqSQaO bYO9qmoJlhgS3gtU6HuC8PtyUeIzYw4UOiJ8ZyK4INKYuV6CAjmbZRcGdY00e5RE2rXQ AK+A3BH+wwyoXQEL3ysu9RhMxbG7egavvnVdV3XkaeuBfA54fN5wxDHpRKvhVn3xCE9N d7BA== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: APt69E0c0ug9UKXiEeXbCRWJPkyQHlpRgU1ov17MSwGeblBFcUEusfui FLHCGKeSreidPG/tc1OABzzTDpZRfahYfMLkogeAb2Tv3aT7EloYCx0eXP/O9SpZr+NVxDxGOwo SzxImv7m4XtNrKeRl3ZHpuBpmHxxZb73y+nlmzZWYyKY1J0pilfbkY3UtWY3qyIM= X-Received: by 2002:a50:aca3:: with SMTP id x32-v6mr1513144edc.41.1530690853731; Wed, 04 Jul 2018 00:54:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcblWnfF6tfm1+wP5pjE89hnNexn6eKPWXqu7cugwHrfwLd2H47g0SXXCLbV1DCQFdC9i5u X-Received: by 2002:a50:aca3:: with SMTP id x32-v6mr1513113edc.41.1530690852983; Wed, 04 Jul 2018 00:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530690852; cv=none; d=google.com; s=arc-20160816; b=qi5tVi991V8g374WclkJajK2F/RO9t40l3INjvr0ax9srAwvp9byOSuzqZXzv7u+dY EXIdZ5DT8jTSelI56gFgIDLdCqwVMMkToUp8SuYat8o8IF9hwiI8yDrLoijm+QMmS2IA Fq64P6PNTJexKkRU1UcfjrPe4Mr+g/q+FdBooF1dRVw4x+XQioj2c0DDvlXvNw3SnSre uDOS/POCO8xMrZnHZBZT9xV3uNQbRzFYXDgBZDpk+Zzl6XjOdn1Ubx+D8u6AU8GZtfRe qrzN/lUfIbhmBrtAKSz/f6QRmltQUQQzjt2SXWWxLJJWlmuqbov15xXhcqV93eWMjNlm HBHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=+FCynpXPD3FURpmkX9oyHIlQ+dA4XdV/st7ub+/eZYg=; b=Ejvt9cvxG0LrDfrklhfwTzJ27ntJ/WgG/Kb2bcJIMU7ihsqjsw4fcMkVKf7e8dTAdq +Zs9tPOfmMCRlYJkJ+ueBl+6g0u6atctuw8JWbr1r7CzrAmQqYJTX1Po+ykdBy2UwhpL V4xKkNLVEdyx/sail8AvvbMnNtfRO9NzrWTiSfqj8FyQmt7tR63dd04isyTBtiahyW+6 +FZGyonDlc7m93i/Nw68sFxjLWbDEXnxJuiz9Ep4XxjmmEZT3FSGMaWSytR4NQ4QcISH koXictIAFP0MlypDoSinf2uZJOJx1zA8ACmWMaIStVEwG+zia7CD1nQndUDZxTeH1lud o6ug== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id x3-v6si2590463edb.263.2018.07.04.00.54.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 00:54:12 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1946FADF4; Wed, 4 Jul 2018 07:54:12 +0000 (UTC) Date: Wed, 4 Jul 2018 09:54:10 +0200 From: Michal Hocko To: Geert Uytterhoeven Cc: Mike Rapoport , Greg Ungerer , Sam Creasey , linux-m68k , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM Message-ID: <20180704075410.GF22503@dhcp22.suse.cz> References: <1530685696-14672-1-git-send-email-rppt@linux.vnet.ibm.com> <1530685696-14672-4-git-send-email-rppt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Wed 04-07-18 09:44:14, Geert Uytterhoeven wrote: [...] > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 0 at mm/memblock.c:230 > memblock_find_in_range_node+0x11c/0x1be > memblock: bottom-up allocation failed, memory hotunplug may be affected This only means that hotplugable memory might contain non-movable memory now. But does your system even support memory hotplug. I would be really surprised. So I guess we just want this instead Tested-by: Geert Uytterhoeven diff --git a/mm/memblock.c b/mm/memblock.c index cc16d70b8333..c0dde95593fd 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -228,7 +228,8 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size, * so we use WARN_ONCE() here to see the stack trace if * fail happens. */ - WARN_ONCE(1, "memblock: bottom-up allocation failed, memory hotunplug may be affected\n"); + WARN_ONCE(IS_ENABLED(CONFIG_MEMORY_HOTREMOVE), + "memblock: bottom-up allocvation failed, memory hotunplug may be affected\n"); } return __memblock_find_range_top_down(start, end, size, align, nid,