From patchwork Wed Jul 4 12:36:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10506753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83EF1603D7 for ; Wed, 4 Jul 2018 12:36:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A2C32855C for ; Wed, 4 Jul 2018 12:36:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C88F28DE3; Wed, 4 Jul 2018 12:36:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C8D732855C for ; Wed, 4 Jul 2018 12:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9651C6B0007; Wed, 4 Jul 2018 08:36:30 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 914146B0008; Wed, 4 Jul 2018 08:36:30 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B4336B000D; Wed, 4 Jul 2018 08:36:30 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id 146246B0007 for ; Wed, 4 Jul 2018 08:36:30 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id f6-v6so2164144eds.6 for ; Wed, 04 Jul 2018 05:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=Aw6AkBA9Yg8E5SncEJ1nE39P31wbYe07Aoj/z0lo+AQ=; b=WqFeb46jCwt6LSrNMyXtroQRzW1ZCVPKI0VpQghNXdKbJFehnukVbqqe+SzDJ1kdzz zqlPfG1fYZ9p8d0kB7s75swqmoQTtE3oTfgFrFbr4Fp+VwihFUbJi3j2QJl+OtzhCztH Dk8PmLcHYMCaoDN6aTwN+SMfOLtQOxnZFCOadj6YStDrTiiI35LxiHQkHjoAqG9qCqzx VESeE+BX42KVpiHBP51v/6Lezem68qK52hmOndtEr5ekfyxF+u5DGQtwDLDY/lmFmW6c 24afN+gubr2x3w8hzZYM4G+GWTPOJF3LjFgWvaGRDE/P5JiIYQ9sJ8VxT7dQdr1YBbe8 C+DA== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: APt69E3HGzt/jTEiA4WRK1uSHsxczXRw0u+aUYnbLNNSwHsWGZvvJkq2 YDaMKJJtj1Ok2VCNBSMZvvuNydytSbXaMNJGXPv/f//dTpZXFAiPvBdztbZekA1xcb6J85MBWks ay2AfMLB0dj5vXkDN1+mAZkNnftxICxSzvo2F7O2JxT3UngLRj78J9C1GycY32Js= X-Received: by 2002:a50:8d46:: with SMTP id t6-v6mr2493511edt.238.1530707789589; Wed, 04 Jul 2018 05:36:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfK9EGBtofTm6Pa0NvN+Bacn91k9pn7BwIFFax+nQhMB7c8e9TGGYnuK/uWM8gIRIjVfXGd X-Received: by 2002:a50:8d46:: with SMTP id t6-v6mr2493464edt.238.1530707788815; Wed, 04 Jul 2018 05:36:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530707788; cv=none; d=google.com; s=arc-20160816; b=DT1fovKD/qtNK4ZdzLFv2bIGYT8qWE346pfgFBQ3CaUTUcsCw6LP9GN3u8GKf2QD1V stZxkXCju4dOSnMQt7xj5hHIHM6Y2UQxzT656f9NFLRlJnvvTjrL2INKwupUqWBeF2v5 ObAwa2pkv10JrW+BQ5rbFgPwxRfpimxuYZb6jQpKNryy09i/tkqdxJA4HdvG6X4Hr8hp CL4wvmacWIDmrsGYokr9Yyd4VhpEHAnU4b5IMS1aCU+nSmDt4AztR9DKQ7unGM5ZIORU hR5Oii1OyxUDxLbtdwG9SluX6vRVCSLsrab3B3w01ssYy3xAhsR4vIW1AqIXimUKbga6 FekQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=Aw6AkBA9Yg8E5SncEJ1nE39P31wbYe07Aoj/z0lo+AQ=; b=JOeONBLLsPvE2gD9FrUzQ3rKf5yOyo8F8nlGPLFCcMQ200cLMC+SSxYHgaZAHiMfB2 prcA2+obclvB67ikiCEs74u4fNZCEfb3JpPGOdumtyGq79j+RoYROfatOqMiILk7r7B9 n9g31sbvdGbCxrYzMQctWK/n3plPLvvtJUEG2xkpNYzzRifNlw1Zs5mMgcgKQA29y2Iu BTKBD9z8qFnqvBJ3RvTxBk04tqnsRlcPMPS5xRryRRVDMGr4k9EyH1LrZi+Nrk0lPtlF Hx6/vJibw7llVUiROfJ667C/tT1eLYHZXmWhpe6J9x4khqsYl/CmPlUn8M/SbV/uwZAo S/0w== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id 38-v6si1045844edt.374.2018.07.04.05.36.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 05:36:28 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F2F08AD9E; Wed, 4 Jul 2018 12:36:27 +0000 (UTC) Date: Wed, 4 Jul 2018 14:36:27 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Geert Uytterhoeven , Mike Rapoport , Greg Ungerer , Sam Creasey , linux-m68k , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM Message-ID: <20180704123627.GM22503@dhcp22.suse.cz> References: <1530685696-14672-1-git-send-email-rppt@linux.vnet.ibm.com> <1530685696-14672-4-git-send-email-rppt@linux.vnet.ibm.com> <20180704075410.GF22503@dhcp22.suse.cz> <89f48f7a-6cbf-ac9a-cacc-cd3ca79f8c66@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <89f48f7a-6cbf-ac9a-cacc-cd3ca79f8c66@suse.cz> User-Agent: Mutt/1.10.0 (2018-05-17) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP [CC Andrew - email thread starts http://lkml.kernel.org/r/1530685696-14672-1-git-send-email-rppt@linux.vnet.ibm.com] OK, so here we go with the full patch. From 0e8432b875d98a7a0d3f757fce2caa8d16a8de15 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Wed, 4 Jul 2018 14:31:46 +0200 Subject: [PATCH] memblock: do not complain about top-down allocations for !MEMORY_HOTREMOVE Mike Rapoport is converting architectures from bootmem to noboodmem allocator. While doing so for m68k Geert has noticed that he gets a scary looking warning WARNING: CPU: 0 PID: 0 at mm/memblock.c:230 memblock_find_in_range_node+0x11c/0x1be memblock: bottom-up allocation failed, memory hotunplug may be affected Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.18.0-rc3-atari-01343-gf2fb5f2e09a97a3c-dirty #7 Stack from 003c3e20: 003c3e20 0039cf44 00023800 00433000 ffffffff 00001000 00240000 000238aa 00378734 000000e6 004285ac 00000009 00000000 003c3e58 003787c0 003c3e74 003c3ea4 004285ac 00378734 000000e6 003787c0 00000000 00000000 00000001 00000000 00000010 00000000 00428490 003e3856 ffffffff ffffffff 003c3ed0 00044620 003c3ee0 00417a10 00240000 00000010 00000000 00000000 00000001 00000000 00000001 00240000 00000000 00000000 00000000 00001000 003e3856 Call Trace: [<00023800>] __warn+0xa8/0xc2 [<00001000>] kernel_pg_dir+0x0/0x1000 [<00240000>] netdev_lower_get_next+0x2/0x22 [<000238aa>] warn_slowpath_fmt+0x2e/0x36 [<004285ac>] memblock_find_in_range_node+0x11c/0x1be [<004285ac>] memblock_find_in_range_node+0x11c/0x1be [<00428490>] memblock_find_in_range_node+0x0/0x1be [<00044620>] vprintk_func+0x66/0x6e [<00417a10>] memblock_virt_alloc_internal+0xd0/0x156 [<00240000>] netdev_lower_get_next+0x2/0x22 [<00240000>] netdev_lower_get_next+0x2/0x22 [<00001000>] kernel_pg_dir+0x0/0x1000 [<00417b8c>] memblock_virt_alloc_try_nid_nopanic+0x58/0x7a [<00240000>] netdev_lower_get_next+0x2/0x22 [<00001000>] kernel_pg_dir+0x0/0x1000 [<00001000>] kernel_pg_dir+0x0/0x1000 [<00010000>] EXPTBL+0x234/0x400 [<00010000>] EXPTBL+0x234/0x400 [<002f3644>] alloc_node_mem_map+0x4a/0x66 [<00240000>] netdev_lower_get_next+0x2/0x22 [<004155ca>] free_area_init_node+0xe2/0x29e [<00010000>] EXPTBL+0x234/0x400 [<00411392>] paging_init+0x430/0x462 [<00001000>] kernel_pg_dir+0x0/0x1000 [<000427cc>] printk+0x0/0x1a [<00010000>] EXPTBL+0x234/0x400 [<0041084c>] setup_arch+0x1b8/0x22c [<0040e020>] start_kernel+0x4a/0x40a [<0040d344>] _sinittext+0x344/0x9e8 The warning is basically saying that a top-down allocation can break memory hotremove because memblock allocation is not movable. But m68k doesn't even support MEMORY_HOTREMOVE is there is no point to warn about it. Make the warning conditional only to configurations that care. Reported-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Michal Hocko --- mm/memblock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 03d48d8835ba..2acec4033389 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -227,7 +227,8 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size, * so we use WARN_ONCE() here to see the stack trace if * fail happens. */ - WARN_ONCE(1, "memblock: bottom-up allocation failed, memory hotunplug may be affected\n"); + WARN_ONCE(IS_ENABLED(CONFIG_MEMORY_HOTREMOVE), + "memblock: bottom-up allocation failed, memory hotremove may be affected\n"); } return __memblock_find_range_top_down(start, end, size, align, nid,