From patchwork Wed Jul 11 10:14:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 10519251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 972936032A for ; Wed, 11 Jul 2018 10:14:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8783528D94 for ; Wed, 11 Jul 2018 10:14:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B13D28D9A; Wed, 11 Jul 2018 10:14:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 067D228D94 for ; Wed, 11 Jul 2018 10:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3ADA6B0003; Wed, 11 Jul 2018 06:14:51 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EC15D6B0006; Wed, 11 Jul 2018 06:14:51 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3D1B6B0007; Wed, 11 Jul 2018 06:14:51 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by kanga.kvack.org (Postfix) with ESMTP id 8DFA56B0003 for ; Wed, 11 Jul 2018 06:14:51 -0400 (EDT) Received: by mail-pg1-f197.google.com with SMTP id g5-v6so698284pgq.5 for ; Wed, 11 Jul 2018 03:14:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:references:mime-version:content-disposition:in-reply-to :user-agent; bh=ryHDkJ5KPX40ddGvRXi/ih/6n+xAA47opgrlj/UJNY0=; b=VWM482sv6yx1K8VdWGjlEMqBN9cdjtqVEc6+dJN+6G5Z++SkcJzTiPuTb8u4p/G8y7 SSxnj6GEDyUZHGOhrQAwPW9kuRSBzjnObNkerPoiQpvZxpISjNcIH8K4LYSoJ79kUzCP AmJByZ3ekWnnudRwHsqpK9N2ff1x21sNZpqA5XaihSZ9FpQT17eO2AapOcoXiA9Vl3G6 fDQVK/OsdNgTftKok3UhiD3+bUkLy2RSgCzPpgqL0wJFweIo/huS1NCjCOXsHtnbc64V qgm6CV3SRRanvBZvA86IOz8D3bZBZ7Wx+wUHLuavSdypUjml87qihfeMFFecA04cFCCm y/OA== X-Gm-Message-State: APt69E1p9Ra5qRX1Y39Wbde6I+NboWHoUr/j6KrZqUpv2LTFc9wM36sG hMYGGb6BxhhHC9VtBI6z3eIxbyywtH5gGlXWNBbnd8HE+GDktwuiRN1YRwC2dizIvLwpyUpLvcp MLn+F2azdVf7oanNt+2s4EKDG/qbFGYGnajduoORrMSqL/pbRdobtA/7gaHNbedCvJA== X-Received: by 2002:a62:138c:: with SMTP id 12-v6mr29677119pft.34.1531304091243; Wed, 11 Jul 2018 03:14:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdJ1VmSLFF0b77Z4og/x5KhaZYOgYixRFsNNZpgTdwmhT4S3fHxAyrbVq2or98hUQWmYvVO X-Received: by 2002:a62:138c:: with SMTP id 12-v6mr29677054pft.34.1531304090205; Wed, 11 Jul 2018 03:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531304090; cv=none; d=google.com; s=arc-20160816; b=oGtGfEfLmKsa9xtRGWjUgJKb86DRvQY5OYq3vm8L2medokOb1Lu3cXdNG3WQ/0dEcO no6g/lQfp0ATyPAjtZQWFMQ6QDL+N6YRZov6zMxfPv7y/FhPoh89F3Anx8vNQ+3Q4kxy iUMdGPhN9GwYqMTTbZFWxHlGjMAsZDwh7s1nQwMsrM2sgjK4eKGTbBDQoxe1M8R3FI1T jGrQJMKAIr5/Z3+OUY+JwFzvpcMgkbabJx5IYYeEBCOYOzUZr0FzTIuoMIfigFeNUbXg OUpVIR/8fPlS6GlDIbqqlFQMwrwqwUpGeFawEC+Sj769rPMiRjiv9CEXyWjkV/dBfIIt VERA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=ryHDkJ5KPX40ddGvRXi/ih/6n+xAA47opgrlj/UJNY0=; b=NRezoV5K4NYXFZo6aCADpD7S10ZGuhZiPfz3mxjykkk55O5Ank4cBh+v3FVrx10hxw TFGiQWZE510xXVCSiNdlrDBTpejMKhtkGlKtV93DrzetGg51U3zv4yqmg/VK8C/hckZS 3qZ/Cd2oQ1+sO+Y23aZUAeqJsB6LLng5MisX2XPdOofZqSLCFG07bHfqny2GjXllPw2W v5a2kzZrx6/9FpXYizKcPt0ELo8798z9/8QAXbU9ubvBh7fLqDli8j9cwHQjeT4g8fWu XG+e2n4afHeqBJK6HEn7ZpB1JuTw0VcqgzHH6n5KQbmRRQVMDTWt6Uiyf/Sy5OzhcSDw 6Meg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xmjB3UQl; spf=pass (google.com: domain of leon@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id a85-v6si21656826pfa.109.2018.07.11.03.14.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jul 2018 03:14:50 -0700 (PDT) Received-SPF: pass (google.com: domain of leon@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xmjB3UQl; spf=pass (google.com: domain of leon@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4503F208FA; Wed, 11 Jul 2018 10:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531304089; bh=Bp+yl/3OlWMuPBIsBBZQv8OYym8i7sttwmB3YyU0u4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xmjB3UQl5vBYCOMqPRFz5wFIwNv3DskbuQCDzzKN8037kbjM1b77vSJACAecCgvHr y36Q/B7KkMUGY5/GpYvNIE3S05xPba2OuxMzeAyNl9kT9gMk9AbtAQgcWE6P91Ejtv VMX/JLsouC2/pRsH2iEfsssmorbxTzf2W5jWeNTQ= Date: Wed, 11 Jul 2018 13:14:47 +0300 From: Leon Romanovsky To: Michal Hocko Cc: LKML , "David (ChunMing) Zhou" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Doug Ledford , Jason Gunthorpe , Mike Marciniszyn , Dennis Dalessandro , Sudeep Dutt , Ashutosh Dixit , Dimitri Sivanich , Boris Ostrovsky , Juergen Gross , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrea Arcangeli , kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, David Rientjes , Felix Kuehling Subject: Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers Message-ID: <20180711101447.GU3014@mtr-leonro.mtl.com> References: <20180622150242.16558-1-mhocko@kernel.org> <20180627074421.GF32348@dhcp22.suse.cz> <20180709122908.GJ22049@dhcp22.suse.cz> <20180710134040.GG3014@mtr-leonro.mtl.com> <20180710141410.GP14284@dhcp22.suse.cz> <20180710162020.GJ3014@mtr-leonro.mtl.com> <20180711090353.GD20050@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180711090353.GD20050@dhcp22.suse.cz> User-Agent: Mutt/1.10.0 (2018-05-17) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jul 11, 2018 at 11:03:53AM +0200, Michal Hocko wrote: > On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > > > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > > > This is the v2 of RFC based on the feedback I've received so far. The > > > > > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > > > > > because I have no idea how. > > > > > > > > > > > > Any further feedback is highly appreciated of course. > > > > > > > > > > Any other feedback before I post this as non-RFC? > > > > > > > > From mlx5 perspective, who is primary user of umem_odp.c your change looks ok. > > > > > > Can I assume your Acked-by? > > > > I didn't have a chance to test it because it applies on our rdma-next, but > > fails to compile. > > What is the compilation problem? Is it caused by the patch or some other > unrelated changed? Thanks for pushing me to take a look on it. Your patch needs the following hunk to properly compile at least on my system. I'll take it to our regression. Thanks > -- > Michal Hocko > SUSE Labs diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h index 369867501bed..1f364a157097 100644 --- a/include/linux/mmu_notifier.h +++ b/include/linux/mmu_notifier.h @@ -155,9 +155,9 @@ struct mmu_notifier_ops { * cannot block, mmu_notifier_ops.flags should have * MMU_INVALIDATE_DOES_NOT_BLOCK set. */ - void (*invalidate_range_start)(struct mmu_notifier *mn, + int (*invalidate_range_start)(struct mmu_notifier *mn, struct mm_struct *mm, - unsigned long start, unsigned long end); + unsigned long start, unsigned long end, bool blockable); void (*invalidate_range_end)(struct mmu_notifier *mn, struct mm_struct *mm, unsigned long start, unsigned long end); @@ -229,7 +229,7 @@ extern int __mmu_notifier_test_young(struct mm_struct *mm, unsigned long address); extern void __mmu_notifier_change_pte(struct mm_struct *mm, unsigned long address, pte_t pte); -extern void __mmu_notifier_invalidate_range_start(struct mm_struct *mm, +extern int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, unsigned long start, unsigned long end, bool blockable); extern void __mmu_notifier_invalidate_range_end(struct mm_struct *mm, diff --git a/include/linux/oom.h b/include/linux/oom.h index 6adac113e96d..92f70e4c6252 100644 --- a/include/linux/oom.h +++ b/include/linux/oom.h @@ -95,7 +95,7 @@ static inline int check_stable_address_space(struct mm_struct *mm) return 0; } -void __oom_reap_task_mm(struct mm_struct *mm); +bool __oom_reap_task_mm(struct mm_struct *mm); extern unsigned long oom_badness(struct task_struct *p, struct mem_cgroup *memcg, const nodemask_t *nodemask, diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 7e0c6e78ae5c..7c7bd6f3298e 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -1,6 +1,6 @@ /* * linux/mm/oom_kill.c - * + * * Copyright (C) 1998,2000 Rik van Riel * Thanks go out to Claus Fischer for some serious inspiration and * for goading me into coding this file... @@ -569,7 +569,7 @@ static bool oom_reap_task_mm(struct task_struct *tsk, struct mm_struct *mm) if (!__oom_reap_task_mm(mm)) { up_read(&mm->mmap_sem); ret = false; - goto out_unlock; + goto unlock_oom; } pr_info("oom_reaper: reaped process %d (%s), now anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n",