From patchwork Fri Jul 20 19:51:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 10538203 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 76BE06029B for ; Fri, 20 Jul 2018 19:51:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D2CF29412 for ; Fri, 20 Jul 2018 19:51:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 410892943A; Fri, 20 Jul 2018 19:51:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9673F29412 for ; Fri, 20 Jul 2018 19:51:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 997196B0005; Fri, 20 Jul 2018 15:51:49 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 947F96B026C; Fri, 20 Jul 2018 15:51:49 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85C486B026D; Fri, 20 Jul 2018 15:51:49 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id 43F5E6B0005 for ; Fri, 20 Jul 2018 15:51:49 -0400 (EDT) Received: by mail-pg1-f198.google.com with SMTP id o16-v6so6577926pgv.21 for ; Fri, 20 Jul 2018 12:51:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=PCBce+wgRpQnLgBW61w8E+p3DlYFf4B+5GWLtQV61yY=; b=eXIdTyF3xPvyvysnZ3DWKBZ+/hZPe8sqbyAoqqZrglERrbt0VhCoWP1LqJChwQEqNG JR1A+8Gn2vlrZ/vW+gkFLegLX3M/AGcI8GihB3cWb2IDSLHG6Rt7CjiRKEg8WzJ543eO 5io/tWdKAZKfLFo9ZfbGvx+U+RyNQf81i4BcbW812yGn6qLBqZv7hgTUMg6IuUjSWonN if4C5aU2RyM+gT50Fqi02IrwcIdhNZOep8frXZszm10WH771fo3e6aNV0Ejp6p1O4gcC BSYXe2cybUiytPMP8Evx+GluImjhaN5X2pKN8v3R7gmj0cxhEExN6D7wmb7IL+e8M+CX gbHA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Gm-Message-State: AOUpUlHdN8yT36D/a84Czy1/aEsOJNDRKs1mslwv2abE+03FdlAMGHOj Dem3tMuFMn0bgru/Nr6UjMWQEumxLsFSLALI3qLv4ySC3jTrGmmu37aLq+TsE+TRo4ch+0IVffT r0e4Apvy4ZTMaT07uAtizWQNqh8WfOPBfhwb1TRjGI5jj4bRunQj6ouzsvWZlNsJJzQ== X-Received: by 2002:a62:990f:: with SMTP id d15-v6mr3504114pfe.162.1532116308896; Fri, 20 Jul 2018 12:51:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfJ5N9Gi9apWHoFpBoYeSoFgt1k0qsrmZ5iNaHLESUdH1RwBYATEGgsuzCTh0IZ9l8ftiji X-Received: by 2002:a62:990f:: with SMTP id d15-v6mr3504090pfe.162.1532116308103; Fri, 20 Jul 2018 12:51:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532116308; cv=none; d=google.com; s=arc-20160816; b=K09VAYqllvHAbD3DJFp93P5PrLLvshlOHud+MgBdjd3c+9/e2Pa9PtYZny3EkqtzQ1 UI2R5jNWm6lK4BM5yMLGW++QqdUytH4QQ3/c15/h7bjtNpfYe5VRr6mp+6ycvKeERMAs Kh6u7OUwsAU/LYmWvnGCvG5KNGmoc7TKEdfo1/lmc3lo+gDwCWuqSvlytRh+2NWsDXjv 5CqXG4z26UGBkqmFTB4LLlXz/yRa+GgiWgguaC3CGcIopcxSIXMamBo9KvU7R5UwHXtF 2eIs+3QZ3ep2t3K66UPb/2H91yRNKvCRgWG91PSJSSADARKnu/AvEVrwzvNim6Wd1Fll lvOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=PCBce+wgRpQnLgBW61w8E+p3DlYFf4B+5GWLtQV61yY=; b=Y3z84DHXAwskPUHTX6iCTdBoGifdMSNN/LI7hiOoRQZg3VGw/QhZwgzYjLQyJ+g1z/ Yz5AWazrrkZXWkkYOWULE4DoViF92zWYTRSI/vk2Hp8tesPDPDlhREsSM9/Wlew4TLep cs2rH9dkqG9Q+m8/C2eXDdldIhqgcddHOjwEyW/R0MfzyPyz/0dS1ux258gDApJnFcId wAJwGMM/Z3oQxLyhc/o6iroi9YvaumCyFwF5wVzIKtjWyvuzSaI3/NQLHBaP+0Rzjubt NVyZAbnf1aB9uAkzFlZXWvMvmAA4vVMRsf3jIp4fwEtt4Nzamo3lXqjqG6YpuXSBha6J VolQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id h66-v6si2616385pfa.238.2018.07.20.12.51.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jul 2018 12:51:48 -0700 (PDT) Received-SPF: pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6FDAACFF; Fri, 20 Jul 2018 19:51:47 +0000 (UTC) Date: Fri, 20 Jul 2018 12:51:46 -0700 From: Andrew Morton To: Mark Vitale Cc: "linux-mm@kvack.org" , Dan Williams , Joe Gorse , "release-team@openafs.org" , Jerome Glisse Subject: Re: [PATCH v4 0/8] mm: Rework hmm to use devm_memremap_pages and other fixes Message-Id: <20180720125146.02db0f40b4edc716c6f080d2@linux-foundation.org> In-Reply-To: <37267986-A987-4AD7-96CE-C1D2F116A4AC@sinenomine.net> References: <37267986-A987-4AD7-96CE-C1D2F116A4AC@sinenomine.net> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 20 Jul 2018 14:43:14 +0000 Mark Vitale wrote: > On Jul 11, 2018, Dan Williams wrote: > > Changes since v3 [1]: > > * Collect Logan's reviewed-by on patch 3 > > * Collect John's and Joe's tested-by on patch 8 > > * Update the changelog for patch 1 and 7 to better explain the > > EXPORT_SYMBOL_GPL rationale. > > * Update the changelog for patch 2 to clarify that it is a cleanup to > > make the following patch-3 fix easier > > > > [1]: https://lkml.org/lkml/2018/6/19/108 > > > > --- > > > > Hi Andrew, > > > > As requested, here is a resend of the devm_memremap_pages() fixups. > > Please consider for 4.18. > > What is the status of this patchset? OpenAFS is unable to build on > Linux 4.18 without the last patch in this set: > > 8/8 mm: Fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL > > Will this be merged soon to linux-next, and ultimately to a Linux 4.18 rc? > Problem is, that patch is eighth in a series which we're waiting for Jerome to review and the changelog starts with "Now that all producers of dev_pagemap instances in the kernel are properly converted to EXPORT_SYMBOL_GPL...". Is it in fact a standalone patch? Not sure. I'll see what the build system has to say about that. And it will need a new changelog. Such as From: Dan Williams Subject: mm: fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL e76384884344 ("mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS") added two EXPORT_SYMBOL_GPL() symbols, but these symbols are required by the inlined put_page(), thus accidentally making put_page() a GPL export only. This breaks OpenAFS (at least). Mark them EXPORT_SYMBOL() instead. Link: http://lkml.kernel.org/r/153128611970.2928.11310692420711601254.stgit@dwillia2-desk3.amr.corp.intel.com Fixes: e76384884344 ("mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS") Signed-off-by: Dan Williams Reported-by: Joe Gorse Reported-by: John Hubbard Tested-by: Joe Gorse Tested-by: John Hubbard Cc: Jérôme Glisse Cc: Mark Vitale Signed-off-by: Andrew Morton --- kernel/memremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN kernel/memremap.c~mm-fix-exports-that-inadvertently-make-put_page-export_symbol_gpl kernel/memremap.c --- a/kernel/memremap.c~mm-fix-exports-that-inadvertently-make-put_page-export_symbol_gpl +++ a/kernel/memremap.c @@ -321,7 +321,7 @@ EXPORT_SYMBOL_GPL(get_dev_pagemap); #ifdef CONFIG_DEV_PAGEMAP_OPS DEFINE_STATIC_KEY_FALSE(devmap_managed_key); -EXPORT_SYMBOL_GPL(devmap_managed_key); +EXPORT_SYMBOL(devmap_managed_key); static atomic_t devmap_enable; /* @@ -362,5 +362,5 @@ void __put_devmap_managed_page(struct pa } else if (!count) __put_page(page); } -EXPORT_SYMBOL_GPL(__put_devmap_managed_page); +EXPORT_SYMBOL(__put_devmap_managed_page); #endif /* CONFIG_DEV_PAGEMAP_OPS */