Message ID | 20180801151308.32234-8-hannes@cmpxchg.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1807315E9 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 1 Aug 2018 15:10:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07ECF2B8C7 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 1 Aug 2018 15:10:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 050552B59E; Wed, 1 Aug 2018 15:10:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 867122B8B5 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 1 Aug 2018 15:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20F406B0010; Wed, 1 Aug 2018 11:10:43 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 19C8C6B026A; Wed, 1 Aug 2018 11:10:43 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01DD46B026B; Wed, 1 Aug 2018 11:10:42 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id AE8296B0010 for <linux-mm@kvack.org>; Wed, 1 Aug 2018 11:10:42 -0400 (EDT) Received: by mail-qk0-f200.google.com with SMTP id w126-v6so16927650qka.11 for <linux-mm@kvack.org>; Wed, 01 Aug 2018 08:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:reply-to; bh=EOH4yuXU61UFUoCxssnGS0E9pmyAjCBzpOCJhmVNCYY=; b=py395YL0Q6KbpCtNiAqWRX6mRXgSZxF2gVKALuB1Z2b19kTHRYI9OAKKzYlsK5XX14 CkHVt9HUHsnR5TzZEuzP+g8X2/47ewJnATpk+wLlht4ZPhV7EBblyO4YwbO0tXeGYIiy kpFQDwE/rEIUQeYKy8do4Ma+bRqtuKsfBPhy+66MVb8Kbig/tzP1kUzEdsw31E+xia1B MNfVvXga4BQ3ZKlQPkbhB6+CMAFr1b8J/hnfpHGi+6nGTf59s7jz0zbnsq0AIVaWGMsc McyydZCVkHmimx4TpL5ub5NRIBxyx5OP133WLal4YQXyX7PmoSmCYQFcvES/LCtRvBUp G/QQ== X-Gm-Message-State: AOUpUlFPAKfp5XHF9us1FYx/hVGWqmWm09KDwBd651JEiH3VTii1Y4QL sInyowHa3/egu0qL9nbX7XSkjrtSDpyu/Hl5aswMrY+eKCE1vx9nEDj6WmBNCbqS1Ev8m9Wyshb w2oLJLszf/fDa1iILRjlJErb7E3e3TbMsuAJHwRvy3R+onV5m6Livp4wj6hxlaAJFFk1ztsjOfW GPGtidVhHRwwZwdUZz3u2r1OFHLKSz29sWl3+QNkx1otykiolYjPM3sFi/uOI0IEx7cDgXI8Ala 1i9SUug4fb7f0LUGyQTDcIj0WZyj+9MG8tmtD0inzTdGAEckV2MmhvG0wT1jGuA9TrVUq3l42eh Mm0LLKE+kbKBGqFQHSwsvt/j2steuoKJag89JGOmfc2/c58qRgEbA3yzK+kPNM1xIml2N+NvHaQ l X-Received: by 2002:a37:209:: with SMTP id 9-v6mr24393557qkc.267.1533136242488; Wed, 01 Aug 2018 08:10:42 -0700 (PDT) X-Received: by 2002:a37:209:: with SMTP id 9-v6mr24393500qkc.267.1533136241797; Wed, 01 Aug 2018 08:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533136241; cv=none; d=google.com; s=arc-20160816; b=s1HseW09rU2UO1okG0S7OTqOgcnPHNSJMBbhTZ5rYjWimwAf0cebC9M8QGaJVla5hC W3TB0uRCJw3rXNyg6l1tDM/aQ0sMOHaXI+bY1ZJt2+C+QxH52C7GFhzqDGc6G4/XmTFt XpVu9yn0aDxyuEQ3oAig4HCY4VvAQ1gVuMJo7JprjSD/1Gyc/BBc7TBJGMytbA6p1A4D LjTG8dOzj/BLXAHSzkFE2axzmN2tKPWsp2CHwSrJeDqusbqej52L+vfoTWUpRZWuIZBG rRMb8SIc5GBhOX4jJyVq5Vs3esglQE76X9Lh40uzpFk5d8O23Z5fJdUFP/1ZqvMiCpgZ PtlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=EOH4yuXU61UFUoCxssnGS0E9pmyAjCBzpOCJhmVNCYY=; b=Rc8ESVcePSKoTaC25C155NVvsGcHO+z+C3Q0Y4VlM8vwxqdw1JetQH7pJHjgRm5OCv MzqzmwIlJwRrH20prCXekTKGUdpbCe6yzdHQAgmDTeVzEYAKs5P5UEcW20i2xFfGSBHu KnbmqKuaBQ0f5q6N8yMfoE/VjBbkgq8I7c3Q3JQKFXz7XTSMn9Q+p8zzjgLY3zihz7hg LHLY4mg4CH1/E9lfG4m7tFuA2LKToHz/VY1ryI5b5sDaQc3y41VrWd/PtG1vB/PgOhN1 3IX8EPL4rqwZdaNtM1Otyarq0NVDAPESKqydBcJrLHLKdqzVV+bvFHZmT9Rdj4sX96eh CDFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=u3XnHwSJ; spf=pass (google.com: domain of hannes@cmpxchg.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id t22-v6sor9168141qtj.100.2018.08.01.08.10.41 for <linux-mm@kvack.org> (Google Transport Security); Wed, 01 Aug 2018 08:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of hannes@cmpxchg.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=u3XnHwSJ; spf=pass (google.com: domain of hannes@cmpxchg.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to; bh=EOH4yuXU61UFUoCxssnGS0E9pmyAjCBzpOCJhmVNCYY=; b=u3XnHwSJciBcoj/yAksVr1B4Cciwoa8pOCR7d5EEbJAVWeEaybzXabszZvXD59AdCS 1dhH0ucYa9ztPoa+M1wOw+LYwXGV4VtAU4Q8b2H5JyNZbgn0VRpoC7v7osJ/IlIn/Wps KtCCvSljTUfhS/2lQu6G7PrEtDPwDP127Ey0b8mszWlBWsdzQAB6Vj/AKN3hcxDBNDJV MgJDcqooMyVnLRJ7fa+2Zcsd5zra2aDOdCsTqEcjo/YEl+WvOHTmsKfzUB3jFMnoCr8d 5qs6DZm430rKNooblKjzNyN7ORI7Hu3bjtHznnL+4/TyTmfmMINypNZjKv3D6BdBPNVO ssAg== X-Google-Smtp-Source: AAOMgpefmFF1AMx6ZjQphuvdFTfXnZ2hHlz9PBS9M3WRf0B9bzvIErHEtBindmWbPwaXHPtDtN86sw== X-Received: by 2002:ac8:1834:: with SMTP id q49-v6mr26268816qtj.223.1533136241602; Wed, 01 Aug 2018 08:10:41 -0700 (PDT) Received: from localhost (216.49.36.201.res-cmts.bus.ptd.net. [216.49.36.201]) by smtp.gmail.com with ESMTPSA id o124-v6sm12186506qkd.61.2018.08.01.08.10.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 08:10:40 -0700 (PDT) From: Johannes Weiner <hannes@cmpxchg.org> To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org> Cc: Tejun Heo <tj@kernel.org>, Suren Baghdasaryan <surenb@google.com>, Daniel Drake <drake@endlessm.com>, Vinayak Menon <vinmenon@codeaurora.org>, Christopher Lameter <cl@linux.com>, Mike Galbraith <efault@gmx.de>, Shakeel Butt <shakeelb@google.com>, Peter Enderborg <peter.enderborg@sony.com>, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH 7/9] sched: introduce this_rq_lock_irq() Date: Wed, 1 Aug 2018 11:13:06 -0400 Message-Id: <20180801151308.32234-8-hannes@cmpxchg.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180801151308.32234-1-hannes@cmpxchg.org> References: <20180801151308.32234-1-hannes@cmpxchg.org> Reply-To: "[PATCH 0/9]"@kvack.org, "psi:pressure"@kvack.org, stall@kvack.org, information@kvack.org, for@kvack.org, CPU@kvack.org, memory@kvack.org, and@kvack.org, IO@kvack.org, v3@kvack.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
[1/9] mm: workingset: don't drop refault information prematurely
|
expand
|
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 211890edf37e..9586a8141f16 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4960,9 +4960,7 @@ static void do_sched_yield(void) struct rq_flags rf; struct rq *rq; - local_irq_disable(); - rq = this_rq(); - rq_lock(rq, &rf); + rq = this_rq_lock_irq(&rf); schedstat_inc(rq->yld_count); current->sched_class->yield_task(rq); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index b8f038497240..bc798c7cb4d4 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1119,6 +1119,18 @@ rq_unlock(struct rq *rq, struct rq_flags *rf) raw_spin_unlock(&rq->lock); } +static inline struct rq * +this_rq_lock_irq(struct rq_flags *rf) + __acquires(rq->lock) +{ + struct rq *rq; + + local_irq_disable(); + rq = this_rq(); + rq_lock(rq, rf); + return rq; +} + #ifdef CONFIG_NUMA enum numa_topology_type { NUMA_DIRECT,
do_sched_yield() disables IRQs, looks up this_rq() and locks it. The next patch is adding another site with the same pattern, so provide a convenience function for it. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> --- kernel/sched/core.c | 4 +--- kernel/sched/sched.h | 12 ++++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-)