diff mbox series

[2/4] mm: workingset: use cheaper __inc_lruvec_state in irqsafe node reclaim

Message ID 20181009184732.762-3-hannes@cmpxchg.org (mailing list archive)
State New, archived
Headers show
Series mm: workingset & shrinker fixes | expand

Commit Message

Johannes Weiner Oct. 9, 2018, 6:47 p.m. UTC 
No need to use the preemption-safe lruvec state function inside the
reclaim region that has irqs disabled.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/workingset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rik van Riel Oct. 10, 2018, 12:55 a.m. UTC | #1 
On Tue, 2018-10-09 at 14:47 -0400, Johannes Weiner wrote:
> No need to use the preemption-safe lruvec state function inside the
> reclaim region that has irqs disabled.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Rik van Riel <riel@surriel.com>
diff mbox series

Patch

diff --git a/mm/workingset.c b/mm/workingset.c
index e5c70bc94077..f564aaa6b71d 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -493,7 +493,7 @@  static enum lru_status shadow_lru_isolate(struct list_head *item,
 	 * shadow entries we were tracking ...
 	 */
 	xas_store(&xas, NULL);
-	inc_lruvec_page_state(virt_to_page(node), WORKINGSET_NODERECLAIM);
+	__inc_lruvec_page_state(virt_to_page(node), WORKINGSET_NODERECLAIM);
 
 out_invalid:
 	xa_unlock_irq(&mapping->i_pages);